From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Biju Das <biju.das.au@gmail.com>
Subject: Re: [PATCH] pinctrl: cy8c95x0: Simplify probe()
Date: Mon, 4 Sep 2023 12:08:25 +0300 [thread overview]
Message-ID: <ZPWeicmYLUTgvGpm@smile.fi.intel.com> (raw)
In-Reply-To: <20230902082225.8777-1-biju.das.jz@bp.renesas.com>
On Sat, Sep 02, 2023 at 09:22:25AM +0100, Biju Das wrote:
> Simpilfy probe() by replacing device_get_match_data() and id lookup for
ID
> retrieving match data by i2c_get_match_data().
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
I can test it at some point, but I don't see the point to failure,
so I consider the priority is low for that.
Easier to me to test when it lands Linux Next, which I can run without much
effort on the Intel Galileo Gen 1 board (with this chip connected).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-04 9:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 8:22 [PATCH] pinctrl: cy8c95x0: Simplify probe() Biju Das
2023-09-04 9:08 ` Andy Shevchenko [this message]
2023-09-12 7:57 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPWeicmYLUTgvGpm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick.rudolph@9elements.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.