From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 1/2] gpiolib: rename gpio_set_debounce_timeout() for consistency
Date: Mon, 4 Sep 2023 12:30:23 +0300 [thread overview]
Message-ID: <ZPWjr7CP+WK064PI@smile.fi.intel.com> (raw)
In-Reply-To: <ZPWiZSgyar1zWfR1@smile.fi.intel.com>
On Mon, Sep 04, 2023 at 12:24:53PM +0300, Andy Shevchenko wrote:
> On Mon, Sep 04, 2023 at 09:34:09AM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > All other functions that manipulate a struct gpio_desc use the gpiod_
> > prefix. Follow this convention and rename gpio_set_debounce_timeout() to
> > gpiod_set_debounce_timeout().
>
> No, that's not true. This one is inline with the other gpio_set() _internal_
> APIs. If renamed, should be done consistently.
It's even broader, like for_each_gpio_desc(). So, looking at that one I would
rather use gpio_desc_ prefix / suffix than gpiod in case you are so eager to
rename (Personally I consider this as unneeded churn). Also consider going
thru all _internal_ APIs, like gpiod_not_found(), to be renamed to
gpio_desc_not_found().
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-04 9:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 7:34 [PATCH 1/2] gpiolib: rename gpio_set_debounce_timeout() for consistency Bartosz Golaszewski
2023-09-04 7:34 ` [PATCH 2/2] gpiolib: rename gpio_chip_hwgpio() " Bartosz Golaszewski
2023-09-04 9:27 ` Andy Shevchenko
2023-09-05 8:37 ` Bartosz Golaszewski
2023-09-05 10:33 ` Andy Shevchenko
2023-09-05 11:26 ` Bartosz Golaszewski
2023-09-05 11:59 ` Andy Shevchenko
2023-09-06 21:39 ` Linus Walleij
2023-09-04 9:24 ` [PATCH 1/2] gpiolib: rename gpio_set_debounce_timeout() " Andy Shevchenko
2023-09-04 9:30 ` Andy Shevchenko [this message]
2023-09-05 8:36 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPWjr7CP+WK064PI@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.