From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6F16C83F2C for ; Mon, 4 Sep 2023 10:35:31 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0D11D832; Mon, 4 Sep 2023 12:34:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0D11D832 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1693823728; bh=zu+tMGAxaM9YFrYI5l7kCZRRlpRcpVet28df0zWTJwc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=e7sPViqtzyab9E3mbnXzHK0JCAShgMyBwet+5G18sCtRB0boQgUgh5j5rBSNNkg1x mbAzOr8pHEYeOwPNx1ncdsmWIPxCl0Q1XTWmFHKzcpLjWnjTPLMCPNUD0TcFeW25nX zG6KA4AtZTqN7ZwqNTvluXQgH9MmmfzjhshetQOI= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 91592F80431; Mon, 4 Sep 2023 12:34:09 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id DA776F8047D; Mon, 4 Sep 2023 12:34:08 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5B21DF8047D; Mon, 4 Sep 2023 12:32:34 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 69BE4F80141 for ; Mon, 4 Sep 2023 12:32:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 69BE4F80141 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=a25ZvfaW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693823545; x=1725359545; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=zu+tMGAxaM9YFrYI5l7kCZRRlpRcpVet28df0zWTJwc=; b=a25ZvfaWY22BwVD461Jk11MgOjZl9u7375T0hYHg6/u3H2OoDvvUAcJS nzPgkyZPeKDQmH+6QVBlCdNmSS/d7aaacT30GKjd94Ahf5eE+PelMvlXU StnGnGkk1DNsfQ2QkgSvWB5rwYSeixbFNEcwYo18kW+QscDKgdlMFPO+G 3sqF5NVsCkzCPJWusxeNZMbQTDfwbhwlJJK2t6yDFfeFRaR7JPTb2Rbqg 4phWvGWQ5RBIRhCpP1/0mz+xfOwMWcdTCBqQKLMytTTka2RrEYdCK6k6N RtGMQkAfSn246RjuKcIoHQE+TmXZ3Jhzzd9Ai7bL+ActiQcxXQsdEuWKx A==; X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="375461221" X-IronPort-AV: E=Sophos;i="6.02,226,1688454000"; d="scan'208";a="375461221" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 03:32:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="806220201" X-IronPort-AV: E=Sophos;i="6.02,226,1688454000"; d="scan'208";a="806220201" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 03:32:17 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qd6sQ-006Osv-0k; Mon, 04 Sep 2023 13:32:14 +0300 Date: Mon, 4 Sep 2023 13:32:13 +0300 From: Andy Shevchenko To: Shenghao Ding Cc: tiwai@suse.de, robh+dt@kernel.org, lgirdwood@gmail.com, perex@perex.cz, pierre-louis.bossart@linux.intel.com, kevin-lu@ti.com, 13916275206@139.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com, mengdong.lin@intel.com, baojun.xu@ti.com, thomas.gfeller@q-drop.com, peeyush@ti.com, navada@ti.com, broonie@kernel.org, gentuser@gmail.com Subject: Re: [PATCH v1] ALSA: hda/tas2781: Update tas2781 HDA driver Message-ID: References: <20230904090725.1388-1-shenghao-ding@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230904090725.1388-1-shenghao-ding@ti.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Message-ID-Hash: XZ7A5BAOUZCWHYHG6BRP2CLCFQVRIYWD X-Message-ID-Hash: XZ7A5BAOUZCWHYHG6BRP2CLCFQVRIYWD X-MailFrom: andriy.shevchenko@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Sep 04, 2023 at 05:07:24PM +0800, Shenghao Ding wrote: > Revert structure cs35l41_dev_name and redefine tas2781_generic_fixup. ... > /* check the bus name */ > - if (strncmp(d, p->bus, n)) > + if (strncmp(d, bus, n)) > return 0; > /* skip the bus number */ > if (isdigit(d[n])) > n++; > /* the rest must be exact matching */ > - snprintf(tmp, sizeof(tmp), "-%s:00", p->hid); > + snprintf(tmp, sizeof(tmp), "-%s:00", "TIAS2781"); > > return !strcmp(d + n, tmp); Try to use one of the respectve acpi_*_match*() APIs. -- With Best Regards, Andy Shevchenko