Re: [PATCH v1] perf parse-events: Fix driver config term

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Mon, Sep 04, 2023 at 08:51:37PM -0700, Ian Rogers escreveu:
> On Mon, Sep 4, 2023 at 8:38 PM Ian Rogers <irogers@google.com> wrote:
> >
> > Inadvertently deleted in commit 30f4ade33d64 ("perf tools: Revert
> > enable indices setting syntax for BPF map").
> >
> 
> Sorry, should also have:
> Fixes: 30f4ade33d64 ("perf tools: Revert enable indices setting syntax
> for BPF map")

I added it, thanks.
 
> Thanks,
> Ian
> 
> > Reported-by: James Clark <james.clark@arm.com>
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> >  tools/perf/util/parse-events.y | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >
> > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> > index 4a305df61f74..21bfe7e0d944 100644
> > --- a/tools/perf/util/parse-events.y
> > +++ b/tools/perf/util/parse-events.y
> > @@ -839,6 +839,23 @@ PE_TERM
> >
> >         $$ = term;
> >  }
> > +|
> > +PE_DRV_CFG_TERM
> > +{
> > +       struct parse_events_term *term;
> > +       char *config = strdup($1);
> > +       int err;
> > +
> > +       if (!config)
> > +               YYNOMEM;
> > +       err = parse_events_term__str(&term, PARSE_EVENTS__TERM_TYPE_DRV_CFG, config, $1, &@1, NULL);
> > +       if (err) {
> > +               free($1);
> > +               free(config);
> > +               PE_ABORT(err);
> > +       }
> > +       $$ = term;
> > +}
> >
> >  sep_dc: ':' |
> >
> > --
> > 2.42.0.283.g2d96d420d3-goog
> >

-- 

- Arnaldo