From: Vikram Garhwal <vikram.garhwal@amd.com>
To: Michal Orzel <michal.orzel@amd.com>
Cc: xen-devel@lists.xenproject.org, julien@xen.org,
sstabellini@kernel.org, Rahul Singh <rahul.singh@arm.com>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [XEN][PATCH v11 12/20] xen/smmu: Add remove_device callback for smmu_iommu ops
Date: Tue, 5 Sep 2023 11:22:33 -0400 [thread overview]
Message-ID: <ZPdHuVUOqjmdEWdD@amd.com> (raw)
In-Reply-To: <dca9c2b9-aeaf-3628-de2a-846e1b92a0c4@amd.com>
Hi Michal,
On Mon, Sep 04, 2023 at 12:38:01PM +0200, Michal Orzel wrote:
>
>
> On 01/09/2023 06:59, Vikram Garhwal wrote:
> > Add remove_device callback for removing the device entry from smmu-master using
> > following steps:
> > 1. Find if SMMU master exists for the device node.
> > 2. Check if device is currently in use.
> Just like in v10: you are not checking it. I asked you to add a check following Julien suggestion
> but you did not reply to it. Even if you do not want to add this extra layer of protection, you
> should mention that you rely on a check in iommu_remove_dt_device() instead. You can wait for Stefano
> to give his opinion (and possibly ack this patch as is).
>
Caller checks it already so that was the reason for not adding here. IIUC, Stefano
was okay with v10 patch so that's why i didn't make changes.
> ~Michal
next prev parent reply other threads:[~2023-09-05 15:23 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 4:59 [XEN][PATCH v11 00/20] dynamic node programming using overlay dtbo Vikram Garhwal
2023-09-01 4:59 ` [XEN][PATCH v11 01/20] common/device_tree: handle memory allocation failure in __unflatten_device_tree() Vikram Garhwal
2023-09-01 4:59 ` [XEN][PATCH v11 02/20] common/device_tree.c: unflatten_device_tree() propagate errors Vikram Garhwal
2023-09-01 4:59 ` [XEN][PATCH v11 03/20] xen/arm/device: Remove __init from function type Vikram Garhwal
2023-09-06 0:23 ` Stefano Stabellini
2023-09-01 4:59 ` [XEN][PATCH v11 04/20] common/device_tree: Export __unflatten_device_tree() Vikram Garhwal
2023-09-01 4:59 ` [XEN][PATCH v11 05/20] xen/arm: Add CONFIG_OVERLAY_DTB Vikram Garhwal
2023-09-06 0:24 ` Stefano Stabellini
2023-09-01 4:59 ` [XEN][PATCH v11 06/20] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB Vikram Garhwal
2023-09-01 4:59 ` [XEN][PATCH v11 07/20] libfdt: overlay: change overlay_get_target() Vikram Garhwal
2023-09-01 4:59 ` [XEN][PATCH v11 08/20] xen/device-tree: Add dt_find_node_by_path_from() to find nodes in device tree Vikram Garhwal
2023-09-01 4:59 ` [XEN][PATCH v11 09/20] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller Vikram Garhwal
2023-09-06 0:28 ` Stefano Stabellini
2023-09-01 4:59 ` [XEN][PATCH v11 10/20] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock Vikram Garhwal
2023-09-06 0:29 ` Stefano Stabellini
2023-09-01 4:59 ` [XEN][PATCH v11 11/20] xen/iommu: Introduce iommu_remove_dt_device() Vikram Garhwal
2023-09-04 10:31 ` Michal Orzel
2023-09-06 0:35 ` Stefano Stabellini
2023-09-01 4:59 ` [XEN][PATCH v11 12/20] xen/smmu: Add remove_device callback for smmu_iommu ops Vikram Garhwal
2023-09-04 10:38 ` Michal Orzel
2023-09-05 15:22 ` Vikram Garhwal [this message]
2023-09-06 0:37 ` Stefano Stabellini
2023-09-01 4:59 ` [XEN][PATCH v11 13/20] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h Vikram Garhwal
2023-09-01 4:59 ` [XEN][PATCH v11 14/20] common/device_tree: Add rwlock for dt_host Vikram Garhwal
2023-09-04 11:09 ` Michal Orzel
2023-09-05 15:38 ` Vikram Garhwal
2023-09-06 0:53 ` Stefano Stabellini
2023-09-01 4:59 ` [XEN][PATCH v11 15/20] arm/asm/setup.h: Update struct map_range_data to add rangeset Vikram Garhwal
2023-09-04 11:29 ` Michal Orzel
2023-09-06 0:42 ` Stefano Stabellini
2023-09-01 4:59 ` [XEN][PATCH v11 16/20] xen/arm: Implement device tree node removal functionalities Vikram Garhwal
2023-09-06 0:48 ` Stefano Stabellini
2023-09-01 4:59 ` [XEN][PATCH v11 17/20] xen/arm: Implement device tree node addition functionalities Vikram Garhwal
2023-09-06 0:53 ` Stefano Stabellini
2023-09-01 4:59 ` [XEN][PATCH v11 18/20] tools/libs/ctrl: Implement new xc interfaces for dt overlay Vikram Garhwal
2023-09-01 4:59 ` [XEN][PATCH v11 19/20] tools/libs/light: Implement new libxl functions for device tree overlay ops Vikram Garhwal
2023-09-01 4:59 ` [XEN][PATCH v11 20/20] tools/xl: Add new xl command overlay for device tree overlay support Vikram Garhwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPdHuVUOqjmdEWdD@amd.com \
--to=vikram.garhwal@amd.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=rahul.singh@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.