All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux@armlinux.org.uk, rmk+kernel@armlinux.org.uk
Subject: Re: [PATCH net] net: phylink: fix sphinx complaint about invalid literal
Date: Wed, 6 Sep 2023 13:34:08 +0700	[thread overview]
Message-ID: <ZPgdYPNSgRU5mIA-@debian.me> (raw)
In-Reply-To: <20230905234202.1152383-1-kuba@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]

On Tue, Sep 05, 2023 at 04:42:02PM -0700, Jakub Kicinski wrote:
> diff --git a/include/linux/phylink.h b/include/linux/phylink.h
> index 7d07f8736431..2b886ea654bb 100644
> --- a/include/linux/phylink.h
> +++ b/include/linux/phylink.h
> @@ -600,7 +600,7 @@ void pcs_get_state(struct phylink_pcs *pcs,
>   *
>   * The %neg_mode argument should be tested via the phylink_mode_*() family of
>   * functions, or for PCS that set pcs->neg_mode true, should be tested
> - * against the %PHYLINK_PCS_NEG_* definitions.
> + * against the PHYLINK_PCS_NEG_* definitions.
>   */
>  int pcs_config(struct phylink_pcs *pcs, unsigned int neg_mode,
>  	       phy_interface_t interface, const unsigned long *advertising,
> @@ -630,7 +630,7 @@ void pcs_an_restart(struct phylink_pcs *pcs);
>   *
>   * The %mode argument should be tested via the phylink_mode_*() family of
>   * functions, or for PCS that set pcs->neg_mode true, should be tested
> - * against the %PHYLINK_PCS_NEG_* definitions.
> + * against the PHYLINK_PCS_NEG_* definitions.
>   */
>  void pcs_link_up(struct phylink_pcs *pcs, unsigned int neg_mode,
>  		 phy_interface_t interface, int speed, int duplex);

The fix LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-09-06  6:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05 23:42 [PATCH net] net: phylink: fix sphinx complaint about invalid literal Jakub Kicinski
2023-09-06  6:34 ` Bagas Sanjaya [this message]
2023-09-06  6:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZPgdYPNSgRU5mIA-@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.