From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v1 1/3] perf completion: Restrict completion of events to events
Date: Wed, 6 Sep 2023 12:18:44 -0300 [thread overview]
Message-ID: <ZPiYVCO2XMLwMxo7@kernel.org> (raw)
In-Reply-To: <20230905181554.3202873-1-irogers@google.com>
Em Tue, Sep 05, 2023 at 11:15:52AM -0700, Ian Rogers escreveu:
> perf list will list libpfm4 events and metrics which aren't valid
> options to the '-e' option. Restrict the events gathered so that
> invalid ones aren't shown.
>
> Before:
> $ perf stat -e <tab><tab>
> Display all 633 possibilities? (y or n)
>
> After:
> $ perf stat -e <tab><tab>
> Display all 375 possibilities? (y or n)
Thanks, tested and applied.
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/perf-completion.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh
> index 978249d7868c..40cfc30ad7ad 100644
> --- a/tools/perf/perf-completion.sh
> +++ b/tools/perf/perf-completion.sh
> @@ -164,7 +164,7 @@ __perf_main ()
> $prev_skip_opts == @(record|stat|top) ]]; then
>
> local cur1=${COMP_WORDS[COMP_CWORD]}
> - local raw_evts=$($cmd list --raw-dump)
> + local raw_evts=$($cmd list --raw-dump hw sw cache tracepoint pmu sdt)
> local arr s tmp result cpu_evts
>
> # aarch64 doesn't have /sys/bus/event_source/devices/cpu/events
> --
> 2.42.0.283.g2d96d420d3-goog
>
--
- Arnaldo
prev parent reply other threads:[~2023-09-06 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 18:15 [PATCH v1 1/3] perf completion: Restrict completion of events to events Ian Rogers
2023-09-05 18:15 ` [PATCH v1 2/3] perf completion: Support completion of libpfm4 events Ian Rogers
2023-09-05 18:23 ` Namhyung Kim
2023-09-05 18:15 ` [PATCH v1 3/3] perf completion: Support completion of metrics/metricgroups Ian Rogers
2023-09-05 18:23 ` Namhyung Kim
2023-09-05 18:23 ` [PATCH v1 1/3] perf completion: Restrict completion of events to events Namhyung Kim
2023-09-06 15:18 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPiYVCO2XMLwMxo7@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.