Re: [OE-core] [PATCH] classes: Drop ';' delimiter from ROOTFS/IMAGE*COMMAND variables

[Mikko Rapeli <mikko.rapeli@linaro.org>]

Hi,

On Thu, Sep 07, 2023 at 11:11:20PM +0100, Richard Purdie wrote:
> Originally these were shell functions but they have long since been processed by
> bb.build.exec_func(). Since we no longer need shell syntax, we can drop the ';'
> delimiters and just use a space separated string.
> 
> This cleans up the variable and quietly removes any stray ';' that do happen to
> still make it in.

I'm afraid many layers and recipes may be breaking with this because of missing
space in appends, e.g.

IMAGE_PREPROCESS_COMMAND:append = "foo;"

used to work, and now will fail. Fix is to use

IMAGE_PREPROCESS_COMMAND:append = " foo"

but I wonder if we could help detect these?

And I have dislike for :append when a plain += would work
and would add the needed space chars and still allow overriding
the variable elsewhere when it is needed. But maybe that's just me.

Cheers,

-Mikko