From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98944EE57C1 for ; Fri, 8 Sep 2023 04:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WES46DGMtpMHNUr6lE3qbBAb4U+CcKfbNddIhCjqMWU=; b=myLqld+StKEwbt ssO9BzTNOP5lFK4QRf43ptnAqORJFPv0367ub0TshasbWv1g/u3MFtcbAnKh6M/kLUGaJA37DcUAY jMckxan569S3+j6N/4NqoNdbcvlR1g488ytFWA8RHhzgsy4ZMFRVMKJ+OF0RkdAaYH6U5A0akV/t5 UvxnOCZFDBq+CkI0hx6w6vT7zdCTSk3ofvRuySEBte8BZLzVJjaoYY2PlYAySNvGiOfezlGpR9PQw c8eAJKfb+LLRQS2esGd1QJXIL+CEyyOMo2MwWts6BhDsQr0TYwUCgk/zlxuDdnMWBxy9o0J1WHh6C 3OTZJ9bolWOWrUPk0qzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qeTLC-00D3ym-0b; Fri, 08 Sep 2023 04:43:34 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qeTL8-00D3vG-2X for kexec@lists.infradead.org; Fri, 08 Sep 2023 04:43:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694148210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+R5PA6kHMvayYFOXlFnPP0p5Z3WLnMw7fxi33dBoYEA=; b=KUJv0YnWcxwo/02jkQXhVUVJryA1mnZT2oD6VyEC7pPQm2IUAmFA0/25KkXwmDlczU1ojV mhnBfZEi49kDy+sARYqnXXBPfHRiBHPRSj644T4Lsv1uKYlqM8JhHP22vwuf1T3nmv/YCe sq6QfEe0s1D6nBLs/aaLmxUBC8DQ82I= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-637-88i7pYxnNHelyDpBFWo-ug-1; Fri, 08 Sep 2023 00:43:23 -0400 X-MC-Unique: 88i7pYxnNHelyDpBFWo-ug-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C85CA101CA85; Fri, 8 Sep 2023 04:43:22 +0000 (UTC) Received: from localhost (unknown [10.72.112.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD7DF404119; Fri, 8 Sep 2023 04:43:21 +0000 (UTC) Date: Fri, 8 Sep 2023 12:43:18 +0800 From: Baoquan He To: HAGIO =?utf-8?B?S0FaVUhJVE8o6JCp5bC+44CA5LiA5LuBKQ==?= Cc: Uladzislau Rezki , "lijiang@redhat.com" , "linux-mm@kvack.org" , Andrew Morton , LKML , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko , "kexec@lists.infradead.org" Subject: Re: [PATCH v2 4/9] mm: vmalloc: Remove global vmap_area_root rb-tree Message-ID: References: <20230829081142.3619-1-urezki@gmail.com> <20230829081142.3619-5-urezki@gmail.com> <8939ea67-ca27-1aa5-dfff-37d78ad59bb8@nec.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8939ea67-ca27-1aa5-dfff-37d78ad59bb8@nec.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230907_214330_894573_876D0FF1 X-CRM114-Status: GOOD ( 38.77 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org T24gMDkvMDgvMjMgYXQgMDE6NTFhbSwgSEFHSU8gS0FaVUhJVE8o6JCp5bC+IOS4gOS7gSkgd3Jv dGU6Cj4gT24gMjAyMy8wOS8wNyAxODo1OCwgQmFvcXVhbiBIZSB3cm90ZToKPiA+IE9uIDA5LzA3 LzIzIGF0IDExOjM5YW0sIFVsYWR6aXNsYXUgUmV6a2kgd3JvdGU6Cj4gPj4gT24gVGh1LCBTZXAg MDcsIDIwMjMgYXQgMTA6MTc6MzlBTSArMDgwMCwgQmFvcXVhbiBIZSB3cm90ZToKPiA+Pj4gQWRk IEthenUgYW5kIExpYW5ibyB0byBDQywgYW5kIGtleGVjIG1haWxpbmcgbGlzdAo+ID4+Pgo+ID4+ PiBPbiAwOC8yOS8yMyBhdCAxMDoxMWFtLCBVbGFkemlzbGF1IFJlemtpIChTb255KSB3cm90ZToK PiA+Pj4+IFN0b3JlIGFsbG9jYXRlZCBvYmplY3RzIGluIGEgc2VwYXJhdGUgbm9kZXMuIEEgdmEt PnZhX3N0YXJ0Cj4gPj4+PiBhZGRyZXNzIGlzIGNvbnZlcnRlZCBpbnRvIGEgY29ycmVjdCBub2Rl IHdoZXJlIGl0IHNob3VsZAo+ID4+Pj4gYmUgcGxhY2VkIGFuZCByZXNpZGVkLiBBbiBhZGRyX3Rv X25vZGUoKSBmdW5jdGlvbiBpcyB1c2VkCj4gPj4+PiB0byBkbyBhIHByb3BlciBhZGRyZXNzIGNv bnZlcnNpb24gdG8gZGV0ZXJtaW5lIGEgbm9kZSB0aGF0Cj4gPj4+PiBjb250YWlucyBhIFZBLgo+ ID4+Pj4KPiA+Pj4+IFN1Y2ggYXBwcm9hY2ggYmFsYW5jZXMgVkFzIGFjcm9zcyBub2RlcyBhcyBh IHJlc3VsdCBhbiBhY2Nlc3MKPiA+Pj4+IGJlY29tZXMgc2NhbGFibGUuIE51bWJlciBvZiBub2Rl cyBpbiBhIHN5c3RlbSBkZXBlbmRzIG9uIG51bWJlcgo+ID4+Pj4gb2YgQ1BVcyBkaXZpZGVkIGJ5 IHR3by4gVGhlIGRlbnNpdHkgZmFjdG9yIGluIHRoaXMgY2FzZSBpcyAxLzIuCj4gPj4+Pgo+ID4+ Pj4gUGxlYXNlIG5vdGU6Cj4gPj4+Pgo+ID4+Pj4gMS4gQXMgb2Ygbm93IGFsbG9jYXRlZCBWQXMg YXJlIGJvdW5kIHRvIGEgbm9kZS0wLiBJdCBtZWFucyB0aGUKPiA+Pj4+ICAgICBwYXRjaCBkb2Vz IG5vdCBnaXZlIGFueSBkaWZmZXJlbmNlIGNvbXBhcmluZyB3aXRoIGEgY3VycmVudAo+ID4+Pj4g ICAgIGJlaGF2aW9yOwo+ID4+Pj4KPiA+Pj4+IDIuIFRoZSBnbG9iYWwgdm1hcF9hcmVhX2xvY2ss IHZtYXBfYXJlYV9yb290IGFyZSByZW1vdmVkIGFzIHRoZXJlCj4gPj4+PiAgICAgaXMgbm8gbmVl ZCBpbiBpdCBhbnltb3JlLiBUaGUgdm1hcF9hcmVhX2xpc3QgaXMgc3RpbGwga2VwdCBhbmQKPiA+ Pj4+ICAgICBpcyBfZW1wdHlfLiBJdCBpcyBleHBvcnRlZCBmb3IgYSBrZXhlYyBvbmx5Owo+ID4+ Pgo+ID4+PiBJIGhhdmVuJ3QgdGFrZW4gYSB0ZXN0LCB3aGlsZSBhY2Nlc3NpbmcgYWxsIG5vZGVz JyBidXN5IHRyZWUgdG8gZ2V0Cj4gPj4+IHZhIG9mIHRoZSBsb3dlc3QgYWRkcmVzcyBjb3VsZCBz ZXZlcmVseSBpbXBhY3Qga2NvcmUgcmVhZGluZyBlZmZpY2llbmN5Cj4gPj4+IG9uIHN5c3RlbSB3 aXRoIG1hbnkgdm1hcCBub2Rlcy4gUGVvcGxlIGRvaW5nIGxpdmUgZGVidWdnaW5nIHZpYQo+ID4+ PiAvcHJvYy9rY29yZSB3aWxsIGdldCBhIGxpdHRsZSBzdXJwcmlzZS4KPiA+Pj4KPiA+Pj4KPiA+ Pj4gRW1wdHkgdm1hcF9hcmVhX2xpc3Qgd2lsbCBicmVhayBtYWtlZHVtcGZpbGUgdXRpbGl0eSwg Q3Jhc2ggdXRpbGl0eQo+ID4+PiBjb3VsZCBiZSBpbXBhY3RkIHRvby4gSSBjaGVja2VkIG1ha2Vk dW1wZmlsZSBjb2RlLCBpdCByZWx5cyBvbgo+ID4+PiB2bWFwX2FyZWFfbGlzdCB0byBkZWR1Y2Ug dGhlIHZtYWxsb2Nfc3RhcnQgdmFsdWUuCj4gPj4+Cj4gPj4gSXQgaXMgbGVmdCBwYXJ0IGFuZCBp IGhvcGUgaSBmaXggaXQgaW4gdjMuIFRoZSBwcm9ibGVtIGhlcmUgaXMKPiA+PiB3ZSBjYW4gbm90 IGdpdmUgYW4gb3Bwb3J0dW5pdHkgdG8gYWNjZXNzIHRvIHZtYXAgaW50ZXJuYWxzIGZyb20KPiA+ PiBvdXRzaWRlLiBUaGlzIGlzIGp1c3Qgbm90IGNvcnJlY3QsIGkuZS4geW91IGFyZSBub3QgYWxs b3dlZCB0bwo+ID4+IGFjY2VzcyB0aGUgbGlzdCBkaXJlY3RseS4KPiA+IAo+ID4gUmlnaHQuIFRo YW5rcyBmb3IgdGhlIGZpeCBpbiB2MywgdGhhdCBpcyBhIHJlbGllZiBvZiBtYWtlZHVtcGZpbGUg YW5kCj4gPiBjcmFzaC4KPiA+IAo+ID4gSGkgS2F6dSwKPiA+IAo+ID4gTWVhbndoaWxlLCBJIGFt IHRoaW5raW5nIGlmIHdlIHNob3VsZCBldmFsdWF0ZSB0aGUgbmVjZXNzaXR5IG9mCj4gPiB2bWFw X2FyZWFfbGlzdCBpbiBtYWtlZHVtcGZpbGUgYW5kIENyYXNoLiBJbiBtYWtlZHVtcGZpbGUsIHdl IGp1c3QgdXNlCj4gPiB2bWFwX2FyZWFfbGlzdCB0byBkZWR1Y2UgVk1BTExPQ19TVEFSVC4gV29u ZGVyaW5nIGlmIHdlIGNhbiBleHBvcnQKPiA+IFZNQUxMT0NfU1RBUlQgZGlyZWN0bHkuIFN1cmVs eSwgdGhlIGxvd2VzdCB2YS0+dmFfc3RhcnQgaW4gdm1hcF9hcmVhX2xpc3QKPiA+IGlzIGEgdGln aHRlciBsb3cgYm91bmRhcnkgb2Ygdm1hbGxvYyBhcmVhIGFuZCBjYW4gcmVkdWNlIHVubmVjZXNz YXJ5Cj4gPiBzY2FubmluZyBiZWxvdyB0aGUgbG93ZXN0IHZhLiBOb3Qgc3VyZSBpZiB0aGlzIGlz IHRoZSByZWFzb24gcGVvcGxlCj4gPiBkZWNpZGVkIHRvIGV4cG9ydCB2bWFwX2FyZWFfbGlzdC4K PiAKPiBUaGUga2VybmVsIGNvbW1pdCBhY2Q5OWRiZjU0MDIgaW50cm9kdWNlZCB0aGUgb3JpZ2lu YWwgdm1saXN0IGVudHJ5IHRvIAo+IHZtY29yZWluZm8sIGJ1dCB0aGVyZSBpcyBubyBpbmZvcm1h dGlvbiBhYm91dCB3aHkgaXQgZGlkIG5vdCBleHBvcnQgCj4gVk1BTExPQ19TVEFSVCBkaXJlY3Rs eS4KPiAKPiBJZiBWTUFMTE9DX1NUQVJUIGlzIGV4cG9ydGVkIGRpcmVjdGx5IHRvIHZtY29yZWlu Zm8sIEkgdGhpbmsgaXQgd291bGQgYmUgCj4gZW5vdWdoIGZvciBtYWtlZHVtcGZpbGUuCgpUaGFu a3MgZm9yIGNvbmZpcm1hdGlvbiwgS2F6dS4KClRoZW4sIGJlbG93IGRyYWZ0IHBhdGNoIHNob3Vs ZCBiZSBlbm91Z2ggdG8gZXhwb3J0IFZNQUxMT0NfU1RBUlQKaW5zdGVhZCwgYW5kIHJlbW92ZSB2 bWFwX2FyZWFfbGlzdC4gSW4gb3JkZXIgdG8gZ2V0IHRoZSBiYXNlIGFkZHJlc3Mgb2YKdm1hbGxv YyBhcmVhLCBjb25zdHJ1Y3RpbmcgYSB2bWFwX2FyZWFfbGlzdCBmcm9tIG11bHRpcGxlIGJ1c3kt dHJlZQpzZWVtcyBub3Qgd29ydGguCgpkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9hZG1pbi1n dWlkZS9rZHVtcC92bWNvcmVpbmZvLnJzdCBiL0RvY3VtZW50YXRpb24vYWRtaW4tZ3VpZGUva2R1 bXAvdm1jb3JlaW5mby5yc3QKaW5kZXggNTk5ZThkM2JjYmMzLi4zY2IxZWEwOWZmMjYgMTAwNjQ0 Ci0tLSBhL0RvY3VtZW50YXRpb24vYWRtaW4tZ3VpZGUva2R1bXAvdm1jb3JlaW5mby5yc3QKKysr IGIvRG9jdW1lbnRhdGlvbi9hZG1pbi1ndWlkZS9rZHVtcC92bWNvcmVpbmZvLnJzdApAQCAtNjUs MTEgKzY1LDExIEBAIERlZmluZXMgdGhlIGJlZ2lubmluZyBvZiB0aGUgdGV4dCBzZWN0aW9uLiBJ biBnZW5lcmFsLCBfc3RleHQgaW5kaWNhdGVzCiB0aGUga2VybmVsIHN0YXJ0IGFkZHJlc3MuIFVz ZWQgdG8gY29udmVydCBhIHZpcnR1YWwgYWRkcmVzcyBmcm9tIHRoZQogZGlyZWN0IGtlcm5lbCBt YXAgdG8gYSBwaHlzaWNhbCBhZGRyZXNzLgogCi12bWFwX2FyZWFfbGlzdAotLS0tLS0tLS0tLS0t LS0KK1ZNQUxMT0NfU1RBUlQKKy0tLS0tLS0tLS0tLS0KIAotU3RvcmVzIHRoZSB2aXJ0dWFsIGFy ZWEgbGlzdC4gbWFrZWR1bXBmaWxlIGdldHMgdGhlIHZtYWxsb2Mgc3RhcnQgdmFsdWUKLWZyb20g dGhpcyB2YXJpYWJsZSBhbmQgaXRzIHZhbHVlIGlzIG5lY2Vzc2FyeSBmb3Igdm1hbGxvYyB0cmFu c2xhdGlvbi4KK1N0b3JlcyB0aGUgYmFzZSBhZGRyZXNzIG9mIHZtYWxsb2MgYXJlYS4gbWFrZWR1 bXBmaWxlIGdldHMgdGhpcyB2YWx1ZSBhbmQKK2l0cyB2YWx1ZSBpcyBuZWNlc3NhcnkgZm9yIHZt YWxsb2MgdHJhbnNsYXRpb24uCiAKIG1lbV9tYXAKIC0tLS0tLS0KZGlmZiAtLWdpdCBhL2FyY2gv YXJtNjQva2VybmVsL2NyYXNoX2NvcmUuYyBiL2FyY2gvYXJtNjQva2VybmVsL2NyYXNoX2NvcmUu YwppbmRleCA2NmNkZTc1MmNkNzQuLjJhMjQxOTlhOWI4MSAxMDA2NDQKLS0tIGEvYXJjaC9hcm02 NC9rZXJuZWwvY3Jhc2hfY29yZS5jCisrKyBiL2FyY2gvYXJtNjQva2VybmVsL2NyYXNoX2NvcmUu YwpAQCAtMjMsNyArMjMsNiBAQCB2b2lkIGFyY2hfY3Jhc2hfc2F2ZV92bWNvcmVpbmZvKHZvaWQp CiAJLyogUGxlYXNlIG5vdGUgVk1DT1JFSU5GT19OVU1CRVIoKSB1c2VzICIlZCIsIG5vdCAiJXgi ICovCiAJdm1jb3JlaW5mb19hcHBlbmRfc3RyKCJOVU1CRVIoTU9EVUxFU19WQUREUik9MHglbHhc biIsIE1PRFVMRVNfVkFERFIpOwogCXZtY29yZWluZm9fYXBwZW5kX3N0cigiTlVNQkVSKE1PRFVM RVNfRU5EKT0weCVseFxuIiwgTU9EVUxFU19FTkQpOwotCXZtY29yZWluZm9fYXBwZW5kX3N0cigi TlVNQkVSKFZNQUxMT0NfU1RBUlQpPTB4JWx4XG4iLCBWTUFMTE9DX1NUQVJUKTsKIAl2bWNvcmVp bmZvX2FwcGVuZF9zdHIoIk5VTUJFUihWTUFMTE9DX0VORCk9MHglbHhcbiIsIFZNQUxMT0NfRU5E KTsKIAl2bWNvcmVpbmZvX2FwcGVuZF9zdHIoIk5VTUJFUihWTUVNTUFQX1NUQVJUKT0weCVseFxu IiwgVk1FTU1BUF9TVEFSVCk7CiAJdm1jb3JlaW5mb19hcHBlbmRfc3RyKCJOVU1CRVIoVk1FTU1B UF9FTkQpPTB4JWx4XG4iLCBWTUVNTUFQX0VORCk7CmRpZmYgLS1naXQgYS9hcmNoL3Jpc2N2L2tl cm5lbC9jcmFzaF9jb3JlLmMgYi9hcmNoL3Jpc2N2L2tlcm5lbC9jcmFzaF9jb3JlLmMKaW5kZXgg NTVmMWQ3ODU2YjU0Li41YzM5Y2VkZDJjNWMgMTAwNjQ0Ci0tLSBhL2FyY2gvcmlzY3Yva2VybmVs L2NyYXNoX2NvcmUuYworKysgYi9hcmNoL3Jpc2N2L2tlcm5lbC9jcmFzaF9jb3JlLmMKQEAgLTks NyArOSw2IEBAIHZvaWQgYXJjaF9jcmFzaF9zYXZlX3ZtY29yZWluZm8odm9pZCkKIAlWTUNPUkVJ TkZPX05VTUJFUihwaHlzX3JhbV9iYXNlKTsKIAogCXZtY29yZWluZm9fYXBwZW5kX3N0cigiTlVN QkVSKFBBR0VfT0ZGU0VUKT0weCVseFxuIiwgUEFHRV9PRkZTRVQpOwotCXZtY29yZWluZm9fYXBw ZW5kX3N0cigiTlVNQkVSKFZNQUxMT0NfU1RBUlQpPTB4JWx4XG4iLCBWTUFMTE9DX1NUQVJUKTsK IAl2bWNvcmVpbmZvX2FwcGVuZF9zdHIoIk5VTUJFUihWTUFMTE9DX0VORCk9MHglbHhcbiIsIFZN QUxMT0NfRU5EKTsKIAl2bWNvcmVpbmZvX2FwcGVuZF9zdHIoIk5VTUJFUihWTUVNTUFQX1NUQVJU KT0weCVseFxuIiwgVk1FTU1BUF9TVEFSVCk7CiAJdm1jb3JlaW5mb19hcHBlbmRfc3RyKCJOVU1C RVIoVk1FTU1BUF9FTkQpPTB4JWx4XG4iLCBWTUVNTUFQX0VORCk7CmRpZmYgLS1naXQgYS9pbmNs dWRlL2xpbnV4L3ZtYWxsb2MuaCBiL2luY2x1ZGUvbGludXgvdm1hbGxvYy5oCmluZGV4IGM3MjBi ZTcwYzhkZC4uOTE4MTBiNGU5NTEwIDEwMDY0NAotLS0gYS9pbmNsdWRlL2xpbnV4L3ZtYWxsb2Mu aAorKysgYi9pbmNsdWRlL2xpbnV4L3ZtYWxsb2MuaApAQCAtMjUzLDcgKzI1Myw2IEBAIGV4dGVy biBsb25nIHZyZWFkX2l0ZXIoc3RydWN0IGlvdl9pdGVyICppdGVyLCBjb25zdCBjaGFyICphZGRy LCBzaXplX3QgY291bnQpOwogLyoKICAqCUludGVybmFscy4gIERvbid0IHVzZS4uCiAgKi8KLWV4 dGVybiBzdHJ1Y3QgbGlzdF9oZWFkIHZtYXBfYXJlYV9saXN0OwogZXh0ZXJuIF9faW5pdCB2b2lk IHZtX2FyZWFfYWRkX2Vhcmx5KHN0cnVjdCB2bV9zdHJ1Y3QgKnZtKTsKIGV4dGVybiBfX2luaXQg dm9pZCB2bV9hcmVhX3JlZ2lzdGVyX2Vhcmx5KHN0cnVjdCB2bV9zdHJ1Y3QgKnZtLCBzaXplX3Qg YWxpZ24pOwogCmRpZmYgLS1naXQgYS9rZXJuZWwvY3Jhc2hfY29yZS5jIGIva2VybmVsL2NyYXNo X2NvcmUuYwppbmRleCAwM2E3OTMyY2RlMGEuLjkxYWY4NzkzMDc3MCAxMDA2NDQKLS0tIGEva2Vy bmVsL2NyYXNoX2NvcmUuYworKysgYi9rZXJuZWwvY3Jhc2hfY29yZS5jCkBAIC02MTcsNyArNjE3 LDcgQEAgc3RhdGljIGludCBfX2luaXQgY3Jhc2hfc2F2ZV92bWNvcmVpbmZvX2luaXQodm9pZCkK IAlWTUNPUkVJTkZPX1NZTUJPTF9BUlJBWShzd2FwcGVyX3BnX2Rpcik7CiAjZW5kaWYKIAlWTUNP UkVJTkZPX1NZTUJPTChfc3RleHQpOwotCVZNQ09SRUlORk9fU1lNQk9MKHZtYXBfYXJlYV9saXN0 KTsKKwl2bWNvcmVpbmZvX2FwcGVuZF9zdHIoIk5VTUJFUihWTUFMTE9DX1NUQVJUKT0weCVseFxu IiwgVk1BTExPQ19TVEFSVCk7CiAKICNpZm5kZWYgQ09ORklHX05VTUEKIAlWTUNPUkVJTkZPX1NZ TUJPTChtZW1fbWFwKTsKZGlmZiAtLWdpdCBhL2tlcm5lbC9rYWxsc3ltc19zZWxmdGVzdC5jIGIv a2VybmVsL2thbGxzeW1zX3NlbGZ0ZXN0LmMKaW5kZXggYjRjYWM3NmVhNWU5Li44YTY4OWI0ZmY0 ZjkgMTAwNjQ0Ci0tLSBhL2tlcm5lbC9rYWxsc3ltc19zZWxmdGVzdC5jCisrKyBiL2tlcm5lbC9r YWxsc3ltc19zZWxmdGVzdC5jCkBAIC04OSw3ICs4OSw2IEBAIHN0YXRpYyBzdHJ1Y3QgdGVzdF9p dGVtIHRlc3RfaXRlbXNbXSA9IHsKIAlJVEVNX0RBVEEoa2FsbHN5bXNfdGVzdF92YXJfZGF0YV9z dGF0aWMpLAogCUlURU1fREFUQShrYWxsc3ltc190ZXN0X3Zhcl9ic3MpLAogCUlURU1fREFUQShr YWxsc3ltc190ZXN0X3Zhcl9kYXRhKSwKLQlJVEVNX0RBVEEodm1hcF9hcmVhX2xpc3QpLAogI2Vu ZGlmCiB9OwogCmRpZmYgLS1naXQgYS9tbS9ub21tdS5jIGIvbW0vbm9tbXUuYwppbmRleCA3Zjll OWU1YTBlMTIuLjhjNjY4NjE3NmViZCAxMDA2NDQKLS0tIGEvbW0vbm9tbXUuYworKysgYi9tbS9u b21tdS5jCkBAIC0xMzEsOCArMTMxLDYgQEAgaW50IGZvbGxvd19wZm4oc3RydWN0IHZtX2FyZWFf c3RydWN0ICp2bWEsIHVuc2lnbmVkIGxvbmcgYWRkcmVzcywKIH0KIEVYUE9SVF9TWU1CT0woZm9s bG93X3Bmbik7CiAKLUxJU1RfSEVBRCh2bWFwX2FyZWFfbGlzdCk7Ci0KIHZvaWQgdmZyZWUoY29u c3Qgdm9pZCAqYWRkcikKIHsKIAlrZnJlZShhZGRyKTsKZGlmZiAtLWdpdCBhL21tL3ZtYWxsb2Mu YyBiL21tL3ZtYWxsb2MuYwppbmRleCA1MGQ4MjM5YjgyZGYuLjBhMDI2MzNhOTU2NiAxMDA2NDQK LS0tIGEvbW0vdm1hbGxvYy5jCisrKyBiL21tL3ZtYWxsb2MuYwpAQCAtNzI5LDggKzcyOSw3IEBA IEVYUE9SVF9TWU1CT0wodm1hbGxvY190b19wZm4pOwogCiAKIHN0YXRpYyBERUZJTkVfU1BJTkxP Q0soZnJlZV92bWFwX2FyZWFfbG9jayk7Ci0vKiBFeHBvcnQgZm9yIGtleGVjIG9ubHkgKi8KLUxJ U1RfSEVBRCh2bWFwX2FyZWFfbGlzdCk7CisKIHN0YXRpYyBib29sIHZtYXBfaW5pdGlhbGl6ZWQg X19yZWFkX21vc3RseTsKIAogLyoKLS0gCjIuNDEuMAoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmtleGVjIG1haWxpbmcgbGlzdAprZXhlY0BsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v a2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0ACAEE57C2 for ; Fri, 8 Sep 2023 04:43:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FECC6B0099; Fri, 8 Sep 2023 00:43:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AFD66B009A; Fri, 8 Sep 2023 00:43:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 134276B009B; Fri, 8 Sep 2023 00:43:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F27826B0099 for ; Fri, 8 Sep 2023 00:43:34 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C6998801EF for ; Fri, 8 Sep 2023 04:43:34 +0000 (UTC) X-FDA: 81212186748.03.C54FEDD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id EE99140019 for ; Fri, 8 Sep 2023 04:43:32 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fwiEtP1h; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694148213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+R5PA6kHMvayYFOXlFnPP0p5Z3WLnMw7fxi33dBoYEA=; b=DR47W4AL0HBE0WWfG6/J1ui7XgfhGcG4aacn21OVVFhkDH5s/JULmuZPLRCq2hnWfnTrEa Z2bv+yPruqFqVH4XdOlmzIrRP1zaxviO/bJQlawq8KDnWJgcDDbk56ynVXG++TWDtw33wd G3nbEZ6F6Y/fHuA8aJcGFaG+dTElRjE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fwiEtP1h; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694148213; a=rsa-sha256; cv=none; b=IKtl0ZPdVKKfxuSL65nhQkjcsNqtEi09v1mdrkun54T+u3zlwt3aiedn3y7nu88f1ELqDu Aw+adqMDmB8EtJGo/gLBevALvtemZmnVmc2hxETNpaX9AiLIi3OH5uxYseJphAWGgQPRcX AleNoXmkr1+JxVdk6xbX4ISQfrRt03I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694148212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+R5PA6kHMvayYFOXlFnPP0p5Z3WLnMw7fxi33dBoYEA=; b=fwiEtP1h+555LYm9ep/mpU5mOEMSqMDstmapD2U3otFkK+AWxB8Zhy8bJs19rs89lnR95w 9Xp6LH8QX192HqNh7svbZ5g3MaC4VOroy0ZcIk7CFtRumgeExZgXQ8qL0Jhar+GPUj9DyM ldRebJmgCTw3CaKcO3CwnS/h9Qi/pao= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-637-88i7pYxnNHelyDpBFWo-ug-1; Fri, 08 Sep 2023 00:43:23 -0400 X-MC-Unique: 88i7pYxnNHelyDpBFWo-ug-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C85CA101CA85; Fri, 8 Sep 2023 04:43:22 +0000 (UTC) Received: from localhost (unknown [10.72.112.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD7DF404119; Fri, 8 Sep 2023 04:43:21 +0000 (UTC) Date: Fri, 8 Sep 2023 12:43:18 +0800 From: Baoquan He To: HAGIO =?utf-8?B?S0FaVUhJVE8o6JCp5bC+44CA5LiA5LuBKQ==?= Cc: Uladzislau Rezki , "lijiang@redhat.com" , "linux-mm@kvack.org" , Andrew Morton , LKML , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko , "kexec@lists.infradead.org" Subject: Re: [PATCH v2 4/9] mm: vmalloc: Remove global vmap_area_root rb-tree Message-ID: References: <20230829081142.3619-1-urezki@gmail.com> <20230829081142.3619-5-urezki@gmail.com> <8939ea67-ca27-1aa5-dfff-37d78ad59bb8@nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8939ea67-ca27-1aa5-dfff-37d78ad59bb8@nec.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspamd-Queue-Id: EE99140019 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 5tmiyetatehn36pi94tm3geofs6r6iz9 X-HE-Tag: 1694148212-318895 X-HE-Meta: U2FsdGVkX1+zADYdumzt2Dr5EXWICd6iQmMD80457DagHlmpv/+WDuNiybRzp10cPkRiyYMrq5rp6k5fE3Rp9AZs47fA4tj7yubkIJt6vTfELPkQil3CU4j4WojH70s2NbuL+6/hURasWiB2/kQvweyruLPssc3M9zLTbe8VoELXFbHWXke2Y+XDXPTMVAyXmieXp5o/yGAluuA6dqk3ZUBMbunWmdGeLLEMzCPHcIOAkQJ6bKTOw6ipf7i7+9WH75od+wDEzBMBRg+piK9DKomz+unHLACQvtrP/tJ12SDg07YNpC+rWI7aFvoQNFPpV2LwbfemrLfL/VmSZkXo9pglZTFZI11kcbZ/Pq1jvatKezJBBeeDgr5w5zD2ilMdH+2qyV5h8WOSoWxgXWJHrdblz7UrX/mwBRe7OZkLhbS2S3eSrzDvdK4kkMF0yZWelSDzqgnoc7SvvGH6oowbsUANeKPHKxIjdHWv09IgOWDkEDyXwrFMfgVC9oRu24fCDIGn8cVXlQPvjhz5omeSkpDqGIu0iwX6fHG2FDMuC0JL5sUDxuVRkE2ccHaeFDdTnGDLnosHE/Rp5vZNQN4AxJJwDXqXAAcg853ITql/IYfAS0SIWrG8Z/m7C7EMQ0V8y3cog2rB3IAsNWPLvk0UWn5qrv0XEzTW/cnLZhBJfYnNfTK3mKrncRFO+jbcZzn6b7omrFOmKTXSgpXD7edrKVXhzuNzALoSApYqRDJMZodXbkN5fCoPMxBsnl6IXwFbeJ8xm7O3UghLkGfYGuP1DDOB9x9te7+VpOrvNpP1Y5BbSc3to1/Kw56Zz8YMGrJsvKztqm/ZvcApfrlf8QzJaf+gsB+rvL8YGDLQ/q4kFDC0htnOQHWUfz2quB1vi4yWHzisD1Os09gQzjZCNTEkPdOL9xItT5OOp8DQusTM+6GvH5rhNbXEQIxI22Mh8ztMA2se78p7TROG9m5MWWz uSAedNm2 22XPMM3RzAHeTOid1i8YE0WuV/PjPXzHgTy99izCSgUq6BUaO89b+0FKe8g6IBrIDKkrjVR1U8EaSBWMKvQhMq47sV/m7bfmXAnkZ/ydM8++Iw6n8e0E1h+N7HOpZHDC0VqPDHFV5ljxDP1S8aN3UsRikK93nxL0nKJdLB1obT39BH9NVSGqBUAIEfI36W+Ac5vWzlOy8uIOCm4MxLHtjezbeh+Nze+uYLeEPOhyWSKKfQriBY6OS9gDEqk2XqnDpqTs13Pggva+k2TXOJxqFBSvhasrOUsugNYJH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09/08/23 at 01:51am, HAGIO KAZUHITO(萩尾 一仁) wrote: > On 2023/09/07 18:58, Baoquan He wrote: > > On 09/07/23 at 11:39am, Uladzislau Rezki wrote: > >> On Thu, Sep 07, 2023 at 10:17:39AM +0800, Baoquan He wrote: > >>> Add Kazu and Lianbo to CC, and kexec mailing list > >>> > >>> On 08/29/23 at 10:11am, Uladzislau Rezki (Sony) wrote: > >>>> Store allocated objects in a separate nodes. A va->va_start > >>>> address is converted into a correct node where it should > >>>> be placed and resided. An addr_to_node() function is used > >>>> to do a proper address conversion to determine a node that > >>>> contains a VA. > >>>> > >>>> Such approach balances VAs across nodes as a result an access > >>>> becomes scalable. Number of nodes in a system depends on number > >>>> of CPUs divided by two. The density factor in this case is 1/2. > >>>> > >>>> Please note: > >>>> > >>>> 1. As of now allocated VAs are bound to a node-0. It means the > >>>> patch does not give any difference comparing with a current > >>>> behavior; > >>>> > >>>> 2. The global vmap_area_lock, vmap_area_root are removed as there > >>>> is no need in it anymore. The vmap_area_list is still kept and > >>>> is _empty_. It is exported for a kexec only; > >>> > >>> I haven't taken a test, while accessing all nodes' busy tree to get > >>> va of the lowest address could severely impact kcore reading efficiency > >>> on system with many vmap nodes. People doing live debugging via > >>> /proc/kcore will get a little surprise. > >>> > >>> > >>> Empty vmap_area_list will break makedumpfile utility, Crash utility > >>> could be impactd too. I checked makedumpfile code, it relys on > >>> vmap_area_list to deduce the vmalloc_start value. > >>> > >> It is left part and i hope i fix it in v3. The problem here is > >> we can not give an opportunity to access to vmap internals from > >> outside. This is just not correct, i.e. you are not allowed to > >> access the list directly. > > > > Right. Thanks for the fix in v3, that is a relief of makedumpfile and > > crash. > > > > Hi Kazu, > > > > Meanwhile, I am thinking if we should evaluate the necessity of > > vmap_area_list in makedumpfile and Crash. In makedumpfile, we just use > > vmap_area_list to deduce VMALLOC_START. Wondering if we can export > > VMALLOC_START directly. Surely, the lowest va->va_start in vmap_area_list > > is a tighter low boundary of vmalloc area and can reduce unnecessary > > scanning below the lowest va. Not sure if this is the reason people > > decided to export vmap_area_list. > > The kernel commit acd99dbf5402 introduced the original vmlist entry to > vmcoreinfo, but there is no information about why it did not export > VMALLOC_START directly. > > If VMALLOC_START is exported directly to vmcoreinfo, I think it would be > enough for makedumpfile. Thanks for confirmation, Kazu. Then, below draft patch should be enough to export VMALLOC_START instead, and remove vmap_area_list. In order to get the base address of vmalloc area, constructing a vmap_area_list from multiple busy-tree seems not worth. diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst index 599e8d3bcbc3..3cb1ea09ff26 100644 --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst @@ -65,11 +65,11 @@ Defines the beginning of the text section. In general, _stext indicates the kernel start address. Used to convert a virtual address from the direct kernel map to a physical address. -vmap_area_list --------------- +VMALLOC_START +------------- -Stores the virtual area list. makedumpfile gets the vmalloc start value -from this variable and its value is necessary for vmalloc translation. +Stores the base address of vmalloc area. makedumpfile gets this value and +its value is necessary for vmalloc translation. mem_map ------- diff --git a/arch/arm64/kernel/crash_core.c b/arch/arm64/kernel/crash_core.c index 66cde752cd74..2a24199a9b81 100644 --- a/arch/arm64/kernel/crash_core.c +++ b/arch/arm64/kernel/crash_core.c @@ -23,7 +23,6 @@ void arch_crash_save_vmcoreinfo(void) /* Please note VMCOREINFO_NUMBER() uses "%d", not "%x" */ vmcoreinfo_append_str("NUMBER(MODULES_VADDR)=0x%lx\n", MODULES_VADDR); vmcoreinfo_append_str("NUMBER(MODULES_END)=0x%lx\n", MODULES_END); - vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START); vmcoreinfo_append_str("NUMBER(VMALLOC_END)=0x%lx\n", VMALLOC_END); vmcoreinfo_append_str("NUMBER(VMEMMAP_START)=0x%lx\n", VMEMMAP_START); vmcoreinfo_append_str("NUMBER(VMEMMAP_END)=0x%lx\n", VMEMMAP_END); diff --git a/arch/riscv/kernel/crash_core.c b/arch/riscv/kernel/crash_core.c index 55f1d7856b54..5c39cedd2c5c 100644 --- a/arch/riscv/kernel/crash_core.c +++ b/arch/riscv/kernel/crash_core.c @@ -9,7 +9,6 @@ void arch_crash_save_vmcoreinfo(void) VMCOREINFO_NUMBER(phys_ram_base); vmcoreinfo_append_str("NUMBER(PAGE_OFFSET)=0x%lx\n", PAGE_OFFSET); - vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START); vmcoreinfo_append_str("NUMBER(VMALLOC_END)=0x%lx\n", VMALLOC_END); vmcoreinfo_append_str("NUMBER(VMEMMAP_START)=0x%lx\n", VMEMMAP_START); vmcoreinfo_append_str("NUMBER(VMEMMAP_END)=0x%lx\n", VMEMMAP_END); diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h index c720be70c8dd..91810b4e9510 100644 --- a/include/linux/vmalloc.h +++ b/include/linux/vmalloc.h @@ -253,7 +253,6 @@ extern long vread_iter(struct iov_iter *iter, const char *addr, size_t count); /* * Internals. Don't use.. */ -extern struct list_head vmap_area_list; extern __init void vm_area_add_early(struct vm_struct *vm); extern __init void vm_area_register_early(struct vm_struct *vm, size_t align); diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 03a7932cde0a..91af87930770 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -617,7 +617,7 @@ static int __init crash_save_vmcoreinfo_init(void) VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir); #endif VMCOREINFO_SYMBOL(_stext); - VMCOREINFO_SYMBOL(vmap_area_list); + vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START); #ifndef CONFIG_NUMA VMCOREINFO_SYMBOL(mem_map); diff --git a/kernel/kallsyms_selftest.c b/kernel/kallsyms_selftest.c index b4cac76ea5e9..8a689b4ff4f9 100644 --- a/kernel/kallsyms_selftest.c +++ b/kernel/kallsyms_selftest.c @@ -89,7 +89,6 @@ static struct test_item test_items[] = { ITEM_DATA(kallsyms_test_var_data_static), ITEM_DATA(kallsyms_test_var_bss), ITEM_DATA(kallsyms_test_var_data), - ITEM_DATA(vmap_area_list), #endif }; diff --git a/mm/nommu.c b/mm/nommu.c index 7f9e9e5a0e12..8c6686176ebd 100644 --- a/mm/nommu.c +++ b/mm/nommu.c @@ -131,8 +131,6 @@ int follow_pfn(struct vm_area_struct *vma, unsigned long address, } EXPORT_SYMBOL(follow_pfn); -LIST_HEAD(vmap_area_list); - void vfree(const void *addr) { kfree(addr); diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 50d8239b82df..0a02633a9566 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -729,8 +729,7 @@ EXPORT_SYMBOL(vmalloc_to_pfn); static DEFINE_SPINLOCK(free_vmap_area_lock); -/* Export for kexec only */ -LIST_HEAD(vmap_area_list); + static bool vmap_initialized __read_mostly; /* -- 2.41.0