From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, helei.sig11@bytedance.com,
pizhenwei@bytedance.com
Subject: Re: [PATCH] crypto/rsakey-builtin.c.inc: Clean up two error paths
Date: Fri, 8 Sep 2023 11:07:57 +0100 [thread overview]
Message-ID: <ZPryfYeMINy4hdCE@redhat.com> (raw)
In-Reply-To: <20230901123226.3656164-1-armbru@redhat.com>
On Fri, Sep 01, 2023 at 02:32:26PM +0200, Markus Armbruster wrote:
> When qcrypto_builtin_rsa_public_key_parse() is about to fail, but no
> error has been set, it makes one up. Actually, there's just one way
> to fail without setting an error. Set it there instead.
>
> Same for qcrypto_builtin_rsa_private_key_parse().
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> crypto/rsakey-builtin.c.inc | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
and queued.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2023-09-08 10:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 12:32 [PATCH] crypto/rsakey-builtin.c.inc: Clean up two error paths Markus Armbruster
2023-09-08 10:07 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPryfYeMINy4hdCE@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=helei.sig11@bytedance.com \
--cc=pizhenwei@bytedance.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.