From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E9AEEE8000 for ; Fri, 8 Sep 2023 13:51:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xc8fUW3yCrnAYzCCGLfIyZ5JmYYEZE11T8ZMfvC6l8U=; b=ZxxUg1IjrGGc8A 1l2ff9fr6HdooPlQDlaIAPxaqeuDRelGyaTGEZw1I9BA3ezg2UszZzB+S2J3GPBRM5stg9MRkJflf ow5j4OqkG6mv39a20AQ52OhEwNy0JMhK1UWG7hNLeZiK2z+B9Qwoy7ZzsUAhup4/WdJobML+ZfTs+ 4yU5Adp34Y2kGjww/sM23E+1mgSQ27+quKFgM0HZXl1p9UQv4bkSuCdZvXuBgh2OzInh/D+w6sQLF bZ8oqigsFrYw5a8pjKBk/udSTtp3pBdGIAQrKYwQb5ahYzt1AqKoO37pkioMYB+DTTUU2Hm+Sw2G9 GEm1d6A6gbvnyA+PlJqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qebsS-00Ds5Y-2d; Fri, 08 Sep 2023 13:50:28 +0000 Received: from [2001:4d48:ad52:32c8:5054:ff:fe00:142] (helo=pandora.armlinux.org.uk) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qebsO-00Ds4p-1w for linux-arm-kernel@lists.infradead.org; Fri, 08 Sep 2023 13:50:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LbgxR6XC8LYMVBzfsv+O9qJkpfwcf2slpkIZbcLgfOw=; b=amB6TIzYbCI8yf9vGXczOH6gAb Necd/KYkOmHfQ8ShgSY+zaCPtTpDolSDpVYcgB0Cxgc967lR9v0sUO0K1oyH3at2+B8T23Ty2llYU qZalkl5ChML9LfUaG7ZDMjiUJFL7OTq/LrGs0Di+oblw2xGfDKfhCaymtM0ErZyPUcz27rf7oBn1A GM1LrIzFPqsJQWTrrzwvc6IqnrF0pr2ZUJgtLG1fn3wkRvJVaN6Z6p5eBIsICRxIPSrLEdZCUSS0H AMOV0UMv3c7zQY7CFUGDALXmUgOldxAa2fdUsX4UfJOcpU16jTr2s538brGD+AVocsrlL5c6h00bN xrdiy3KA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36590) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qebs9-00050u-2n; Fri, 08 Sep 2023 14:50:09 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qebs1-0006wF-Av; Fri, 08 Sep 2023 14:50:01 +0100 Date: Fri, 8 Sep 2023 14:50:01 +0100 From: "Russell King (Oracle)" To: Linus Walleij Cc: Zhizhou Zhang , rppt@kernel.org, akpm@linux-foundation.org, vishal.moola@gmail.com, arnd@arndb.de, wangkefeng.wang@huawei.com, willy@infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Zhizhou Zhang Subject: Re: [PATCH] ARM: mm: fix stack corruption when CONFIG_ARM_PV_FIXUP=y Message-ID: References: <20230907143302.4940-1-zhizhou.zh@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230908_065024_646096_B5F66105 X-CRM114-Status: GOOD ( 18.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBTZXAgMDgsIDIwMjMgYXQgMDI6NTg6NDlQTSArMDIwMCwgTGludXMgV2FsbGVpaiB3 cm90ZToKPiBIaSBaaGl6aG91LAo+IAo+IHdvdyBhIGdyZWF0IHBhdGNoISBJJ20gc3VycHJpc2Vk IG5vLW9uZSBoYXMgYmVlbiBoaXQgYnkgdGhpcyBiZWZvcmUuCj4gSSBndWVzcyB3ZSB3ZXJlIGx1 Y2t5Lgo+IAo+IE9uIFRodSwgU2VwIDcsIDIwMjMgYXQgNDozM+KAr1BNIFpoaXpob3UgWmhhbmcg PHpoaXpob3UuemhAZ21haWwuY29tPiB3cm90ZToKPiAKPiA+IEZyb206IFpoaXpob3UgWmhhbmcg PHpoaXpob3V6aGFuZ0Bhc3JtaWNyby5jb20+Cj4gPgo+ID4gZmx1c2hfY2FjaGVfYWxsKCkgc2F2 ZSByZWdpc3RlcnMgdG8gc3RhY2sgYXQgZnVuY3Rpb24gZW50cnkuCj4gPiBJZiBpdCdzIGNhbGxl ZCBhZnRlciBjYWNoZSBkaXNhYmxlZCwgdGhlIGRhdGEgaXMgd3JpdHRlbiB0bwo+ID4gbWVtb3J5 IGRpcmVjdGx5LiBTbyB0aGUgZm9sbG93aW5nIGNsZWFuIGNhY2hlIG9wZXJhdGlvbiBjb3JydXB0 ZWQKPiA+IHJlZ2lzdGVycyBzYXZlZCBieSBmbHVzaF9jYWNoZV9hbGwoKSwgaW5jbHVkaW5nIGxy IHJlZ2lzdGVyLgo+ID4gY2FsbGluZyBmbHVzaF9jYWNoZV9hbGwoKSBiZWZvcmUgdHVybiBvZmYg Y2FjaGUgZml4ZWQgdGhlIHByb2JsZW0uCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogWmhpemhvdSBa aGFuZyA8emhpemhvdXpoYW5nQGFzcm1pY3JvLmNvbT4KPiAKPiBSZXZpZXdlZC1ieTogTGludXMg V2FsbGVpaiA8bGludXMud2FsbGVpakBsaW5hcm8ub3JnPgo+IAo+IEkgd291bGQgYWxzbyBhZGQK PiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+IAo+IFRoZW4gcGxlYXNlIHB1dCB0aGlzIGlu dG8gUnVzc2VsbCdzIHBhdGNoIHRyYWNrZXIgb25jZSByZXZpZXcKPiBpcyBjb21wbGV0ZS4KCkhv d2V2ZXIsIGl0IG1ha2VzIGEgdG90YWwgbm9uc2Vuc2Ugb2YgdGhlIGNvbW1lbnQsIHdoaWNoIGV4 cGxhaW5zCnByZWNpc2VseSB3aHkgdGhlIGZsdXNoX2NhY2hlX2FsbCgpIGlzIHdoZXJlIGl0IGlz LiBNb3ZpbmcgaXQgYmVmb3JlCnRoYXQgY29tbWVudCBtZWFucyB0aGF0IHRoZSBjb21tZW50IGlz IG5vdyByZWRpY3Vsb3VzLgoKU28sIHBsZWFzZSBkb24ndCBwdXQgaXQgaW4gdGhlIHBhdGNoIHN5 c3RlbS4KClRoZSBwYXRjaCBjZXJ0YWlubHkgbmVlZHMgdG8gYmUgdGVzdGVkIG9uIFRJIEtleXN0 b25lIHdoaWNoIGlzIHRoZQpwcmltYXJ5IHVzZXIgb2YgdGhpcyBjb2RlLgoKLS0gClJNSydzIFBh dGNoIHN5c3RlbTogaHR0cHM6Ly93d3cuYXJtbGludXgub3JnLnVrL2RldmVsb3Blci9wYXRjaGVz LwpGVFRQIGlzIGhlcmUhIDgwTWJwcyBkb3duIDEwTWJwcyB1cC4gRGVjZW50IGNvbm5lY3Rpdml0 eSBhdCBsYXN0IQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75BD7EE8000 for ; Fri, 8 Sep 2023 13:50:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243317AbjIHNug (ORCPT ); Fri, 8 Sep 2023 09:50:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230266AbjIHNuf (ORCPT ); Fri, 8 Sep 2023 09:50:35 -0400 Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74B361BC6 for ; Fri, 8 Sep 2023 06:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LbgxR6XC8LYMVBzfsv+O9qJkpfwcf2slpkIZbcLgfOw=; b=amB6TIzYbCI8yf9vGXczOH6gAb Necd/KYkOmHfQ8ShgSY+zaCPtTpDolSDpVYcgB0Cxgc967lR9v0sUO0K1oyH3at2+B8T23Ty2llYU qZalkl5ChML9LfUaG7ZDMjiUJFL7OTq/LrGs0Di+oblw2xGfDKfhCaymtM0ErZyPUcz27rf7oBn1A GM1LrIzFPqsJQWTrrzwvc6IqnrF0pr2ZUJgtLG1fn3wkRvJVaN6Z6p5eBIsICRxIPSrLEdZCUSS0H AMOV0UMv3c7zQY7CFUGDALXmUgOldxAa2fdUsX4UfJOcpU16jTr2s538brGD+AVocsrlL5c6h00bN xrdiy3KA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36590) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qebs9-00050u-2n; Fri, 08 Sep 2023 14:50:09 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qebs1-0006wF-Av; Fri, 08 Sep 2023 14:50:01 +0100 Date: Fri, 8 Sep 2023 14:50:01 +0100 From: "Russell King (Oracle)" To: Linus Walleij Cc: Zhizhou Zhang , rppt@kernel.org, akpm@linux-foundation.org, vishal.moola@gmail.com, arnd@arndb.de, wangkefeng.wang@huawei.com, willy@infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Zhizhou Zhang Subject: Re: [PATCH] ARM: mm: fix stack corruption when CONFIG_ARM_PV_FIXUP=y Message-ID: References: <20230907143302.4940-1-zhizhou.zh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 08, 2023 at 02:58:49PM +0200, Linus Walleij wrote: > Hi Zhizhou, > > wow a great patch! I'm surprised no-one has been hit by this before. > I guess we were lucky. > > On Thu, Sep 7, 2023 at 4:33 PM Zhizhou Zhang wrote: > > > From: Zhizhou Zhang > > > > flush_cache_all() save registers to stack at function entry. > > If it's called after cache disabled, the data is written to > > memory directly. So the following clean cache operation corrupted > > registers saved by flush_cache_all(), including lr register. > > calling flush_cache_all() before turn off cache fixed the problem. > > > > Signed-off-by: Zhizhou Zhang > > Reviewed-by: Linus Walleij > > I would also add > Cc: stable@vger.kernel.org > > Then please put this into Russell's patch tracker once review > is complete. However, it makes a total nonsense of the comment, which explains precisely why the flush_cache_all() is where it is. Moving it before that comment means that the comment is now rediculous. So, please don't put it in the patch system. The patch certainly needs to be tested on TI Keystone which is the primary user of this code. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!