From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF209EEB564 for ; Sat, 9 Sep 2023 08:24:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yJ1QFFPH6Gh545JcAuViV71fQhBPFdnVyS/V0EWFqh8=; b=F9GM2WZvohp7I2 SobmK/HYuf3QDAD3CRr8ATriCxYsD15ViF5lqy4ZCokBP6qq72OwtH73Q+hBMO7jjEop8vlpxVK9s ZWq9iWWDqdr9HKZSMT+7OKDa3xXTuWjphDbxkb05dZnRQgA5kk6AIsW8IQzdd6hvJq4GN3jVStes3 MwM315YW3A+pKw9e1/GrIj0U+jmNvJvozt1O0jTfcnuc6irR09K5lHYQPk2LvtEDXlwDm4zarUIt1 4KhYtnClfI6VznyiYInDSYqICPpx/uA3Owi3s2XtsYmd4R73QcDAi0EtXxFVCgw10ngjiRR2Wmr4K WkbNXMLWycjUrFuNoU7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qetG4-00FCIl-1I; Sat, 09 Sep 2023 08:24:00 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qetG1-00FCHu-0R for linux-arm-kernel@lists.infradead.org; Sat, 09 Sep 2023 08:23:58 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1c0c6d4d650so23378295ad.0 for ; Sat, 09 Sep 2023 01:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694247833; x=1694852633; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :date:from:from:to:cc:subject:date:message-id:reply-to; bh=isXLur4flyniG6AGvwddmNgn1Xc65gLUnTbB88HTkaw=; b=MqZ/6KDMbDaLM3rtefZPfuXOmnHdqzvB18/uVjImNXnWI9jI97x/IlPWHjY4Q5uKwz XA3oZvCT2zQ/Ea0buzG3txihJJZvD4BFV9Mpqhr0KL883fwTUEXY+YVZIcHNxfwKEiEH Sz+GHDouXZlYQGkOTX/yS5Kl3Il8NUDoD+j8PyPpzQ5yhZ/hK4khmM29/0LAVab85DWO 2KXpWrR7uBsNhDji64tMia3BtVt9nn/BwlhwL+xjBropwwS01Cwp2dy4pLLspQ4B+Zdh CCQ8xf7XObEo/3Ga9t/zO+ghjS50qqCcDCz9QsTmzPoJrx1wgDjz28Q5/2ZqdgVauHhz Z7uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694247833; x=1694852633; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=isXLur4flyniG6AGvwddmNgn1Xc65gLUnTbB88HTkaw=; b=js46P46odGaSa/af3orpmq9MUBx5L+20hLegEYBaS4wcjq4MqVTD02GFny91j8+r0L dK5qzuesw1GfcHyjoYUo1HNUAyG8GjUPCaHOGEkKE9msuYhFOG/I4Sh78BYbkDAlPm58 v4nNL1+nL6kTVyCZl6YaUr/dCdXTdKYLWZdEDS0PuEfN3ia08hYxi+kAYEjBJockwh4N ZyVrFObma2vG3+YHvDQ4yNP9l9R3Jej7WiaPQsU3xys1MDvcmTxCUqI4BpM9WLFE28F1 gSu2W6g51pgfAde20Q7B5jGMxyr4ppx+OP4q/FrtFZOzW1OsFhEmw7c56mV6WXlbLlVO Ewbg== X-Gm-Message-State: AOJu0YzHkk7Z0+5XC673xj83JgeudoKrokG5qmAmROYcOsioqlNYPt3O 1Z/ZxBgWT/R78Xz0IZeu+Zw= X-Google-Smtp-Source: AGHT+IH+WadAFHeutXh9oUopOzDOg9fn0pYhJUNVObI7o8eq3aDha8h1ZAiU/A3VAkzTz1Pp7lXlvw== X-Received: by 2002:a17:902:f7cf:b0:1c3:6705:bcee with SMTP id h15-20020a170902f7cf00b001c36705bceemr4612335plw.57.1694247832989; Sat, 09 Sep 2023 01:23:52 -0700 (PDT) Received: from localhost ([104.193.10.236]) by smtp.gmail.com with ESMTPSA id x2-20020a1709028ec200b001b89a6164desm2740726plo.118.2023.09.09.01.23.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Sep 2023 01:23:52 -0700 (PDT) From: Zhi-zhou Zhang X-Google-Original-From: Zhi-zhou Zhang Date: Sat, 9 Sep 2023 16:23:45 +0800 To: Linus Walleij Cc: "Russell King (Oracle)" , Andrew Davis , Nishanth Menon , Zhizhou Zhang , rppt@kernel.org, akpm@linux-foundation.org, vishal.moola@gmail.com, arnd@arndb.de, wangkefeng.wang@huawei.com, willy@infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: mm: fix stack corruption when CONFIG_ARM_PV_FIXUP=y Message-ID: Mail-Followup-To: Linus Walleij , "Russell King (Oracle)" , Andrew Davis , Nishanth Menon , Zhizhou Zhang , rppt@kernel.org, akpm@linux-foundation.org, vishal.moola@gmail.com, arnd@arndb.de, wangkefeng.wang@huawei.com, willy@infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230907143302.4940-1-zhizhou.zh@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230909_012357_197035_C06BEADF X-CRM114-Status: GOOD ( 29.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBTZXAgMDgsIDIwMjMgYXQgMTE6MDA6MzFQTSArMDIwMCwgTGludXMgV2FsbGVpaiB3 cm90ZToKPiBPbiBGcmksIFNlcCA4LCAyMDIzIGF0IDM6NTDigK9QTSBSdXNzZWxsIEtpbmcgKE9y YWNsZSkKPiA8bGludXhAYXJtbGludXgub3JnLnVrPiB3cm90ZToKPiAKPiA+IEhvd2V2ZXIsIGl0 IG1ha2VzIGEgdG90YWwgbm9uc2Vuc2Ugb2YgdGhlIGNvbW1lbnQsIHdoaWNoIGV4cGxhaW5zCj4g PiBwcmVjaXNlbHkgd2h5IHRoZSBmbHVzaF9jYWNoZV9hbGwoKSBpcyB3aGVyZSBpdCBpcy4gTW92 aW5nIGl0IGJlZm9yZQo+ID4gdGhhdCBjb21tZW50IG1lYW5zIHRoYXQgdGhlIGNvbW1lbnQgaXMg bm93IHJlZGljdWxvdXMuCj4gCj4gWmhpemhvdSwgY2FuIHlvdSBsb29rIG92ZXIgdGhlIGNvbW1l bnQgcGxhY2VtZW50PwoKTGludXMsIEkgZm91bmQgdGhlIGJ1ZyBvbiBhIGNvcnRleC1hNTUgY3B1 IHdpdGggaGlnaCBhZGRyZXNzIG1lbW9yeS4KU2luY2UgdGhlIGxyIGlzIGFsc28gY29ycnVwdHRl ZCwgd2hlbiBmbHVzaF9jYWNoZV9hbGwoKSBpcyBkb25lLCB0aGUKcHJvZ3JhbSBjb250aW51ZXMg YXQgdGhlIG5leHQgaW5zdHJ1Y3Rpb24gYWZ0ZXIgZml4dXBfcHZfdGFibGUoKS4gU28KdGhlIGRp c2FibGluZyBjYWNoZSBhbmQgZmx1c2hfY2FjaGVfYWxsKCkgaXMgZXhlY3V0ZWQgYSBzZWNvbmRh cnkgdGltZS4KVGhlbiB0aGlzIHRpbWUgbHIgaXMgY29ycmVjdCBzbyB0aGUga2VybmVsIG1heSBi b290IHVwIGFzIHVzdWFsLgoKSSByZWFkIHRoZSBjb21tZW50IGNhcmVmdWxseSwgSSBhbSBub3Qg c3VyZSBob3cgInRvIGVuc3VyZSBub3RoaW5nIGlzCnByZWZldGNoZWQgaW50byB0aGUgY2FjaGVz IiBhZmZlY3RzIHRoZSBzeXN0ZW0uIE15IHBhdGNoIGRvZXNuJ3QKcHJldmVudCBpbnN0cnV0aW9u IHByZWZldGNoIHRob3VnaC4gQnV0IGluIG15IGJvYXJkIGV2ZXJ5dGhpbmdzIGxvb2tzCmdvb2Qu CgpTbyBJIGNvbWUgdXAgd2l0aCBhIG5ldyBmaXh1cCBwbGFuLCB0aGF0J3Mga2VlcCB0aGUgbG9j YXRpb24gb2YKZmx1c2hfY2FjaGVfYWxsKCkgd2l0aCBhZGRpbmcgYSBmbHVzaCBzdGFjayBjYWNo ZSBiZWZvcmUgZGlzYWJsaW5nCmNhY2hlLCB0aGUgY29kZSBpcyBhcyBmb2xsb3csIHRoZSBmaXgg aXMgYSBiaXQgdWdseSAtLSBpdCBtYWtlcwphc3N1bXB0aW9uIHN0YWNrIGdyb3cgdG93YXJkcyBs b3cgYWRkcmVzcyBhbmQgZmx1c2hfY2FjaGVfYWxsKCkgd2lsbApub3Qgb2NjdXB5IG1vcmUgdGhh biAzMiBieXRlcyBpbiB0aGUgZnV0dXJlLiBDb21wYXJpbmcgd2l0aCBtb3ZlCmZsdXNoX2NhY2hl X2FsbCgpIGJlZm9yZSBkaXNhYmxpbmcgY2FjaGUsIFdoaWNoIG9uZSBkbyB5b3UgcHJlZmVyPwpU aGFua3MhCgpkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vbW0vbW11LmMgYi9hcmNoL2FybS9tbS9tbXUu YwppbmRleCAwM2ZiMGZlOTI2ZjMuLjgzYTU0YzYxYTg2YiAxMDA2NDQKLS0tIGEvYXJjaC9hcm0v bW0vbW11LmMKKysrIGIvYXJjaC9hcm0vbW0vbW11LmMKQEAgLTE2NDAsNiArMTY0MCw3IEBAIHN0 YXRpYyB2b2lkIF9faW5pdCBlYXJseV9wYWdpbmdfaW5pdChjb25zdCBzdHJ1Y3QgbWFjaGluZV9k ZXNjICptZGVzYykKIAl1bnNpZ25lZCBsb25nIHBhX3BnZDsKIAl1bnNpZ25lZCBpbnQgY3IsIHR0 YmNyOwogCWxvbmcgbG9uZyBvZmZzZXQ7CisJdm9pZCAqc3RhY2s7CiAKIAlpZiAoIW1kZXNjLT5w dl9maXh1cCkKIAkJcmV0dXJuOwpAQCAtMTY3NSw3ICsxNjc2LDE0IEBAIHN0YXRpYyB2b2lkIF9f aW5pdCBlYXJseV9wYWdpbmdfaW5pdChjb25zdCBzdHJ1Y3QgbWFjaGluZV9kZXNjICptZGVzYykK IAkvKiBSdW4gdGhlIHBhdGNoIHN0dWIgdG8gdXBkYXRlIHRoZSBjb25zdGFudHMgKi8KIAlmaXh1 cF9wdl90YWJsZSgmX19wdl90YWJsZV9iZWdpbiwKIAkJKCZfX3B2X3RhYmxlX2VuZCAtICZfX3B2 X3RhYmxlX2JlZ2luKSA8PCAyKTsKLQlmbHVzaF9jYWNoZV9hbGwoKTsKKworCS8qCisJICogY2xl YW4gc3RhY2sgaW4gY2FjaGVsaW5lIHRoYXQgdW5kZXJpbmcgbWVtb3J5IHdpbGwgYmUgY2hhbmdl ZCBpbgorCSAqIHRoZSBmb2xsb3dpbmcgZmx1c2hfY2FjaGVfYWxsKCkuIGFzc3VtaW5nIDMyIGJ5 dGVzIGlzIGVub3VnaCBmb3IKKwkgKiBmbHVzaF9jYWNoZV9hbGwoKS4KKwkgKi8KKwlzdGFjayA9 ICh2b2lkICopIChjdXJyZW50X3N0YWNrX3BvaW50ZXIgLSAzMik7CisJX19jcHVjX2ZsdXNoX2Rj YWNoZV9hcmVhKHN0YWNrLCAzMik7CiAKIAkvKgogCSAqIFdlIGNoYW5naW5nIG5vdCBvbmx5IHRo ZSB2aXJ0dWFsIHRvIHBoeXNpY2FsIG1hcHBpbmcsIGJ1dCBhbHNvCkBAIC0xNjkxLDYgKzE2OTks NyBAQCBzdGF0aWMgdm9pZCBfX2luaXQgZWFybHlfcGFnaW5nX2luaXQoY29uc3Qgc3RydWN0IG1h Y2hpbmVfZGVzYyAqbWRlc2MpCiAJYXNtKCJtcmMgcDE1LCAwLCAlMCwgYzIsIGMwLCAyIiA6ICI9 ciIgKHR0YmNyKSk7CiAJYXNtIHZvbGF0aWxlKCJtY3IgcDE1LCAwLCAlMCwgYzIsIGMwLCAyIgog CQk6IDogInIiICh0dGJjciAmIH4oMyA8PCA4IHwgMyA8PCAxMCkpKTsKKwlmbHVzaF9jYWNoZV9h bGwoKTsKIAogCS8qCiAJICogRml4dXAgdGhlIHBhZ2UgdGFibGVzIC0gdGhpcyBtdXN0IGJlIGlu IHRoZSBpZG1hcCByZWdpb24gYXMKCj4gCj4gPiBTbywgcGxlYXNlIGRvbid0IHB1dCBpdCBpbiB0 aGUgcGF0Y2ggc3lzdGVtLgo+ID4KPiA+IFRoZSBwYXRjaCBjZXJ0YWlubHkgbmVlZHMgdG8gYmUg dGVzdGVkIG9uIFRJIEtleXN0b25lIHdoaWNoIGlzIHRoZQo+ID4gcHJpbWFyeSB1c2VyIG9mIHRo aXMgY29kZS4KPiAKPiBBZGRlZCBBbmRyZXcgRGF2aXMgYW5kIE5pc2hhbnRoIE1lbm9uIHRvIHRo ZSB0aHJlYWQ6Cj4gY2FuIHlvdSBmb2xrcyByZXZpZXcgYW5kIHRlc3QgdGhpcyBmb3IgS2V5c3Rv bmU/Cj4gCj4gWW91cnMsCj4gTGludXMgV2FsbGVpagoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8390CEEB564 for ; Sat, 9 Sep 2023 08:23:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343989AbjIIIX7 (ORCPT ); Sat, 9 Sep 2023 04:23:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243092AbjIIIX6 (ORCPT ); Sat, 9 Sep 2023 04:23:58 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 898A81BD3 for ; Sat, 9 Sep 2023 01:23:53 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1c06f6f98c0so23200705ad.3 for ; Sat, 09 Sep 2023 01:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694247833; x=1694852633; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :date:from:from:to:cc:subject:date:message-id:reply-to; bh=isXLur4flyniG6AGvwddmNgn1Xc65gLUnTbB88HTkaw=; b=Usmz/paboxp9TMKgvI7bYLAiNt2M9ITlxUbNpkedzqZU38At4H4xOW3bofVp6+md6R u7AzFWyBM79oHonQuNcrQKHGNHcsCpL8AoLMqfZVKgHZTSsn2BfqitZe0gjKz+yClHd2 R5WvEinqdEqE2QS3vvHZNrN4GXf5tgi21qWz/PAlqA0fJZgLJs/Gup/QHM6/Cn7Raq/R bZeC8ILSmhqqIns+B8tN2yHGDm/ROF8JgOhbc3YDfnUOdww3nf4zCS81WMvcqXUhI+Dd xbF1JAtgQ7wNevgakwtknNT1z/8doLFCymrHgh1lOgUPxZmUSomGrwZYyQ+QLWXh9y7O FA2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694247833; x=1694852633; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=isXLur4flyniG6AGvwddmNgn1Xc65gLUnTbB88HTkaw=; b=kLy/DVDcQQDFY9IkStoOP7f7QpVMQZzvnkrLUVjPWhZC/OGXGzMhHkgNd+ayyrQmiu 5RBmcI5qCTp2P2JCSkjXwiV6dz9UtwD1CFFLjg4ORt9MqAUlG+5zxkK0iqVO7SY+4yWP QQ6UojCFFDqq4C+/ocD+uTqaZiD8MvJyvJ46wCVwY7jLwfnqjeauEBFRor3c3I1VTU2d 16llr6mEAWfV6JnVflzUingBZHuDrQWJ720BFi81oXk9xgEgX4av1U9yjSvBt93HAyR7 ZEzwCC/GTMrwDM4csZipA/ZK+8uNjADY7nfB45xhH3KyKFQb1e0wLoHT/I+Oy5g60GyK k4CA== X-Gm-Message-State: AOJu0YwlfWdouYT8JDC0XNKHzjYkk2ImEp9ou8SHDll/fllP11GOr8kB wbat6XxA0E5qLNkSbXlQhDU= X-Google-Smtp-Source: AGHT+IH+WadAFHeutXh9oUopOzDOg9fn0pYhJUNVObI7o8eq3aDha8h1ZAiU/A3VAkzTz1Pp7lXlvw== X-Received: by 2002:a17:902:f7cf:b0:1c3:6705:bcee with SMTP id h15-20020a170902f7cf00b001c36705bceemr4612335plw.57.1694247832989; Sat, 09 Sep 2023 01:23:52 -0700 (PDT) Received: from localhost ([104.193.10.236]) by smtp.gmail.com with ESMTPSA id x2-20020a1709028ec200b001b89a6164desm2740726plo.118.2023.09.09.01.23.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Sep 2023 01:23:52 -0700 (PDT) From: Zhi-zhou Zhang X-Google-Original-From: Zhi-zhou Zhang Date: Sat, 9 Sep 2023 16:23:45 +0800 To: Linus Walleij Cc: "Russell King (Oracle)" , Andrew Davis , Nishanth Menon , Zhizhou Zhang , rppt@kernel.org, akpm@linux-foundation.org, vishal.moola@gmail.com, arnd@arndb.de, wangkefeng.wang@huawei.com, willy@infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: mm: fix stack corruption when CONFIG_ARM_PV_FIXUP=y Message-ID: Mail-Followup-To: Linus Walleij , "Russell King (Oracle)" , Andrew Davis , Nishanth Menon , Zhizhou Zhang , rppt@kernel.org, akpm@linux-foundation.org, vishal.moola@gmail.com, arnd@arndb.de, wangkefeng.wang@huawei.com, willy@infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230907143302.4940-1-zhizhou.zh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 08, 2023 at 11:00:31PM +0200, Linus Walleij wrote: > On Fri, Sep 8, 2023 at 3:50 PM Russell King (Oracle) > wrote: > > > However, it makes a total nonsense of the comment, which explains > > precisely why the flush_cache_all() is where it is. Moving it before > > that comment means that the comment is now rediculous. > > Zhizhou, can you look over the comment placement? Linus, I found the bug on a cortex-a55 cpu with high address memory. Since the lr is also corruptted, when flush_cache_all() is done, the program continues at the next instruction after fixup_pv_table(). So the disabling cache and flush_cache_all() is executed a secondary time. Then this time lr is correct so the kernel may boot up as usual. I read the comment carefully, I am not sure how "to ensure nothing is prefetched into the caches" affects the system. My patch doesn't prevent instrution prefetch though. But in my board everythings looks good. So I come up with a new fixup plan, that's keep the location of flush_cache_all() with adding a flush stack cache before disabling cache, the code is as follow, the fix is a bit ugly -- it makes assumption stack grow towards low address and flush_cache_all() will not occupy more than 32 bytes in the future. Comparing with move flush_cache_all() before disabling cache, Which one do you prefer? Thanks! diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index 03fb0fe926f3..83a54c61a86b 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -1640,6 +1640,7 @@ static void __init early_paging_init(const struct machine_desc *mdesc) unsigned long pa_pgd; unsigned int cr, ttbcr; long long offset; + void *stack; if (!mdesc->pv_fixup) return; @@ -1675,7 +1676,14 @@ static void __init early_paging_init(const struct machine_desc *mdesc) /* Run the patch stub to update the constants */ fixup_pv_table(&__pv_table_begin, (&__pv_table_end - &__pv_table_begin) << 2); - flush_cache_all(); + + /* + * clean stack in cacheline that undering memory will be changed in + * the following flush_cache_all(). assuming 32 bytes is enough for + * flush_cache_all(). + */ + stack = (void *) (current_stack_pointer - 32); + __cpuc_flush_dcache_area(stack, 32); /* * We changing not only the virtual to physical mapping, but also @@ -1691,6 +1699,7 @@ static void __init early_paging_init(const struct machine_desc *mdesc) asm("mrc p15, 0, %0, c2, c0, 2" : "=r" (ttbcr)); asm volatile("mcr p15, 0, %0, c2, c0, 2" : : "r" (ttbcr & ~(3 << 8 | 3 << 10))); + flush_cache_all(); /* * Fixup the page tables - this must be in the idmap region as > > > So, please don't put it in the patch system. > > > > The patch certainly needs to be tested on TI Keystone which is the > > primary user of this code. > > Added Andrew Davis and Nishanth Menon to the thread: > can you folks review and test this for Keystone? > > Yours, > Linus Walleij