From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DACF93D987; Fri, 22 Sep 2023 14:31:16 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EAC41A3; Fri, 22 Sep 2023 07:31:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695393075; x=1726929075; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=RfDOh01dsGLCl9FfwUATjf4cBSql92IKvvisAzVKqmA=; b=XIKS8lxieQRheoxBOUX5sX9uLW4mHmam1GwGe8eeuSyOCC46axJztpcg IEevzENmnscA3hZfNtaE2xpf7CYEf68y0sBMz9bh18UeBZaXpk9KBKztB 6Z5FqqIKiwutg7SEFGxM7JoIadRDGzlC3w0YugOB7Yw6AciMcqVCTWSJd 2h4T2FBLwPRRMnbKAloqi+5M2x3dVUxZnSnn3agZNUrKitDNDsA22NaTc S2U+CXmLcvnPrpt2wpoXYyyxwPAr/zTt9F2f+Pzdcm0l0ZBrXJ98/CMqZ sqSy06EOkGYSI7docSjeqDuDb5CTwcFmtDU/wNUlDGRHBI5nQ/pbYwFEk Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10841"; a="360220475" X-IronPort-AV: E=Sophos;i="6.03,167,1694761200"; d="scan'208";a="360220475" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2023 07:31:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10841"; a="741113412" X-IronPort-AV: E=Sophos;i="6.03,167,1694761200"; d="scan'208";a="741113412" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2023 07:31:10 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qjhBT-0000000HCxc-2Wlf; Fri, 22 Sep 2023 17:31:07 +0300 Date: Fri, 22 Sep 2023 17:31:07 +0300 From: Andy Shevchenko To: Rob Herring Cc: "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , Russell King , Frank Rowand , Peng Fan Subject: Re: [PATCH v1 1/1] amba: bus: balance firmware node reference counting Message-ID: References: <20230824162654.2890992-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Fri, Sep 22, 2023 at 09:18:47AM -0500, Rob Herring wrote: > On Tue, Sep 19, 2023 at 3:02 PM Andy Shevchenko > wrote: > > On Tue, Sep 19, 2023 at 11:01:37PM +0300, Andy Shevchenko wrote: > > > On Thu, Aug 24, 2023 at 07:26:54PM +0300, Andy Shevchenko wrote: > > > > Currently the ACPI code doesn't bump the reference count of > > > > the firmware node, while OF counter part does. Not that it's > > > > a problem right now, since ACPI doesn't really use the reference > > > > counting for firmware nodes, it still makes sense to make code > > > > robust against any changes done there. For this, > > > > - switch ACPI case to use device_set_node() to be unified with OF > > > > - move reference counting to amba_device_add() > > > > - switch to use firmware nodes instead of OF ones > > > > > > > > In the result we will have reference counting done in the same module > > > > for all callers independently on the nature of firmware node behind. > > > > > > Any comment on this? I would like to have this applied so I can do something > > > similar to the platform driver code. > > > > Ah, I see, I missed LKP run on this, I'll send a v2 perhaps later on this week. > > What's the relationship/dependency with this and the other patches > dealing with refcounting? Did the AMBA one land? The OF refcounting is spread over platform code in unexpected places. So, we have something like of_foo() bumps it, platform ->release() drops it. It sounds to me as weird design to think of and AMBA is part of this mixture as it uses platform_bus, BUT has it's own ->release(), besides the fact that it's used in OF _and_ ACPI environments. What I would expect to have is both are really agnostic to the fwnode type and take and release reference in one place, but with OF <--> platform is kinda more complicated that with AMBA. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10536E6FE38 for ; Fri, 22 Sep 2023 14:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ep5MLb99EgX8me80Jju50R4boGH+RuU6LbeVo/r7L8o=; b=zglsnU/JIWJ15T /z1aW0BWQQaIep/BxlRWV7R7uYxPbiZp12lga/wtu/EAMS0J0aws4D0yrjQo9j2+AMtvjwrKfas/k UqSyZyH7eanHdPjjr7QrLnaPvnjzigrNY2ldcDkk8Vl9PpyG6Vr/oUvkD4q3euCtsNgnZT+yNdyQ/ sJ/7RSlUNSq0oXcxRnRNJFjO9wFrfBZBk8egqS+PjnluGioXU3Y1Nhk0nQqc8aK3XJwsIdp9SVaC6 aTSXeZKi46wLdNjiMRAlRuWh33TMEZUiArX/dhxsZvP0tYOnyLPIsclxdYhuxY75tDRACkGDYfoRb LMZQgy6I1cp467W7Sb6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjhBn-009CuR-0L; Fri, 22 Sep 2023 14:31:27 +0000 Received: from mgamail.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qjhBj-009Crm-0E for linux-arm-kernel@lists.infradead.org; Fri, 22 Sep 2023 14:31:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695393083; x=1726929083; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=RfDOh01dsGLCl9FfwUATjf4cBSql92IKvvisAzVKqmA=; b=mxb+gd2B1Jmvpc4x+XOc1RmRzelHkYOYYaAbL6KFJ50oub+dMQhLeXCv pSYBDOYYm/PEJj9QGKuhpfRf/6824enpKLBPNOX4zCSKflHWyKR1ftr7s V+uv1ivtrMdTBEZ/nEkz5jYS7qqMHYklGoAgsGG7bLvjIF8Po4Q/LRl2a zMkxJ0Sewyx4N81eHGLjOnkmHu3cc+nnmeU4Sxdxd5ixdy48vpmUIWtBM BIMcG3GydP4w1rSV3nwJWqHKCv63RJgeDH/5XUkwXT3o1uZwcHCr7HA6u WSBCE0YQL9qeqI1lqMU8mmQCZpgajTjwkvTjsZMU5m6wGO44PIGPsnfmR Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10841"; a="360220481" X-IronPort-AV: E=Sophos;i="6.03,167,1694761200"; d="scan'208";a="360220481" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2023 07:31:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10841"; a="741113412" X-IronPort-AV: E=Sophos;i="6.03,167,1694761200"; d="scan'208";a="741113412" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2023 07:31:10 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qjhBT-0000000HCxc-2Wlf; Fri, 22 Sep 2023 17:31:07 +0300 Date: Fri, 22 Sep 2023 17:31:07 +0300 From: Andy Shevchenko To: Rob Herring Cc: "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , Russell King , Frank Rowand , Peng Fan Subject: Re: [PATCH v1 1/1] amba: bus: balance firmware node reference counting Message-ID: References: <20230824162654.2890992-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230922_073123_652478_928F6A89 X-CRM114-Status: GOOD ( 25.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBTZXAgMjIsIDIwMjMgYXQgMDk6MTg6NDdBTSAtMDUwMCwgUm9iIEhlcnJpbmcgd3Jv dGU6Cj4gT24gVHVlLCBTZXAgMTksIDIwMjMgYXQgMzowMuKAr1BNIEFuZHkgU2hldmNoZW5rbwo+ IDxhbmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gT24gVHVlLCBT ZXAgMTksIDIwMjMgYXQgMTE6MDE6MzdQTSArMDMwMCwgQW5keSBTaGV2Y2hlbmtvIHdyb3RlOgo+ ID4gPiBPbiBUaHUsIEF1ZyAyNCwgMjAyMyBhdCAwNzoyNjo1NFBNICswMzAwLCBBbmR5IFNoZXZj aGVua28gd3JvdGU6Cj4gPiA+ID4gQ3VycmVudGx5IHRoZSBBQ1BJIGNvZGUgZG9lc24ndCBidW1w IHRoZSByZWZlcmVuY2UgY291bnQgb2YKPiA+ID4gPiB0aGUgZmlybXdhcmUgbm9kZSwgd2hpbGUg T0YgY291bnRlciBwYXJ0IGRvZXMuIE5vdCB0aGF0IGl0J3MKPiA+ID4gPiBhIHByb2JsZW0gcmln aHQgbm93LCBzaW5jZSBBQ1BJIGRvZXNuJ3QgcmVhbGx5IHVzZSB0aGUgcmVmZXJlbmNlCj4gPiA+ ID4gY291bnRpbmcgZm9yIGZpcm13YXJlIG5vZGVzLCBpdCBzdGlsbCBtYWtlcyBzZW5zZSB0byBt YWtlIGNvZGUKPiA+ID4gPiByb2J1c3QgYWdhaW5zdCBhbnkgY2hhbmdlcyBkb25lIHRoZXJlLiBG b3IgdGhpcywKPiA+ID4gPiAgLSBzd2l0Y2ggQUNQSSBjYXNlIHRvIHVzZSBkZXZpY2Vfc2V0X25v ZGUoKSB0byBiZSB1bmlmaWVkIHdpdGggT0YKPiA+ID4gPiAgLSBtb3ZlIHJlZmVyZW5jZSBjb3Vu dGluZyB0byBhbWJhX2RldmljZV9hZGQoKQo+ID4gPiA+ICAtIHN3aXRjaCB0byB1c2UgZmlybXdh cmUgbm9kZXMgaW5zdGVhZCBvZiBPRiBvbmVzCj4gPiA+ID4KPiA+ID4gPiBJbiB0aGUgcmVzdWx0 IHdlIHdpbGwgaGF2ZSByZWZlcmVuY2UgY291bnRpbmcgZG9uZSBpbiB0aGUgc2FtZSBtb2R1bGUK PiA+ID4gPiBmb3IgYWxsIGNhbGxlcnMgaW5kZXBlbmRlbnRseSBvbiB0aGUgbmF0dXJlIG9mIGZp cm13YXJlIG5vZGUgYmVoaW5kLgo+ID4gPgo+ID4gPiBBbnkgY29tbWVudCBvbiB0aGlzPyBJIHdv dWxkIGxpa2UgdG8gaGF2ZSB0aGlzIGFwcGxpZWQgc28gSSBjYW4gZG8gc29tZXRoaW5nCj4gPiA+ IHNpbWlsYXIgdG8gdGhlIHBsYXRmb3JtIGRyaXZlciBjb2RlLgo+ID4KPiA+IEFoLCBJIHNlZSwg SSBtaXNzZWQgTEtQIHJ1biBvbiB0aGlzLCBJJ2xsIHNlbmQgYSB2MiBwZXJoYXBzIGxhdGVyIG9u IHRoaXMgd2Vlay4KPiAKPiBXaGF0J3MgdGhlIHJlbGF0aW9uc2hpcC9kZXBlbmRlbmN5IHdpdGgg dGhpcyBhbmQgdGhlIG90aGVyIHBhdGNoZXMKPiBkZWFsaW5nIHdpdGggcmVmY291bnRpbmc/IERp ZCB0aGUgQU1CQSBvbmUgbGFuZD8KClRoZSBPRiByZWZjb3VudGluZyBpcyBzcHJlYWQgb3ZlciBw bGF0Zm9ybSBjb2RlIGluIHVuZXhwZWN0ZWQgcGxhY2VzLiBTbywgd2UKaGF2ZSBzb21ldGhpbmcg bGlrZSBvZl9mb28oKSBidW1wcyBpdCwgcGxhdGZvcm0gLT5yZWxlYXNlKCkgZHJvcHMgaXQuIEl0 IHNvdW5kcwp0byBtZSBhcyB3ZWlyZCBkZXNpZ24gdG8gdGhpbmsgb2YgYW5kIEFNQkEgaXMgcGFy dCBvZiB0aGlzIG1peHR1cmUgYXMgaXQgdXNlcwpwbGF0Zm9ybV9idXMsIEJVVCBoYXMgaXQncyBv d24gLT5yZWxlYXNlKCksIGJlc2lkZXMgdGhlIGZhY3QgdGhhdCBpdCdzIHVzZWQgaW4KT0YgX2Fu ZF8gQUNQSSBlbnZpcm9ubWVudHMuCgpXaGF0IEkgd291bGQgZXhwZWN0IHRvIGhhdmUgaXMgYm90 aCBhcmUgcmVhbGx5IGFnbm9zdGljIHRvIHRoZSBmd25vZGUgdHlwZQphbmQgdGFrZSBhbmQgcmVs ZWFzZSByZWZlcmVuY2UgaW4gb25lIHBsYWNlLCBidXQgd2l0aCBPRiA8LS0+IHBsYXRmb3JtIGlz CmtpbmRhIG1vcmUgY29tcGxpY2F0ZWQgdGhhdCB3aXRoIEFNQkEuCgotLSAKV2l0aCBCZXN0IFJl Z2FyZHMsCkFuZHkgU2hldmNoZW5rbwoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==