From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v2 09/11] gpio: acpi: replace gpiochip_find() with gpio_device_find()
Date: Tue, 12 Sep 2023 14:31:18 +0300 [thread overview]
Message-ID: <ZQBMBubLx2zSYwqL@smile.fi.intel.com> (raw)
In-Reply-To: <20230912100727.23197-10-brgl@bgdev.pl>
On Tue, Sep 12, 2023 at 12:07:25PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> We're porting all users of gpiochip_find() to using gpio_device_find().
> Update the ACPI GPIO code.
...
> + /*
> + * FIXME: keep track of this reference somehow instead of putting it
> + * here.
Under "this" you meant gdev? Please, spell it explicitly, I spent a couple of
minutes to get what exactly this comment is about.
> + */
> + return gpio_device_get_desc(gdev, pin);
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-12 11:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 10:07 [PATCH v2 00/11] gpiolib: work towards removing gpiochip_find() Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 01/11] gpiolib: make gpio_device_get() and gpio_device_put() public Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 02/11] gpiolib: add support for scope-based management to gpio_device Bartosz Golaszewski
2023-09-12 11:33 ` Andy Shevchenko
2023-09-12 11:36 ` Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 03/11] gpiolib: provide gpio_device_find() Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 04/11] gpiolib: provide gpio_device_find_by_label() Bartosz Golaszewski
2023-09-12 10:57 ` Andy Shevchenko
2023-09-14 19:55 ` Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 05/11] gpiolib: provide gpio_device_get_desc() Bartosz Golaszewski
2023-09-12 11:00 ` Andy Shevchenko
2023-09-12 10:07 ` [PATCH v2 06/11] gpiolib: reluctantly provide gpio_device_get_chip() Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 07/11] gpiolib: replace find_chip_by_name() with gpio_device_find_by_label() Bartosz Golaszewski
2023-09-12 11:08 ` Andy Shevchenko
2023-09-12 11:34 ` Bartosz Golaszewski
2023-09-12 11:16 ` Andy Shevchenko
2023-09-12 11:35 ` Bartosz Golaszewski
2023-09-15 9:44 ` Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 08/11] gpio: of: replace gpiochip_find_* with gpio_device_find_* Bartosz Golaszewski
2023-09-12 11:20 ` Andy Shevchenko
2023-09-12 10:07 ` [PATCH v2 09/11] gpio: acpi: replace gpiochip_find() with gpio_device_find() Bartosz Golaszewski
2023-09-12 11:31 ` Andy Shevchenko [this message]
2023-09-12 10:07 ` [PATCH v2 10/11] gpio: swnode: replace gpiochip_find() with gpio_device_find_by_label() Bartosz Golaszewski
2023-09-12 10:07 ` [PATCH v2 11/11] gpio: sysfs: drop the mention of gpiochip_find() from sysfs code Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQBMBubLx2zSYwqL@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.