From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D86EEE3F0F for ; Tue, 12 Sep 2023 19:26:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235851AbjILT0x (ORCPT ); Tue, 12 Sep 2023 15:26:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbjILT0w (ORCPT ); Tue, 12 Sep 2023 15:26:52 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFA5218D; Tue, 12 Sep 2023 12:26:48 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DE84C433C7; Tue, 12 Sep 2023 19:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694546808; bh=VKmYlBUpT/bsf1QKh+D267MgH+5GNHBssL6sD/Ma3Zo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JHOBkBbSNmOqERjudtzSv/JeaolTlSARYp8FJBxijm+lV2WsBYmAVdLEAUeDdh9MW L8B4BZ/k6gYBbs8lBKUpuMFlVZ+af5a4BpoYgz0SDdKJoO0LFhGveOEE9/PoLPZlsh FRSwoQTg63vDWylJ1ifvXqi8njDsu+WcecfH30yNpP+B6BiwzlANAUZAVM4cFFd+2+ u2aSA9FyhjffhisEfbGuChfzor8dOrwv0QaOOiJpjmiyqtZx/yn3vVNPkSaW8noA5h yhzSKqjsJZ7h5m2i+taMPdWXCt+bL/zaiHzJZPBLuTALgrZCC9Ufeod9mFp1TmMaI9 z6p3w6xfUJrzg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 38587403F4; Tue, 12 Sep 2023 16:26:45 -0300 (-03) Date: Tue, 12 Sep 2023 16:26:45 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: linux-perf-users@vger.kernel.org, irogers@google.com, John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Jing Zhang , Haixin Yu , Kajol Jain , Ravi Bangoria , Yang Jihong , Eduard Zingerman , Chen Zhongjin , Miguel Ojeda , Liam Howlett , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/7] perf pmu: Move pmu__find_core_pmu() to pmus.c Message-ID: References: <20230831151632.124985-1-james.clark@arm.com> <20230831151632.124985-6-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230831151632.124985-6-james.clark@arm.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Thu, Aug 31, 2023 at 04:16:16PM +0100, James Clark escreveu: > pmu__find_core_pmu() more logically belongs in pmus.c because it > iterates over all PMUs, so move it to pmus.c > > At the same time rename it to perf_pmus__find_core_pmu() to match the > naming convention in this file. > > Signed-off-by: James Clark So, this one is hitting this: CC /tmp/build/perf-tools-next/util/expr.o In file included from /var/home/acme/git/perf-tools-next/tools/include/linux/list.h:7, from util/pmus.c:2: In function ‘perf_pmus__scan_core’, inlined from ‘perf_pmus__find_core_pmu’ at util/pmus.c:601:16: /var/home/acme/git/perf-tools-next/tools/include/linux/kernel.h:36:45: error: array subscript 0 is outside array bounds of ‘struct list_head[1]’ [-Werror=array-bounds] 36 | const typeof(((type *)0)->member) * __mptr = (ptr); \ | ^~~~~~ /var/home/acme/git/perf-tools-next/tools/include/linux/list.h:352:9: note: in expansion of macro ‘container_of’ 352 | container_of(ptr, type, member) | ^~~~~~~~~~~~ /var/home/acme/git/perf-tools-next/tools/include/linux/list.h:404:9: note: in expansion of macro ‘list_entry’ 404 | list_entry((pos)->member.next, typeof(*(pos)), member) | ^~~~~~~~~~ /var/home/acme/git/perf-tools-next/tools/include/linux/list.h:494:20: note: in expansion of macro ‘list_next_entry’ 494 | for (pos = list_next_entry(pos, member); \ | ^~~~~~~~~~~~~~~ util/pmus.c:274:9: note: in expansion of macro ‘list_for_each_entry_continue’ 274 | list_for_each_entry_continue(pmu, &core_pmus, list) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ util/pmus.c: In function ‘perf_pmus__find_core_pmu’: util/pmus.c:35:18: note: at offset -128 into object ‘core_pmus’ of size 16 35 | static LIST_HEAD(core_pmus); | ^~~~~~~~~ /var/home/acme/git/perf-tools-next/tools/include/linux/list.h:23:26: note: in definition of macro ‘LIST_HEAD’ 23 | struct list_head name = LIST_HEAD_INIT(name) | ^~~~ cc1: all warnings being treated as errors make[4]: *** [/var/home/acme/git/perf-tools-next/tools/build/Makefile.build:97: /tmp/build/perf-tools-next/util/pmus.o] Error 1 make[4]: *** Waiting for unfinished jobs.... LD /tmp/build/perf-tools-next/ui/browsers/perf-in.o So I applied up to 4/7 Please continue from what will be in tmp.perf-tools-next in some jiffies. - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83A05EE3F0F for ; Tue, 12 Sep 2023 19:27:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bgGWRs2FnMz2MUBKPGpgB8Mk1dE141f7iR0pvGWswX0=; b=zPkZ5ufaaL8sPI I8XUGDcIKcMMQjCFhOyXqSSwaW4H3/xZ36fWi1njBaGa8BI9K9kFUkUCnz4voI+GXTKgrD2zZDgAB DADwiAu29gYS5Ky8AofctQ/u2lloQ+/SSftTU8Xn+ePfRGwMLnOJ8lcDK8bXIsdlhSWwSoAN85dM+ g70gjMzEmOJBvZBI5mAvqikRn8A77IGLSwaGFgoCS2lzgEAdFMVlon+fvhraqKlZ1RM3YwyxXXNI0 1BX9m9cZBq4/H8mPj/Bbl+OZt9gq7TikMJSUFz4qPEqCvaAPLGDwt2v1fO4VyqdvPqPh4U5wxRFsE 9S74e2+gF4RhMQgERBzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qg92B-0042gh-2O; Tue, 12 Sep 2023 19:26:51 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qg92B-0042g2-0E for linux-arm-kernel@bombadil.infradead.org; Tue, 12 Sep 2023 19:26:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=6FYvajVMDtY71Rq8O+O8TDgILrvka9xT8o4H5avlKb4=; b=YrRn45/TMwoJm7MvahCgVdYeBd Dedph5olJyTxBZqI5Uk48P0XhJJFj8rBZYbnVAwirHr63i+k8ZPCaLrRn416tmobHQuzpMr3pD4MU +rmmvQ2NlMoE3eyBR65CBn6+QGKr6nBGjVD0snhqhe8Kes+YZH9kOSckHRZEEZcAbhHhnQbHzP0D2 OEOf1pyLP249WkEhAcqee1yZJtuEVX9tQKQVD7rLjg9Rgi6buworkf65DZxtWDzhoKWrOfHqZtK0A pr0GuHGzpcLih/97tS1qh3cp11QCvZVTNbGA6VGx9aMiYYODfdTXg+bKV9Cf2hKGrclcL8hl4gW+L F2mFYpHw==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qg926-006Jvp-2y; Tue, 12 Sep 2023 19:26:49 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 38587403F4; Tue, 12 Sep 2023 16:26:45 -0300 (-03) Date: Tue, 12 Sep 2023 16:26:45 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: linux-perf-users@vger.kernel.org, irogers@google.com, John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Jing Zhang , Haixin Yu , Kajol Jain , Ravi Bangoria , Yang Jihong , Eduard Zingerman , Chen Zhongjin , Miguel Ojeda , Liam Howlett , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/7] perf pmu: Move pmu__find_core_pmu() to pmus.c Message-ID: References: <20230831151632.124985-1-james.clark@arm.com> <20230831151632.124985-6-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230831151632.124985-6-james.clark@arm.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gVGh1LCBBdWcgMzEsIDIwMjMgYXQgMDQ6MTY6MTZQTSArMDEwMCwgSmFtZXMgQ2xhcmsgZXNj cmV2ZXU6Cj4gcG11X19maW5kX2NvcmVfcG11KCkgbW9yZSBsb2dpY2FsbHkgYmVsb25ncyBpbiBw bXVzLmMgYmVjYXVzZSBpdAo+IGl0ZXJhdGVzIG92ZXIgYWxsIFBNVXMsIHNvIG1vdmUgaXQgdG8g cG11cy5jCj4gCj4gQXQgdGhlIHNhbWUgdGltZSByZW5hbWUgaXQgdG8gcGVyZl9wbXVzX19maW5k X2NvcmVfcG11KCkgdG8gbWF0Y2ggdGhlCj4gbmFtaW5nIGNvbnZlbnRpb24gaW4gdGhpcyBmaWxl Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEphbWVzIENsYXJrIDxqYW1lcy5jbGFya0Bhcm0uY29tPgoK U28sIHRoaXMgb25lIGlzIGhpdHRpbmcgdGhpczoKCiAgQ0MgICAgICAvdG1wL2J1aWxkL3BlcmYt dG9vbHMtbmV4dC91dGlsL2V4cHIubwpJbiBmaWxlIGluY2x1ZGVkIGZyb20gL3Zhci9ob21lL2Fj bWUvZ2l0L3BlcmYtdG9vbHMtbmV4dC90b29scy9pbmNsdWRlL2xpbnV4L2xpc3QuaDo3LAogICAg ICAgICAgICAgICAgIGZyb20gdXRpbC9wbXVzLmM6MjoKSW4gZnVuY3Rpb24g4oCYcGVyZl9wbXVz X19zY2FuX2NvcmXigJksCiAgICBpbmxpbmVkIGZyb20g4oCYcGVyZl9wbXVzX19maW5kX2NvcmVf cG114oCZIGF0IHV0aWwvcG11cy5jOjYwMToxNjoKL3Zhci9ob21lL2FjbWUvZ2l0L3BlcmYtdG9v bHMtbmV4dC90b29scy9pbmNsdWRlL2xpbnV4L2tlcm5lbC5oOjM2OjQ1OiBlcnJvcjogYXJyYXkg c3Vic2NyaXB0IDAgaXMgb3V0c2lkZSBhcnJheSBib3VuZHMgb2Yg4oCYc3RydWN0IGxpc3RfaGVh ZFsxXeKAmSBbLVdlcnJvcj1hcnJheS1ib3VuZHNdCiAgIDM2IHwgICAgICAgICBjb25zdCB0eXBl b2YoKCh0eXBlICopMCktPm1lbWJlcikgKiBfX21wdHIgPSAocHRyKTsgICAgIFwKICAgICAgfCAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+fn5+fgovdmFyL2hv bWUvYWNtZS9naXQvcGVyZi10b29scy1uZXh0L3Rvb2xzL2luY2x1ZGUvbGludXgvbGlzdC5oOjM1 Mjo5OiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCYY29udGFpbmVyX29m4oCZCiAgMzUy IHwgICAgICAgICBjb250YWluZXJfb2YocHRyLCB0eXBlLCBtZW1iZXIpCiAgICAgIHwgICAgICAg ICBefn5+fn5+fn5+fn4KL3Zhci9ob21lL2FjbWUvZ2l0L3BlcmYtdG9vbHMtbmV4dC90b29scy9p bmNsdWRlL2xpbnV4L2xpc3QuaDo0MDQ6OTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKA mGxpc3RfZW50cnnigJkKICA0MDQgfCAgICAgICAgIGxpc3RfZW50cnkoKHBvcyktPm1lbWJlci5u ZXh0LCB0eXBlb2YoKihwb3MpKSwgbWVtYmVyKQogICAgICB8ICAgICAgICAgXn5+fn5+fn5+fgov dmFyL2hvbWUvYWNtZS9naXQvcGVyZi10b29scy1uZXh0L3Rvb2xzL2luY2x1ZGUvbGludXgvbGlz dC5oOjQ5NDoyMDogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmGxpc3RfbmV4dF9lbnRy eeKAmQogIDQ5NCB8ICAgICAgICAgZm9yIChwb3MgPSBsaXN0X25leHRfZW50cnkocG9zLCBtZW1i ZXIpOyAgICAgICAgICAgICAgICAgICAgICAgIFwKICAgICAgfCAgICAgICAgICAgICAgICAgICAg Xn5+fn5+fn5+fn5+fn5+CnV0aWwvcG11cy5jOjI3NDo5OiBub3RlOiBpbiBleHBhbnNpb24gb2Yg bWFjcm8g4oCYbGlzdF9mb3JfZWFjaF9lbnRyeV9jb250aW51ZeKAmQogIDI3NCB8ICAgICAgICAg bGlzdF9mb3JfZWFjaF9lbnRyeV9jb250aW51ZShwbXUsICZjb3JlX3BtdXMsIGxpc3QpCiAgICAg IHwgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+CnV0aWwvcG11cy5jOiBJbiBm dW5jdGlvbiDigJhwZXJmX3BtdXNfX2ZpbmRfY29yZV9wbXXigJk6CnV0aWwvcG11cy5jOjM1OjE4 OiBub3RlOiBhdCBvZmZzZXQgLTEyOCBpbnRvIG9iamVjdCDigJhjb3JlX3BtdXPigJkgb2Ygc2l6 ZSAxNgogICAzNSB8IHN0YXRpYyBMSVNUX0hFQUQoY29yZV9wbXVzKTsKICAgICAgfCAgICAgICAg ICAgICAgICAgIF5+fn5+fn5+fgovdmFyL2hvbWUvYWNtZS9naXQvcGVyZi10b29scy1uZXh0L3Rv b2xzL2luY2x1ZGUvbGludXgvbGlzdC5oOjIzOjI2OiBub3RlOiBpbiBkZWZpbml0aW9uIG9mIG1h Y3JvIOKAmExJU1RfSEVBROKAmQogICAyMyB8ICAgICAgICAgc3RydWN0IGxpc3RfaGVhZCBuYW1l ID0gTElTVF9IRUFEX0lOSVQobmFtZSkKICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAg Xn5+fgpjYzE6IGFsbCB3YXJuaW5ncyBiZWluZyB0cmVhdGVkIGFzIGVycm9ycwptYWtlWzRdOiAq KiogWy92YXIvaG9tZS9hY21lL2dpdC9wZXJmLXRvb2xzLW5leHQvdG9vbHMvYnVpbGQvTWFrZWZp bGUuYnVpbGQ6OTc6IC90bXAvYnVpbGQvcGVyZi10b29scy1uZXh0L3V0aWwvcG11cy5vXSBFcnJv ciAxCm1ha2VbNF06ICoqKiBXYWl0aW5nIGZvciB1bmZpbmlzaGVkIGpvYnMuLi4uCiAgTEQgICAg ICAvdG1wL2J1aWxkL3BlcmYtdG9vbHMtbmV4dC91aS9icm93c2Vycy9wZXJmLWluLm8KCgpTbyBJ IGFwcGxpZWQgdXAgdG8gNC83CgpQbGVhc2UgY29udGludWUgZnJvbSB3aGF0IHdpbGwgYmUgaW4g dG1wLnBlcmYtdG9vbHMtbmV4dCBpbiBzb21lCmppZmZpZXMuCgotIEFybmFsZG8KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK