From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Network Development <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next v1 2/2] net: core: Sort headers alphabetically
Date: Tue, 12 Sep 2023 20:22:04 +0300 [thread overview]
Message-ID: <ZQCePNVobAeCVUjI@smile.fi.intel.com> (raw)
In-Reply-To: <CAADnVQLk4JRKXoNA6h=hd25bmCuVP=DM0yRswM0a=wgKuYbdhA@mail.gmail.com>
On Tue, Sep 12, 2023 at 10:07:35AM -0700, Alexei Starovoitov wrote:
> On Tue, Sep 12, 2023 at 10:05 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Sep 12, 2023 at 06:53:23PM +0200, Paolo Abeni wrote:
> > > On Tue, 2023-09-12 at 19:35 +0300, Andy Shevchenko wrote:
> > > > On Tue, Sep 12, 2023 at 05:20:31PM +0200, Simon Horman wrote:
> > > > > On Mon, Sep 11, 2023 at 06:45:34PM +0300, Andy Shevchenko wrote:
...
> > > I'm unsure this change is worthy. It will make any later fix touching
> > > the header list more difficult to backport, and I don't see a great
> > > direct advantage.
> >
> > As Rasmus put it here
> > https://lore.kernel.org/lkml/5eca0ab5-84be-2d8f-e0b3-c9fdfa961826@rasmusvillemoes.dk/
> > In short term you can argue that it's not beneficial, but in long term it's given
> > less conflicts.
>
> I agree with Paolo.
I see.
> This is just code churn.
> The includes will become unsorted eventually.
> Headers might get renamed, split, etc.
> Keeping things sorted is a headache.
Keeping the mess is simpler, I agree. :-(
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-12 17:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 15:45 [PATCH net-next v1 1/2] net: core: Use the bitmap API to allocate bitmaps Andy Shevchenko
2023-09-11 15:45 ` [PATCH net-next v1 2/2] net: core: Sort headers alphabetically Andy Shevchenko
2023-09-12 15:20 ` Simon Horman
2023-09-12 16:35 ` Andy Shevchenko
2023-09-12 16:53 ` Paolo Abeni
2023-09-12 17:04 ` Andy Shevchenko
2023-09-12 17:07 ` Alexei Starovoitov
2023-09-12 17:22 ` Andy Shevchenko [this message]
2023-09-12 17:25 ` Paolo Abeni
2023-09-13 11:10 ` Andy Shevchenko
2023-09-12 15:21 ` [PATCH net-next v1 1/2] net: core: Use the bitmap API to allocate bitmaps Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQCePNVobAeCVUjI@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.