From: Sean Christopherson <seanjc@google.com>
To: Haitao Shan <hshan@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Fix lapic timer interrupt lost after loading a snapshot.
Date: Tue, 12 Sep 2023 18:14:25 +0000 [thread overview]
Message-ID: <ZQCqgenuRcB4c6/R@google.com> (raw)
In-Reply-To: <CAGD3tSzxgSmuC8MOt_Wek3rkO4gjT908x0bF2MNYot1W=FBcow@mail.gmail.com>
Please send mail as plain text, most of the mailing lists reject HTML, and in
general HTML makes everyone grumpy.
On Tue, Sep 12, 2023, Haitao Shan wrote:
> On Tue, Sep 12, 2023 at 10:07 AM Sean Christopherson <seanjc@google.com>
> wrote:
>
> > Aha! And I think the new apicv_pre_state_restore() needs to be invoked
> > even if APICv is not active, because I don't see anything that purges the
> > PIR when APICv is enabled. VMX's APICv doesn't have many inhibits that can
> > go away, and I highly doubt userspace will restore into a vCPU with pending
> > posted interrupts, so in practice this is _extremely_ unlikely to be
> > problematic. But it's still wrong.
> >
> Thanks for sharing what you would like to fix the bug. I will write a v2 for
> that. Actually, I am sorry that I forgot to add RFC to the title, as I
> personally did not think the proposed fix looks clean.
No worries, thanks for taking this on!
next prev parent reply other threads:[~2023-09-12 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 16:15 [PATCH] KVM: x86: Fix lapic timer interrupt lost after loading a snapshot Haitao Shan
2023-09-12 16:53 ` Brett Creeley
2023-09-12 17:07 ` Sean Christopherson
[not found] ` <CAGD3tSzxgSmuC8MOt_Wek3rkO4gjT908x0bF2MNYot1W=FBcow@mail.gmail.com>
2023-09-12 18:14 ` Sean Christopherson [this message]
2023-09-12 18:16 ` Haitao Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQCqgenuRcB4c6/R@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=hshan@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.