From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64D76EEAA5F for ; Thu, 14 Sep 2023 18:06:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1D+/SKBfP3op3rJcuUd1QTL4SUDL0Vl8hzAaaiQ05QA=; b=Ws0hvfomBYduqJgQ5HtXrB6gUH 8D9zsF9OVybfb1WBLR378Rx0UWHRrjK+EErWnc9/jl1xJkuUv3NsSySXmm4oAxcOLsgF72FdKAgRm 1tWN9YcH+nxK0vg+ITSAhTzyhV7D/IBtmtKmOMNH08rRL9DhCkcqKpY8DjIl4I2SvsD1+CECRNHHv +RPfQswovvFupX/vk87UYtVt2v8ConOFeWIQtvW8fK8DN3gZ7liIZBO13inZ+TEFhdJFXm/Ag7k83 0VDT+z0mvV8/LaCixCQBrd50SV0HIMNz2j2arkBTrxZeJY2ZR055r4JDFH4Ts5cIqZM4OxOKtRhev gOn47DKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgqjo-0092FK-11; Thu, 14 Sep 2023 18:06:48 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qgqjk-0092E2-0e; Thu, 14 Sep 2023 18:06:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1D+/SKBfP3op3rJcuUd1QTL4SUDL0Vl8hzAaaiQ05QA=; b=oTYBk4M3u15uWEFrkJeYaNABsn 4SlrZEZ1WnSQ6iG5PsCCW3OJcnRQyRWFERG17cyeloVk5IZXV+W/7YYeXQzx4KLSISJ9v3icL+OYB ULoRZVOzaE1vCBOoF9wm99Stm87Hb5xK5og7jL9hsdNB1MODNk8YvCx0j9axxvSa3h/nn5VEkMwtp oNDPSNNrTBqjlTF2OW2i192v8m99oW3sTtYOPO6hAXvrVjwcgEvkqTlqGwTBpbsoSlZOjV3QWoiQk T4V953zJY/gikz2sIL7gNZw+9+bgQgbDng7TT3aeobFMRTgKNC0p3avg1A+R6U9nU9oRqssDa1RTc 06RbnWZw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:50940) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qgqjI-0004fs-10; Thu, 14 Sep 2023 19:06:16 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qgqjC-0004z2-Sn; Thu, 14 Sep 2023 19:06:10 +0100 Date: Thu, 14 Sep 2023 19:06:10 +0100 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Woojung Huh , UNGLinuxDriver@microchip.com, Linus Walleij , Alvin =?utf-8?Q?=C5=A0ipraga?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 2/4] dt-bindings: net: dsa: document internal MDIO bus Message-ID: References: <0cee0928-74c9-4048-8cd8-70bfbfafd9b2@arinc9.com> <20230827121235.zog4c3ehu2cyd3jy@skbuf> <676d1a2b-6ffa-4aff-8bed-a749c373f5b3@arinc9.com> <87325ce9-595a-4dda-a6a1-b5927d25719b@arinc9.com> <20230911225126.rk23g3u3bzo3agby@skbuf> <036c0763-f1b2-49ff-bc82-1ff16eec27ab@arinc9.com> <20230912193450.h5s6miubag46z623@skbuf> <6cec079e-991e-4222-a76d-d6156de0daca@arinc9.com> <20230913074231.5azwxqjuv2wp5nik@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230914_110644_236730_F87659BE X-CRM114-Status: GOOD ( 33.03 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Sep 13, 2023 at 04:59:19PM +0100, Russell King (Oracle) wrote: > On Wed, Sep 13, 2023 at 10:42:31AM +0300, Vladimir Oltean wrote: > > On Wed, Sep 13, 2023 at 08:52:37AM +0300, Arınç ÜNAL wrote: > > > On 12.09.2023 22:34, Vladimir Oltean wrote: > > > > On Tue, Sep 12, 2023 at 10:23:51PM +0300, Arınç ÜNAL wrote: > > > > > The phylink bindings for user ports I ended up making by looking up the > > > > > existing devicetrees are different than the phylink bindings for the shared > > > > > (CPU and DSA) ports currently enforced on all switches. > > > > > > > > > > My phylink bindings for user ports: > > > > > > > > > > allOf: > > > > > - anyOf: > > > > > - required: [ fixed-link ] > > > > > - required: [ phy-handle ] > > > > > - required: [ managed ] > > > > > > > > > > - if: > > > > > required: [ fixed-link ] > > > > > then: > > > > > not: > > > > > required: [ managed ] > > > > > > > > Right, it should have been anyOf and not oneOf.. my mistake. It is a bug > > > > which should be fixed. It's the same phylink that gets used in both cases, > > > > user ports and shared ports :) > > > > > > One more thing, I don't recall phy-mode being required to be defined for > > > user ports as it will default to GMII. I don't believe this is the same > > > case for shared ports so phy-mode is required only for them? > > > > phy-mode is not strictly required, but I think there is a strong > > preference to set it. IIRC, when looking at the DSA device trees, there > > was no case where phy-mode would be absent on CPU/DSA ports if the other > > link properties were also present, so we required it too. There were no > > complaints in 1 year since dsa_shared_port_validate_of() is there. The > > requirement can be relaxed to just a warning and no error in the kernel, > > and the removal of "required" in the schema, if it helps making it > > common with user ports. > > However, phylink pretty much requires phy-mode to be specified to be > something sane for shared ports, so I wouldn't be in favour of relaxing > the checkinng in dsa_shared_port_validate_of()... not unless you're > now going to accept the approach I originally proposed to have DSA > drivers tell the core (and thus phylink) what phy-mode and other link > parameters should be used when they are missing from DT. You mean the approach that I picked up using software nodes that got thrown out by the software node people? That approach that I picked up from you and tried to get merged? No, that's not going to happen, and it's not a question of whether _I_ am going to accept that approach or not. So don't throw that back on me, please. If this is something that we want to solve, we need to stop being so devisive (your language above is so) and try to come up with a solution that is acceptable to everyone... the swnode approach doesn't seem to be it. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3E77EEAA5D for ; Thu, 14 Sep 2023 18:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xG+G/mwzCEYMmczntXYX/hkzDtYoYG9dOeAd17rYwW0=; b=YRWUW/B6F1mCsq wIQ5oH+Unx9EAdSNfQLgCJ8YLrGONTbZ1NjwNrXhj+zCSs5xN0fMfRyZLAz6SIkPJeIL2UMz76cyE 84/t71uoPZ7maDH8PumBkH3rJDUglgKA8IiST07U+1WR+nJyDvLyOuY1PJqPu3Tdz2/a5kuukj7h0 IUKp2gI1E3ho9MX6IqgFZ9zRfE6JnXIeHvPU5l4SiMX1vGt0k1FgX6T4jI2VdhvZBBI8agG/ArEzk g9P9b3miYMOULCREi8dinhrJ4EO6DSLtoF35u10Br0RWd5RmCoN2wxHbec5jXW70aNTGYjgP4Ut4c CZ/fK6RI95SZT3oRMRUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgqjn-0092F0-2L; Thu, 14 Sep 2023 18:06:47 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qgqjk-0092E2-0e; Thu, 14 Sep 2023 18:06:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1D+/SKBfP3op3rJcuUd1QTL4SUDL0Vl8hzAaaiQ05QA=; b=oTYBk4M3u15uWEFrkJeYaNABsn 4SlrZEZ1WnSQ6iG5PsCCW3OJcnRQyRWFERG17cyeloVk5IZXV+W/7YYeXQzx4KLSISJ9v3icL+OYB ULoRZVOzaE1vCBOoF9wm99Stm87Hb5xK5og7jL9hsdNB1MODNk8YvCx0j9axxvSa3h/nn5VEkMwtp oNDPSNNrTBqjlTF2OW2i192v8m99oW3sTtYOPO6hAXvrVjwcgEvkqTlqGwTBpbsoSlZOjV3QWoiQk T4V953zJY/gikz2sIL7gNZw+9+bgQgbDng7TT3aeobFMRTgKNC0p3avg1A+R6U9nU9oRqssDa1RTc 06RbnWZw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:50940) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qgqjI-0004fs-10; Thu, 14 Sep 2023 19:06:16 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qgqjC-0004z2-Sn; Thu, 14 Sep 2023 19:06:10 +0100 Date: Thu, 14 Sep 2023 19:06:10 +0100 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Woojung Huh , UNGLinuxDriver@microchip.com, Linus Walleij , Alvin =?utf-8?Q?=C5=A0ipraga?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 2/4] dt-bindings: net: dsa: document internal MDIO bus Message-ID: References: <0cee0928-74c9-4048-8cd8-70bfbfafd9b2@arinc9.com> <20230827121235.zog4c3ehu2cyd3jy@skbuf> <676d1a2b-6ffa-4aff-8bed-a749c373f5b3@arinc9.com> <87325ce9-595a-4dda-a6a1-b5927d25719b@arinc9.com> <20230911225126.rk23g3u3bzo3agby@skbuf> <036c0763-f1b2-49ff-bc82-1ff16eec27ab@arinc9.com> <20230912193450.h5s6miubag46z623@skbuf> <6cec079e-991e-4222-a76d-d6156de0daca@arinc9.com> <20230913074231.5azwxqjuv2wp5nik@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230914_110644_236730_F87659BE X-CRM114-Status: GOOD ( 33.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBTZXAgMTMsIDIwMjMgYXQgMDQ6NTk6MTlQTSArMDEwMCwgUnVzc2VsbCBLaW5nIChP cmFjbGUpIHdyb3RlOgo+IE9uIFdlZCwgU2VwIDEzLCAyMDIzIGF0IDEwOjQyOjMxQU0gKzAzMDAs IFZsYWRpbWlyIE9sdGVhbiB3cm90ZToKPiA+IE9uIFdlZCwgU2VwIDEzLCAyMDIzIGF0IDA4OjUy OjM3QU0gKzAzMDAsIEFyxLFuw6cgw5xOQUwgd3JvdGU6Cj4gPiA+IE9uIDEyLjA5LjIwMjMgMjI6 MzQsIFZsYWRpbWlyIE9sdGVhbiB3cm90ZToKPiA+ID4gPiBPbiBUdWUsIFNlcCAxMiwgMjAyMyBh dCAxMDoyMzo1MVBNICswMzAwLCBBcsSxbsOnIMOcTkFMIHdyb3RlOgo+ID4gPiA+ID4gVGhlIHBo eWxpbmsgYmluZGluZ3MgZm9yIHVzZXIgcG9ydHMgSSBlbmRlZCB1cCBtYWtpbmcgYnkgbG9va2lu ZyB1cCB0aGUKPiA+ID4gPiA+IGV4aXN0aW5nIGRldmljZXRyZWVzIGFyZSBkaWZmZXJlbnQgdGhh biB0aGUgcGh5bGluayBiaW5kaW5ncyBmb3IgdGhlIHNoYXJlZAo+ID4gPiA+ID4gKENQVSBhbmQg RFNBKSBwb3J0cyBjdXJyZW50bHkgZW5mb3JjZWQgb24gYWxsIHN3aXRjaGVzLgo+ID4gPiA+ID4g Cj4gPiA+ID4gPiBNeSBwaHlsaW5rIGJpbmRpbmdzIGZvciB1c2VyIHBvcnRzOgo+ID4gPiA+ID4g Cj4gPiA+ID4gPiAgICAgICAgICAgICAgYWxsT2Y6Cj4gPiA+ID4gPiAgICAgICAgICAgICAgICAt IGFueU9mOgo+ID4gPiA+ID4gICAgICAgICAgICAgICAgICAgIC0gcmVxdWlyZWQ6IFsgZml4ZWQt bGluayBdCj4gPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgLSByZXF1aXJlZDogWyBwaHktaGFu ZGxlIF0KPiA+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAtIHJlcXVpcmVkOiBbIG1hbmFnZWQg XQo+ID4gPiA+ID4gCj4gPiA+ID4gPiAgICAgICAgICAgICAgICAtIGlmOgo+ID4gPiA+ID4gICAg ICAgICAgICAgICAgICAgIHJlcXVpcmVkOiBbIGZpeGVkLWxpbmsgXQo+ID4gPiA+ID4gICAgICAg ICAgICAgICAgICB0aGVuOgo+ID4gPiA+ID4gICAgICAgICAgICAgICAgICAgIG5vdDoKPiA+ID4g PiA+ICAgICAgICAgICAgICAgICAgICAgIHJlcXVpcmVkOiBbIG1hbmFnZWQgXQo+ID4gPiA+IAo+ ID4gPiA+IFJpZ2h0LCBpdCBzaG91bGQgaGF2ZSBiZWVuIGFueU9mIGFuZCBub3Qgb25lT2YuLiBt eSBtaXN0YWtlLiBJdCBpcyBhIGJ1Zwo+ID4gPiA+IHdoaWNoIHNob3VsZCBiZSBmaXhlZC4gSXQn cyB0aGUgc2FtZSBwaHlsaW5rIHRoYXQgZ2V0cyB1c2VkIGluIGJvdGggY2FzZXMsCj4gPiA+ID4g dXNlciBwb3J0cyBhbmQgc2hhcmVkIHBvcnRzIDopCj4gPiA+IAo+ID4gPiBPbmUgbW9yZSB0aGlu ZywgSSBkb24ndCByZWNhbGwgcGh5LW1vZGUgYmVpbmcgcmVxdWlyZWQgdG8gYmUgZGVmaW5lZCBm b3IKPiA+ID4gdXNlciBwb3J0cyBhcyBpdCB3aWxsIGRlZmF1bHQgdG8gR01JSS4gSSBkb24ndCBi ZWxpZXZlIHRoaXMgaXMgdGhlIHNhbWUKPiA+ID4gY2FzZSBmb3Igc2hhcmVkIHBvcnRzIHNvIHBo eS1tb2RlIGlzIHJlcXVpcmVkIG9ubHkgZm9yIHRoZW0/Cj4gPiAKPiA+IHBoeS1tb2RlIGlzIG5v dCBzdHJpY3RseSByZXF1aXJlZCwgYnV0IEkgdGhpbmsgdGhlcmUgaXMgYSBzdHJvbmcKPiA+IHBy ZWZlcmVuY2UgdG8gc2V0IGl0LiBJSVJDLCB3aGVuIGxvb2tpbmcgYXQgdGhlIERTQSBkZXZpY2Ug dHJlZXMsIHRoZXJlCj4gPiB3YXMgbm8gY2FzZSB3aGVyZSBwaHktbW9kZSB3b3VsZCBiZSBhYnNl bnQgb24gQ1BVL0RTQSBwb3J0cyBpZiB0aGUgb3RoZXIKPiA+IGxpbmsgcHJvcGVydGllcyB3ZXJl IGFsc28gcHJlc2VudCwgc28gd2UgcmVxdWlyZWQgaXQgdG9vLiBUaGVyZSB3ZXJlIG5vCj4gPiBj b21wbGFpbnRzIGluIDEgeWVhciBzaW5jZSBkc2Ffc2hhcmVkX3BvcnRfdmFsaWRhdGVfb2YoKSBp cyB0aGVyZS4gVGhlCj4gPiByZXF1aXJlbWVudCBjYW4gYmUgcmVsYXhlZCB0byBqdXN0IGEgd2Fy bmluZyBhbmQgbm8gZXJyb3IgaW4gdGhlIGtlcm5lbCwKPiA+IGFuZCB0aGUgcmVtb3ZhbCBvZiAi cmVxdWlyZWQiIGluIHRoZSBzY2hlbWEsIGlmIGl0IGhlbHBzIG1ha2luZyBpdAo+ID4gY29tbW9u IHdpdGggdXNlciBwb3J0cy4KPiAKPiBIb3dldmVyLCBwaHlsaW5rIHByZXR0eSBtdWNoIHJlcXVp cmVzIHBoeS1tb2RlIHRvIGJlIHNwZWNpZmllZCB0byBiZQo+IHNvbWV0aGluZyBzYW5lIGZvciBz aGFyZWQgcG9ydHMsIHNvIEkgd291bGRuJ3QgYmUgaW4gZmF2b3VyIG9mIHJlbGF4aW5nCj4gdGhl IGNoZWNraW5uZyBpbiBkc2Ffc2hhcmVkX3BvcnRfdmFsaWRhdGVfb2YoKS4uLiBub3QgdW5sZXNz IHlvdSdyZQo+IG5vdyBnb2luZyB0byBhY2NlcHQgdGhlIGFwcHJvYWNoIEkgb3JpZ2luYWxseSBw cm9wb3NlZCB0byBoYXZlIERTQQo+IGRyaXZlcnMgdGVsbCB0aGUgY29yZSAoYW5kIHRodXMgcGh5 bGluaykgd2hhdCBwaHktbW9kZSBhbmQgb3RoZXIgbGluawo+IHBhcmFtZXRlcnMgc2hvdWxkIGJl IHVzZWQgd2hlbiB0aGV5IGFyZSBtaXNzaW5nIGZyb20gRFQuCgpZb3UgbWVhbiB0aGUgYXBwcm9h Y2ggdGhhdCBJIHBpY2tlZCB1cCB1c2luZyBzb2Z0d2FyZSBub2RlcyB0aGF0IGdvdAp0aHJvd24g b3V0IGJ5IHRoZSBzb2Z0d2FyZSBub2RlIHBlb3BsZT8gVGhhdCBhcHByb2FjaCB0aGF0IEkgcGlj a2VkCnVwIGZyb20geW91IGFuZCB0cmllZCB0byBnZXQgbWVyZ2VkPwoKTm8sIHRoYXQncyBub3Qg Z29pbmcgdG8gaGFwcGVuLCBhbmQgaXQncyBub3QgYSBxdWVzdGlvbiBvZiB3aGV0aGVyCl9JXyBh bSBnb2luZyB0byBhY2NlcHQgdGhhdCBhcHByb2FjaCBvciBub3QuIFNvIGRvbid0IHRocm93IHRo YXQKYmFjayBvbiBtZSwgcGxlYXNlLgoKSWYgdGhpcyBpcyBzb21ldGhpbmcgdGhhdCB3ZSB3YW50 IHRvIHNvbHZlLCB3ZSBuZWVkIHRvIHN0b3AgYmVpbmcgc28KZGV2aXNpdmUgKHlvdXIgbGFuZ3Vh Z2UgYWJvdmUgaXMgc28pIGFuZCB0cnkgdG8gY29tZSB1cCB3aXRoIGEKc29sdXRpb24gdGhhdCBp cyBhY2NlcHRhYmxlIHRvIGV2ZXJ5b25lLi4uIHRoZSBzd25vZGUgYXBwcm9hY2gKZG9lc24ndCBz ZWVtIHRvIGJlIGl0LgoKLS0gClJNSydzIFBhdGNoIHN5c3RlbTogaHR0cHM6Ly93d3cuYXJtbGlu dXgub3JnLnVrL2RldmVsb3Blci9wYXRjaGVzLwpGVFRQIGlzIGhlcmUhIDgwTWJwcyBkb3duIDEw TWJwcyB1cC4gRGVjZW50IGNvbm5lY3Rpdml0eSBhdCBsYXN0IQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=