From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Fri, 15 Sep 2023 14:05:27 -0700 Subject: [RFC PATCH v12 01/33] KVM: Tweak kvm_hva_range and hva_handler_t to allow reusing for gfn ranges In-Reply-To: References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-2-seanjc@google.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Sep 15, 2023, Xiaoyao Li wrote: > On 9/14/2023 9:54 AM, Sean Christopherson wrote: > > Rework and rename "struct kvm_hva_range" into "kvm_mmu_notifier_range" so > > that the structure can be used to handle notifications that operate on gfn > > context, i.e. that aren't tied to a host virtual address. > > > > Practically speaking, this is a nop for 64-bit kernels as the only > > meaningful change is to store start+end as u64s instead of unsigned longs. > > > > Reviewed-by: Paolo Bonzini > > Signed-off-by: Sean Christopherson > > --- > > virt/kvm/kvm_main.c | 34 +++++++++++++++++++--------------- > > 1 file changed, 19 insertions(+), 15 deletions(-) > > > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > index 486800a7024b..0524933856d4 100644 > > --- a/virt/kvm/kvm_main.c > > +++ b/virt/kvm/kvm_main.c > > @@ -541,18 +541,22 @@ static inline struct kvm *mmu_notifier_to_kvm(struct mmu_notifier *mn) > > return container_of(mn, struct kvm, mmu_notifier); > > } > > -typedef bool (*hva_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); > > +typedef bool (*gfn_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); > > Is it worth mentioning the rename of it as well in changelog? Meh, I suppose. At some point, we do have to assume a certain level of code literacy though :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f73.google.com (mail-oo1-f73.google.com [209.85.161.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E39511CAA for ; Fri, 15 Sep 2023 21:05:30 +0000 (UTC) Received: by mail-oo1-f73.google.com with SMTP id 006d021491bc7-5735a879147so3672736eaf.3 for ; Fri, 15 Sep 2023 14:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694811929; x=1695416729; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=yleJC+7YBNlUjlYVNZzM9vt9cQFuPW3G+hVjyHJnwaw=; b=ZzGYPmW4h6IRzd5JFykSRNIGHirfJB/iF9zOlgSl6t0f2xBasPis2yxBlUuKYuOrRP 7034XroAZCK1K986fJyPDmT0XfN0VfCXnmr+De5fq2EYS3nlVx3I+OokrutGdkunPSzB i0SIPLvgbIUVwbD1o9VDOE2HbpOHOKLjfgdbIZS38zmDndX0P1pTDi7SF5jeSELRTEev pGOWDTmKgLi2qsvqmQyRflswi5P+OdceucMBhLZXDmpdlyMRYNZQo8u6G2E7cQD3Rciw dpsePKmLHYbV3ETeN7Hxz8wKld96Y03mI9sI+GD/Zcrd/FMm0Se1z2nbftuiM3TUp+oj 8kMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694811929; x=1695416729; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yleJC+7YBNlUjlYVNZzM9vt9cQFuPW3G+hVjyHJnwaw=; b=E1J/Dfdu+FoppYya2X1iy0qiIJdeOxhC1ZS40YP7GrHVCffk01JBkQwz+Hkx/FOb60 +fFQFiUxLmRWe8iXZfQaaElfjYK/hayQVK6HPkJP/TQiseIRRTrjUXJWIOUA1MIXNP1u zIhWHPQfti5is15BacZ/FgXmmS3oPMVoU6MdfkPh5YpW5cJlyMKAHB5W8wfaplDTiNcV Ifh+DxbLJksDmwCn/cmIha8mGhvtltBD4dojw5mVc+ussNRjzar02BmgM759rSkRFmW0 rolqfAIC1sS2Xg3wehZ/l50DI5dwl41pZFlJuu2Jer44Ot0sJU6cqKQKYaOfCRzVvTND xUdg== X-Gm-Message-State: AOJu0Yw8fHrB039epIq8KkaNlCQpxk39yus5gcgb6Lu1OJ+ksQSChw8Y a3ZlOmNDbFnlPX1dbh/DVPwC2Of/y+Q= X-Google-Smtp-Source: AGHT+IF9PpTOkzcgimAJrduyF4qwfWt2KP5EbzIhLTMy/s4gm21Ep/5FIgTjRytGlNZlubXZjpDBAQBvLB0= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a4a:2c02:0:b0:571:1762:7718 with SMTP id o2-20020a4a2c02000000b0057117627718mr908496ooo.1.1694811929595; Fri, 15 Sep 2023 14:05:29 -0700 (PDT) Date: Fri, 15 Sep 2023 14:05:27 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-2-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v12 01/33] KVM: Tweak kvm_hva_range and hva_handler_t to allow reusing for gfn ranges From: Sean Christopherson To: Xiaoyao Li Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , Xu Yilun , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" On Fri, Sep 15, 2023, Xiaoyao Li wrote: > On 9/14/2023 9:54 AM, Sean Christopherson wrote: > > Rework and rename "struct kvm_hva_range" into "kvm_mmu_notifier_range" so > > that the structure can be used to handle notifications that operate on gfn > > context, i.e. that aren't tied to a host virtual address. > > > > Practically speaking, this is a nop for 64-bit kernels as the only > > meaningful change is to store start+end as u64s instead of unsigned longs. > > > > Reviewed-by: Paolo Bonzini > > Signed-off-by: Sean Christopherson > > --- > > virt/kvm/kvm_main.c | 34 +++++++++++++++++++--------------- > > 1 file changed, 19 insertions(+), 15 deletions(-) > > > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > index 486800a7024b..0524933856d4 100644 > > --- a/virt/kvm/kvm_main.c > > +++ b/virt/kvm/kvm_main.c > > @@ -541,18 +541,22 @@ static inline struct kvm *mmu_notifier_to_kvm(struct mmu_notifier *mn) > > return container_of(mn, struct kvm, mmu_notifier); > > } > > -typedef bool (*hva_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); > > +typedef bool (*gfn_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); > > Is it worth mentioning the rename of it as well in changelog? Meh, I suppose. At some point, we do have to assume a certain level of code literacy though :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 953A0CD37AA for ; Fri, 15 Sep 2023 21:05:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=rtmydvhN91dS+NhvdBzfmDSK90XsfQW5UKIfMobQl6s=; b=0jiHKzjLYtq/ZyBIUdM9SkH0HI rlCZHh2grp1DnOeJvcPDci597tECAVQsh1zOI0pTwkVS2s1kUjQBt3+kQymPQbzMisJFenM/P1efM 2B23Qzwz+EP1LXqG6WrbMJRYMrlGGYMsiV9A7KMtlUI5w8dwGi0g65W99sEPT1SoPHZEVRsuqsmex QGiA/5dKwNUxXlEBHCxoVjGpy/N9+6M6BqdKfOhSeXS7mkxnUbVOYMeOb19RNeA6x8OFMLyR9aTlL kz1PYVQGnIM9gQJMpfRtEz7K+BpU+kiCvXwnr3oiMiNf2xfMarjiIRSRGI+BjVCeMRQaHhFSzw0Ji qfEQ7M0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qhG0M-00BOEj-20; Fri, 15 Sep 2023 21:05:34 +0000 Received: from mail-oo1-xc4a.google.com ([2607:f8b0:4864:20::c4a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qhG0J-00BOD7-1O for linux-riscv@lists.infradead.org; Fri, 15 Sep 2023 21:05:33 +0000 Received: by mail-oo1-xc4a.google.com with SMTP id 006d021491bc7-5735bb13261so3701516eaf.0 for ; Fri, 15 Sep 2023 14:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694811929; x=1695416729; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=yleJC+7YBNlUjlYVNZzM9vt9cQFuPW3G+hVjyHJnwaw=; b=tR8JkMa8Sg0n63+tNDwhHHPcHH/P1iRqoGw0mQnN0nhfHyPIwcDpujMGdRAa8A3E/1 yZuE8CORSfywVz64RbiQj9X1WTyUr75/r9U80u/6owJMPiUtedPRoR6qEBjdG+x1hf5D PaZrEKHOMhW8OOglVqX32VmlK4el+aIO460hY76/GMSDs4Y/rO73AZQ0w9uptci/hRo8 qO1uuK0FkNmqkKxnY9dqlZm6SuwHVyebewY1JI4YSdHTThnmECMNSPEMhQ5Wp0IBu02H vhvwYf/kmcpSqQDqU9eE1JqFw5UZFMnLhnnQsoMyoQlhb5egT17qLHMAlVQmWpqhzyM2 Cmcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694811929; x=1695416729; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yleJC+7YBNlUjlYVNZzM9vt9cQFuPW3G+hVjyHJnwaw=; b=Hqm5GVNeM0r3Z5aqdgE4aQrlB/k+hBZnbpnQsx21fxjJciSA+Jh8sznnYvgCnCg7v+ jH8VFbh/DBy0wj6wObfx2rLVNUr87LoyUJE+stquLRS/PVoJHF0uvMqwJBnhamz2Ecf8 5cmc/rO8AzppsRoOAdgBMkjTD6JDJRqWgkePmAR99AKxz5rp6/1REbxJSXW588UvehlU 7+/vzjBBhCyjnJ3WuS6b6hRgeLz3LDFhZInCcLPMUdZP6+PxaiUOBylMdO5CGUBLi3H3 vEVtB7ciLgGKxGyIUk4JpwtgiwujRQyqVZDcTluTeAXb224GIa0j5uHqY7nYkGrtcdpk odHw== X-Gm-Message-State: AOJu0Ywntve39MjUBDDkLAOCTpiKdfGsN8CtSOXt0QKfwAqxv9UHmpuN USsVmdaUO4uvAykovzJqAY0+DS/XgNs= X-Google-Smtp-Source: AGHT+IF9PpTOkzcgimAJrduyF4qwfWt2KP5EbzIhLTMy/s4gm21Ep/5FIgTjRytGlNZlubXZjpDBAQBvLB0= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a4a:2c02:0:b0:571:1762:7718 with SMTP id o2-20020a4a2c02000000b0057117627718mr908496ooo.1.1694811929595; Fri, 15 Sep 2023 14:05:29 -0700 (PDT) Date: Fri, 15 Sep 2023 14:05:27 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-2-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v12 01/33] KVM: Tweak kvm_hva_range and hva_handler_t to allow reusing for gfn ranges From: Sean Christopherson To: Xiaoyao Li Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , Xu Yilun , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230915_140531_468613_E0782140 X-CRM114-Status: GOOD ( 16.68 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Sep 15, 2023, Xiaoyao Li wrote: > On 9/14/2023 9:54 AM, Sean Christopherson wrote: > > Rework and rename "struct kvm_hva_range" into "kvm_mmu_notifier_range" so > > that the structure can be used to handle notifications that operate on gfn > > context, i.e. that aren't tied to a host virtual address. > > > > Practically speaking, this is a nop for 64-bit kernels as the only > > meaningful change is to store start+end as u64s instead of unsigned longs. > > > > Reviewed-by: Paolo Bonzini > > Signed-off-by: Sean Christopherson > > --- > > virt/kvm/kvm_main.c | 34 +++++++++++++++++++--------------- > > 1 file changed, 19 insertions(+), 15 deletions(-) > > > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > index 486800a7024b..0524933856d4 100644 > > --- a/virt/kvm/kvm_main.c > > +++ b/virt/kvm/kvm_main.c > > @@ -541,18 +541,22 @@ static inline struct kvm *mmu_notifier_to_kvm(struct mmu_notifier *mn) > > return container_of(mn, struct kvm, mmu_notifier); > > } > > -typedef bool (*hva_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); > > +typedef bool (*gfn_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); > > Is it worth mentioning the rename of it as well in changelog? Meh, I suppose. At some point, we do have to assume a certain level of code literacy though :-) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D82E3CD37AA for ; Fri, 15 Sep 2023 21:06:23 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=Ao+/0aMm; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RnRZ61kzdz3dDr for ; Sat, 16 Sep 2023 07:06:22 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=Ao+/0aMm; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::c49; helo=mail-oo1-xc49.google.com; envelope-from=3gccezqykdogcokxtmqyyqvo.mywvsxehzzm-nofvscdc.yjvklc.ybq@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-oo1-xc49.google.com (mail-oo1-xc49.google.com [IPv6:2607:f8b0:4864:20::c49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RnRY96H0Pz3bbW for ; Sat, 16 Sep 2023 07:05:32 +1000 (AEST) Received: by mail-oo1-xc49.google.com with SMTP id 006d021491bc7-5733fc73957so3695880eaf.1 for ; Fri, 15 Sep 2023 14:05:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694811929; x=1695416729; darn=lists.ozlabs.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=yleJC+7YBNlUjlYVNZzM9vt9cQFuPW3G+hVjyHJnwaw=; b=Ao+/0aMmIfYTa5EQViSctF6XPWZg4qQIQ9mtcjgyJ95CPUJBtpA4FeojsnKJa0QuPr kTdqP66D9/qL6kbCxpRG8I2EtA+u5P5K7CONuvGGJW+1LO0k1W8J6VLDjWIJzQeFn+IA SdTnzdh+YE+6WNtwtBY9JFGQ4gEAhXSVaLcS+10rUyyAG3voHwciDQdcLlptTMvtHk87 dg5kNnTW9Hb9J9Py/hjI95Z+v07H8UZWcBnGCgKMsbZewao9zmGF7E+sCwUY+qLdVRnO Mn9BDjTNyrRGF6a6SoLzOVLgjup01+tg21dUu1LI++JCOuGPbFZUjgG7HVeZ7dwot9qA /GFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694811929; x=1695416729; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yleJC+7YBNlUjlYVNZzM9vt9cQFuPW3G+hVjyHJnwaw=; b=qh3S04ofAYb3SRLb/S+JW1cV3IQbhFsr4z9rxwUBLAJOH2gajOc7rDcDY78aaJa+Cu GfW8FK2Rk5XDNnHiT4N33D1LHOjecu9ZlILAjG7wHQM6lz+dTRsY72lsdvLHYWqY+8Zw +SJ1W1EVVUVoMiO1ebKVt2i31oveMNLs3YaKLIsdBFe/RhvQiOyOKzN/4OFtaFA/T7cX Kw9MjQH8Sdjofj/J9qsXduelfUg4nsDpkby58M4XvdWtOEdVHwBhDgcvop9JI74qo+B1 +dPt52xq+dSY8xznqyOCMYkZ4kp1U5v+IL0pUcJGujXkxfULrrogijJpWqf+Nv/N/CKS HMqQ== X-Gm-Message-State: AOJu0YwksvvbVAw2Voqz/kil52oBk2XHTv+uqI/ruTT19EkKKzhS+l55 OWbSGOgJYywhMb2PnMZ21q9PLs32cCQ= X-Google-Smtp-Source: AGHT+IF9PpTOkzcgimAJrduyF4qwfWt2KP5EbzIhLTMy/s4gm21Ep/5FIgTjRytGlNZlubXZjpDBAQBvLB0= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a4a:2c02:0:b0:571:1762:7718 with SMTP id o2-20020a4a2c02000000b0057117627718mr908496ooo.1.1694811929595; Fri, 15 Sep 2023 14:05:29 -0700 (PDT) Date: Fri, 15 Sep 2023 14:05:27 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-2-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v12 01/33] KVM: Tweak kvm_hva_range and hva_handler_t to allow reusing for gfn ranges From: Sean Christopherson To: Xiaoyao Li Content-Type: text/plain; charset="us-ascii" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, David Hildenbrand , Yu Zhang , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chao Peng , linux-riscv@lists.infradead.org, Isaku Yamahata , Paul Moore , Marc Zyngier , Huacai Chen , James Morris , "Matthew Wilcox \(Oracle\)" , Wang , Fuad Tabba , Jarkko Sakkinen , "Serge E. Hallyn" , Maciej Szmigiero , Albert Ou , Vlastimil Babka , Michael Roth , Ackerley Tng , Paul Walmsley , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Isaku Yamahata , Quentin Perret , Liam Merwick , linux-mips@vger.kernel.org, Oliver Upton , linux-security-module@vger.kernel.org, Palmer Dabbelt , "Kirill A . Shutemov" , kvm-riscv@lists.infradead.org, Anup Patel , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Andrew Morton , Vishal Annapurve , linuxppc-dev@lists.ozlabs.org, Xu Yilun , Anish Moorthy Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Sep 15, 2023, Xiaoyao Li wrote: > On 9/14/2023 9:54 AM, Sean Christopherson wrote: > > Rework and rename "struct kvm_hva_range" into "kvm_mmu_notifier_range" so > > that the structure can be used to handle notifications that operate on gfn > > context, i.e. that aren't tied to a host virtual address. > > > > Practically speaking, this is a nop for 64-bit kernels as the only > > meaningful change is to store start+end as u64s instead of unsigned longs. > > > > Reviewed-by: Paolo Bonzini > > Signed-off-by: Sean Christopherson > > --- > > virt/kvm/kvm_main.c | 34 +++++++++++++++++++--------------- > > 1 file changed, 19 insertions(+), 15 deletions(-) > > > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > index 486800a7024b..0524933856d4 100644 > > --- a/virt/kvm/kvm_main.c > > +++ b/virt/kvm/kvm_main.c > > @@ -541,18 +541,22 @@ static inline struct kvm *mmu_notifier_to_kvm(struct mmu_notifier *mn) > > return container_of(mn, struct kvm, mmu_notifier); > > } > > -typedef bool (*hva_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); > > +typedef bool (*gfn_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); > > Is it worth mentioning the rename of it as well in changelog? Meh, I suppose. At some point, we do have to assume a certain level of code literacy though :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0007CD37AA for ; Fri, 15 Sep 2023 21:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=81pv9ZSx8jTeM11Obv1XNPjL+x+mDu6mKlZkxooj0to=; b=gnh/s1g1WU5YwRMFZ7Y4F2JChZ SvLbxAhjDaih0v8YfktfoRmJHQ4opC4ddUUrjPLjRrvCu9a8Q+Cg+OT1/wneLMkgY4xhnIS+jnXNy dZ98F9noCaSf9Rg6JuxL/v5wdNoBwyUCNrADMO/eDlyZDIor/8xMG0suvQF3inxoS9pkmBS+RECSy Iw648I8kjBe2bofb5yoB52EQlOCHAlHGpdze7WD3uuIgFyxcgYjCABGlI6VVjyyxgI/GKUsJBMZtJ APUv6Xb4sOtqgqa4dnclv3euko8suceCecdKEasiXIDiP3wwLWkYJHp4cgYe7PjNrOfRs80x2gFZ1 oq11iKOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qhG0L-00BOEP-2S; Fri, 15 Sep 2023 21:05:33 +0000 Received: from mail-oo1-xc4a.google.com ([2607:f8b0:4864:20::c4a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qhG0J-00BOD6-13 for linux-arm-kernel@lists.infradead.org; Fri, 15 Sep 2023 21:05:32 +0000 Received: by mail-oo1-xc4a.google.com with SMTP id 006d021491bc7-5712ca11ee6so3680436eaf.2 for ; Fri, 15 Sep 2023 14:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694811929; x=1695416729; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=yleJC+7YBNlUjlYVNZzM9vt9cQFuPW3G+hVjyHJnwaw=; b=tR8JkMa8Sg0n63+tNDwhHHPcHH/P1iRqoGw0mQnN0nhfHyPIwcDpujMGdRAa8A3E/1 yZuE8CORSfywVz64RbiQj9X1WTyUr75/r9U80u/6owJMPiUtedPRoR6qEBjdG+x1hf5D PaZrEKHOMhW8OOglVqX32VmlK4el+aIO460hY76/GMSDs4Y/rO73AZQ0w9uptci/hRo8 qO1uuK0FkNmqkKxnY9dqlZm6SuwHVyebewY1JI4YSdHTThnmECMNSPEMhQ5Wp0IBu02H vhvwYf/kmcpSqQDqU9eE1JqFw5UZFMnLhnnQsoMyoQlhb5egT17qLHMAlVQmWpqhzyM2 Cmcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694811929; x=1695416729; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yleJC+7YBNlUjlYVNZzM9vt9cQFuPW3G+hVjyHJnwaw=; b=AC04yArNYV9n2BjuYN/mPrdwDE7vsNOBoG7vY68cRChRnfIcuGjCNU/A/0OTi3pXSY KEVLgoEC1sosbyLA97Fy1LVXqa0g3o1y5KWRUBSIp4ma17ww0wNQzASARn/0hO1HDaBe Y4uK7lxXLOnfvyf1OHoDw6McUNgq/hPTVtjVCMGZXfHomEyW9eQslWPNYqAorfsnfH8m KjjfBR6VrQSVI/saU/S1URTtGcCwuRy5ShQHCtiAlqAiVvORoyTIQhx1JkTXoBZBzh3R GMJtSsm266E2l+Uuom/3qRTuDJGNbhWzJsxlKO5bMMdmU+gXVb2U4RI1YUdF1sXqV1hN OElA== X-Gm-Message-State: AOJu0YwYR1kblk0l4jEGxro2APzhYBIf1rggV6NfrCu6gIFsw2XMl6QM VMyu6AYCZTcgTRvsHHIe2O/ZihKhJ2s= X-Google-Smtp-Source: AGHT+IF9PpTOkzcgimAJrduyF4qwfWt2KP5EbzIhLTMy/s4gm21Ep/5FIgTjRytGlNZlubXZjpDBAQBvLB0= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a4a:2c02:0:b0:571:1762:7718 with SMTP id o2-20020a4a2c02000000b0057117627718mr908496ooo.1.1694811929595; Fri, 15 Sep 2023 14:05:29 -0700 (PDT) Date: Fri, 15 Sep 2023 14:05:27 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-2-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v12 01/33] KVM: Tweak kvm_hva_range and hva_handler_t to allow reusing for gfn ranges From: Sean Christopherson To: Xiaoyao Li Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , Xu Yilun , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230915_140531_362309_424AAF46 X-CRM114-Status: GOOD ( 18.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 15, 2023, Xiaoyao Li wrote: > On 9/14/2023 9:54 AM, Sean Christopherson wrote: > > Rework and rename "struct kvm_hva_range" into "kvm_mmu_notifier_range" so > > that the structure can be used to handle notifications that operate on gfn > > context, i.e. that aren't tied to a host virtual address. > > > > Practically speaking, this is a nop for 64-bit kernels as the only > > meaningful change is to store start+end as u64s instead of unsigned longs. > > > > Reviewed-by: Paolo Bonzini > > Signed-off-by: Sean Christopherson > > --- > > virt/kvm/kvm_main.c | 34 +++++++++++++++++++--------------- > > 1 file changed, 19 insertions(+), 15 deletions(-) > > > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > index 486800a7024b..0524933856d4 100644 > > --- a/virt/kvm/kvm_main.c > > +++ b/virt/kvm/kvm_main.c > > @@ -541,18 +541,22 @@ static inline struct kvm *mmu_notifier_to_kvm(struct mmu_notifier *mn) > > return container_of(mn, struct kvm, mmu_notifier); > > } > > -typedef bool (*hva_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); > > +typedef bool (*gfn_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); > > Is it worth mentioning the rename of it as well in changelog? Meh, I suppose. At some point, we do have to assume a certain level of code literacy though :-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel