From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABB67C46CA1 for ; Mon, 18 Sep 2023 07:31:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240117AbjIRHbX (ORCPT ); Mon, 18 Sep 2023 03:31:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240342AbjIRHam (ORCPT ); Mon, 18 Sep 2023 03:30:42 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADED9129; Mon, 18 Sep 2023 00:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695022226; x=1726558226; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nEHYuNO2Tri2ErH9EU6gTZpEDiK3nEfVaAIgLoF4k/A=; b=ddaP/uzuINxViNHD5kMu3D8vu+8eUTHEYbUhDDGhfsMUi+9RKnsw1v2D c2kAOckkSQvr+HFzFrFnJyqwb7l94Yyv+MKbVHNk4Itp0RmnR7q7wWhaF WToqZUoSIPNtPiU94cu5/wAMUMhKuWwAqP391290AXP9ja+SsVMM7NHQS 10zlskBtuugVaCNQ1hQfvT36CuPgiuflqKp74RB/QQ6dhqWEnEmtOxdnj L0tGIrYNyL6fy89Esr/PxY7Arb+Um6JeXwedWzXw8sSFYs9UNXkBOYSn4 KwlfQfLgGVjZuBtvKddTap5DEskJB+VVHVFVzYtZqqi+cuyg4LitH+sN+ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="359003954" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="359003954" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 00:28:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="860949152" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="860949152" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 00:27:53 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qi8fd-0000000EYoE-3dJF; Mon, 18 Sep 2023 10:27:49 +0300 Date: Mon, 18 Sep 2023 10:27:49 +0300 From: Andy Shevchenko To: nikita.shubin@maquefel.me Cc: Hartley Sweeten , Alexander Sverdlin , Russell King , Dmitry Torokhov , Jonathan Cameron , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Sergey Shtylyov , Damien Le Moal , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH v4 30/42] input: keypad: ep93xx: add DT support for Cirrus EP93xx Message-ID: References: <20230915-ep93xx-v4-0-a1d779dcec10@maquefel.me> <20230915-ep93xx-v4-30-a1d779dcec10@maquefel.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915-ep93xx-v4-30-a1d779dcec10@maquefel.me> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Fri, Sep 15, 2023 at 11:11:12AM +0300, Nikita Shubin via B4 Relay wrote: > From: Nikita Shubin > > - drop flags, they were not used anyway > - add OF ID match table > - process "autorepeat", "debounce-delay-ms", prescale from device tree > - drop platform data usage and it's header > - keymap goes from device tree now on ... > #include > #include > +#include Is this correct header? Shouldn't be property.h? > #include > +#include Can you. please, try to squeeze them to most ordered parts? > #include > #include -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 335DDCD13D1 for ; Mon, 18 Sep 2023 07:28:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LoeAYeiwViCol/i3inUdMWbNmH82p1tvQHlq25ePuIc=; b=hrJ5Urvk/84Bg+ fqbGaI5Sn06Ex6LXYe+SfpsAK/bRHLuwabX1Z/A7+ZOvVMW2TsB3TA7mfWfcJEL+n66Ji1BQrgqGl NLwDJTQ7nuVhCPqOZ0zaWVaBORIEghTD7MF+BbYe3A0rpP7yK1MpuNw3fxnSQNn1ifNP5EhL3NNYe RnW09mpV0230uEJIyGwko5km/AcaEFNxOlosg7NoHatakhW/u5l0uC19ysWcJouo8KAs4ySJoHm7K 8A7J+wuo3dbcPREkMZc2wMgHhfwE4NXHyIpUKHjnim4TjOZwlfqZo6bLqqF5CdXALU0XhDoNyVyHe hzFMz1xSOKPN9cH47qoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qi8fz-00EgkM-0o; Mon, 18 Sep 2023 07:28:11 +0000 Received: from mgamail.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qi8fw-00Egjf-1w for linux-arm-kernel@lists.infradead.org; Mon, 18 Sep 2023 07:28:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695022088; x=1726558088; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nEHYuNO2Tri2ErH9EU6gTZpEDiK3nEfVaAIgLoF4k/A=; b=FA/+gf19hgmLft8WthomIGHI6popyPWlMpflsl3batdK8sQ4JChdvQtv bO9rroLg3HZ7uhz34nnzGmapeHhuDZDIojT7Hjn5CZlP0ytRNjxgGrO+S Fkevag+z97rksqYPf6pmwmKz82r0DOK2ez7ztbOR3H/5IgysKkfn4pdXd tyZvBHeYxPDt9cSdLrX7phCvpOAdyOG/T2QC1DgTKi2ROb/6tR+0P1RPh opSO906LWvIKKOeCyVwRmg9AlsZPueA4KyPXjicK0XspuJPFioTXdpYFp 3+WKzHPirR3BlXg7ZmBnYLxTVzX4N77797TAcTmTHC/TGfFu1RsPiVBvq Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="359003955" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="359003955" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 00:28:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="860949152" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="860949152" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 00:27:53 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qi8fd-0000000EYoE-3dJF; Mon, 18 Sep 2023 10:27:49 +0300 Date: Mon, 18 Sep 2023 10:27:49 +0300 From: Andy Shevchenko To: nikita.shubin@maquefel.me Cc: Hartley Sweeten , Alexander Sverdlin , Russell King , Dmitry Torokhov , Jonathan Cameron , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Sergey Shtylyov , Damien Le Moal , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH v4 30/42] input: keypad: ep93xx: add DT support for Cirrus EP93xx Message-ID: References: <20230915-ep93xx-v4-0-a1d779dcec10@maquefel.me> <20230915-ep93xx-v4-30-a1d779dcec10@maquefel.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230915-ep93xx-v4-30-a1d779dcec10@maquefel.me> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230918_002808_653089_48AAA1B9 X-CRM114-Status: GOOD ( 12.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 15, 2023 at 11:11:12AM +0300, Nikita Shubin via B4 Relay wrote: > From: Nikita Shubin > > - drop flags, they were not used anyway > - add OF ID match table > - process "autorepeat", "debounce-delay-ms", prescale from device tree > - drop platform data usage and it's header > - keymap goes from device tree now on ... > #include > #include > +#include Is this correct header? Shouldn't be property.h? > #include > +#include Can you. please, try to squeeze them to most ordered parts? > #include > #include -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel