From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Pearson <mpearson-lenovo@squebb.ca>,
markgross@kernel.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: think-lmi: Add bulk save feature
Date: Mon, 18 Sep 2023 17:39:56 +0300 [thread overview]
Message-ID: <ZQhhPJsQapKkY39v@smile.fi.intel.com> (raw)
In-Reply-To: <878da778-e183-6ef5-61ce-3a3d059f1a1e@redhat.com>
On Mon, Sep 18, 2023 at 04:07:53PM +0200, Hans de Goede wrote:
> On 9/18/23 15:57, Andy Shevchenko wrote:
> > On Wed, Sep 06, 2023 at 08:13:14AM -0400, Mark Pearson wrote:
...
> >> +static const char * const save_mode_strings[] = {
> >> + [TLMI_SAVE_SINGLE] = "single",
> >> + [TLMI_SAVE_BULK] = "bulk",
> >> + [TLMI_SAVE_SAVE] = "save"
> >
> > Missing comma.
>
> Fixing this retro-actively is not really useful, if we
> ever need an extra entry we can deal with the churn then.
I agree, but this is to give a comprehensive review as long as I went through
the entire change.
> >> +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-18 16:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 12:13 [PATCH v2] platform/x86: think-lmi: Add bulk save feature Mark Pearson
2023-09-13 16:40 ` Hans de Goede
2023-09-18 13:57 ` Andy Shevchenko
2023-09-18 14:00 ` Andy Shevchenko
2023-09-18 16:25 ` Joe Perches
2023-09-18 14:07 ` Hans de Goede
2023-09-18 14:38 ` Andy Shevchenko
2023-09-18 16:22 ` Joe Perches
2023-09-18 14:39 ` Andy Shevchenko [this message]
2023-09-18 15:23 ` Mark Pearson
2023-09-19 8:32 ` Hans de Goede
-- strict thread matches above, loose matches on Subject: below --
2023-09-19 14:15 Mark Pearson
2023-09-21 16:38 ` Hans de Goede
2023-09-21 17:43 ` Mark Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQhhPJsQapKkY39v@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.