From: Matthew Wilcox <willy@infradead.org>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: syzbot <syzbot+c225dea486da4d5592bd@syzkaller.appspotmail.com>,
akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
llvm@lists.linux.dev, mike.kravetz@oracle.com,
muchun.song@linux.dev, nathan@kernel.org,
ndesaulniers@google.com, syzkaller-bugs@googlegroups.com,
trix@redhat.com
Subject: Re: [syzbot] [fs?] [mm?] WARNING in page_copy_sane
Date: Mon, 18 Sep 2023 19:18:31 +0100 [thread overview]
Message-ID: <ZQiUd5FAtPXP3OC8@casper.infradead.org> (raw)
In-Reply-To: <d576d53b-bce4-21d3-fddd-0e26e9b44f89@oracle.com>
On Mon, Sep 18, 2023 at 01:10:21PM -0500, Sidhartha Kumar wrote:
> @@ -382,8 +382,8 @@ static ssize_t hugetlbfs_read_iter(struct kiocb *iocb, struct iov_iter *to)
> /*
> * We have the page, copy it to user space buffer.
> */
> - copied = copy_page_to_iter(page, offset, want, to);
> - put_page(page);
> + copied = copy_page_to_iter(&folio->page, offset, want, to);
copy_folio_to_iter() please. Yes, I know it's just a wrapper today.
> + folio_put(folio);
> }
> offset += copied;
> retval += copied;
> --
> 2.41.0
>
next prev parent reply other threads:[~2023-09-18 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 4:41 [syzbot] [fs?] [mm?] WARNING in page_copy_sane syzbot
2023-09-18 18:10 ` Sidhartha Kumar
2023-09-18 18:18 ` Matthew Wilcox [this message]
2023-09-18 18:36 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQiUd5FAtPXP3OC8@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sidhartha.kumar@oracle.com \
--cc=syzbot+c225dea486da4d5592bd@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.