From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08A80CD54A9 for ; Tue, 19 Sep 2023 08:50:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230048AbjISIui (ORCPT ); Tue, 19 Sep 2023 04:50:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbjISIuh (ORCPT ); Tue, 19 Sep 2023 04:50:37 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC4E2E6 for ; Tue, 19 Sep 2023 01:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695113390; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YqVpnSaiSEnj5t3sFQADAP/SKxCVOo7WDMjFLFuQemk=; b=V6tmMgSEn0lw2cKMzdeBNWum3OE8IAjDOWsad7Qqr/W7w/mssh1snfIb7YWVYw0T8O1DzR ZbAgxy3AWZSQG99DAbErKLqcFPLS0DgSBTmBMAl1nx7U2oiXN2PfnMMSeu0A1bfmj+gpl0 Vl2YtvlYF4lkM8wkhH52+f6jGvtKanQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-161-_N9ua4G7Pl6CnVIhPOJFMQ-1; Tue, 19 Sep 2023 04:49:46 -0400 X-MC-Unique: _N9ua4G7Pl6CnVIhPOJFMQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2ADD7811E7D; Tue, 19 Sep 2023 08:49:46 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 00C3E140E964; Tue, 19 Sep 2023 08:49:44 +0000 (UTC) Date: Tue, 19 Sep 2023 09:49:42 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: Stephen Brennan , qemu-devel@nongnu.org, linux-debuggers@vger.kernel.org, Omar Sandoval , Thomas Huth Subject: Re: [PATCH v3 qemu 0/3] Allow dump-guest-memory to output standard kdump format Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20230918233233.1431858-1-stephen.s.brennan@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-debuggers@vger.kernel.org On Tue, Sep 19, 2023 at 11:53:49AM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Sep 19, 2023 at 3:32 AM Stephen Brennan > wrote: > > > > Hello all, > > > > This is the third version of the kdump patch series, the first and > > second revisions being visible at [1] and [2] respectively. You can see > > the history and motivation for the patch series described in the cover > > letter of [2]. > > > > Thank you for your continued feedback and review. > > Stephen > > > > Changes from v2 to v3: > > - Rather than use "reassembled" flag in QMP API, represent each kdump > > format "kdump-X" with a new enumerator "kdump-raw-X". (The HMP > > interface retains the -R option) > > - Return an error if the file descriptor passed in is not seekable, yet > > the requested dump format is kdump-raw-* > > > > Changes from v1 to v2: > > - Keep the default as the flattened format > > - Add QMP / HMP arguments for "reassembled" > > > > [1]: https://lore.kernel.org/qemu-devel/20230717163855.7383-1-stephen.s.brennan@oracle.com/ > > [2]: https://lore.kernel.org/qemu-devel/20230914010315.945705-1-stephen.s.brennan@oracle.com/ > > > > Stephen Brennan (3): > > dump: Pass DumpState to write_ functions > > dump: Allow directly outputting raw kdump format > > dump: Add command interface for kdump-raw formats > > > > dump/dump-hmp-cmds.c | 21 +++++++-- > > dump/dump.c | 99 +++++++++++++++++++++++++++++++------------ > > hmp-commands.hx | 9 +++- > > include/sysemu/dump.h | 3 +- > > qapi/dump.json | 24 +++++++++-- > > 5 files changed, 119 insertions(+), 37 deletions(-) > > > > -- > > 2.39.3 > > > > For the series: > Reviewed-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|