From: Sean Christopherson <seanjc@google.com>
To: Hao Peng <flyingpenghao@gmail.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: X86: Use octal for file permission
Date: Tue, 19 Sep 2023 08:06:03 -0700 [thread overview]
Message-ID: <ZQm425xPc/8wHXup@google.com> (raw)
In-Reply-To: <CAPm50aKVDLhZo_3kkKyC9AUN0BGrYnPTo9hGqRg1M3TsUQQMSw@mail.gmail.com>
KVM: x86: (don't capitalize the 'x')
On Tue, Sep 19, 2023, Hao Peng wrote:
> From: Peng Hao <flyingpeng@tencent.com>
>
> Improve code readability and checkpatch warnings:
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
> using octal permissions '0444'.
>
> Signed-off-by: Peng Hao <flyingpeng@tencent.com>
> ---
> arch/x86/kvm/x86.c | 18 +++++++++---------
If we're going to do this, let's do all of x86/kvm in one patch, i.e. clean up
VMX and SVM too.
I generally don't like checkpatch-initiated cleanups, but I vote to go ahead with
this one. I look at the params just often enough that not having to parse the
#defines would add real value for me.
Any objections?
prev parent reply other threads:[~2023-09-19 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 14:30 [PATCH] KVM: X86: Use octal for file permission Hao Peng
2023-09-19 15:06 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQm425xPc/8wHXup@google.com \
--to=seanjc@google.com \
--cc=flyingpenghao@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.