All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Thomas Haller <thaller@redhat.com>
Cc: NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft 1/1] datatype: explicitly set missing datatypes for TYPE_CT_LABEL,TYPE_CT_EVENTBIT
Date: Tue, 19 Sep 2023 18:20:05 +0200	[thread overview]
Message-ID: <ZQnKNVCgwbmRTMaD@calendula> (raw)
In-Reply-To: <38547bfa61da64801d1cb79f757b40ca1e0c44f4.camel@redhat.com>

On Tue, Sep 19, 2023 at 02:30:38PM +0200, Thomas Haller wrote:
> On Tue, 2023-09-19 at 14:18 +0200, Pablo Neira Ayuso wrote:
> > Hi Thomas,
> > 
> > On Tue, Sep 19, 2023 at 01:28:03PM +0200, Thomas Haller wrote:
> > > It's not obvious that two enum values are missing (or why).
> > > Explicitly
> > > set the values to NULL, so we can see this more easily.
> > 
> > I think this is uncovering a bug with these selectors.
> > 
> > When concatenations are used, IIRC the delinerize path needs this.
> > 
> > TYPE_CT_EVENTBIT does not need this, because this is a statement to
> > globally filter ctnetlink events events.
> > 
> > But TYPE_CT_LABEL is likely not working fine with concatenations.
> > 
> > Let me take a closer look.
> 
> Hi Pablo,
> 
> Thank you.
> 
> FYI, I have a patch with a unit test that performs some consistency
> checks of the "datatypes" array. Only TYPE_CT_LABEL + TYPE_CT_EVENTBIT
> are missing.
>
> You don't need to write a test about that. The test is however on top
> of  "no recursive make" patches, which I will resent at a later time.

Thanks, I posted the fixes without unit tests:

https://patchwork.ozlabs.org/project/netfilter-devel/patch/20230919161254.640998-1-pablo@netfilter.org/
https://patchwork.ozlabs.org/project/netfilter-devel/patch/20230919161825.643827-1-pablo@netfilter.org/


      reply	other threads:[~2023-09-19 16:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19 11:28 [PATCH nft 1/1] datatype: explicitly set missing datatypes for TYPE_CT_LABEL,TYPE_CT_EVENTBIT Thomas Haller
2023-09-19 12:18 ` Pablo Neira Ayuso
2023-09-19 12:30   ` Thomas Haller
2023-09-19 16:20     ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQnKNVCgwbmRTMaD@calendula \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=thaller@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.