From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B019BC04AAF for ; Wed, 20 Sep 2023 16:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234500AbjITQqR (ORCPT ); Wed, 20 Sep 2023 12:46:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234174AbjITQqR (ORCPT ); Wed, 20 Sep 2023 12:46:17 -0400 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9ABA4AD for ; Wed, 20 Sep 2023 09:46:11 -0700 (PDT) Received: from [78.30.34.192] (port=39668 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qj0L1-004jmx-TH; Wed, 20 Sep 2023 18:46:09 +0200 Date: Wed, 20 Sep 2023 18:46:07 +0200 From: Pablo Neira Ayuso To: Thomas Haller Cc: NetFilter Subject: Re: [PATCH nft 8/9] datatype: use __attribute__((packed)) instead of enum bitfields Message-ID: References: <20230920142958.566615-1-thaller@redhat.com> <20230920142958.566615-9-thaller@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230920142958.566615-9-thaller@redhat.com> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Sep 20, 2023 at 04:26:09PM +0200, Thomas Haller wrote: > diff --git a/include/proto.h b/include/proto.h Not related, but this reminds me, there are duplicated protocol header definitions in include/proto.h that can possibly go away by using libc definitions.