From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Wed, 20 Sep 2023 14:03:49 -0700 Subject: [RFC PATCH v12 11/33] KVM: Introduce per-page memory attributes In-Reply-To: References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-12-seanjc@google.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Sep 18, 2023, Binbin Wu wrote: > > > On 9/14/2023 9:55 AM, Sean Christopherson wrote: > > From: Chao Peng > [...] > > +#ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES > > +/* > > + * Returns true if _all_ gfns in the range [@start, @end) have attributes > > + * matching @attrs. > > + */ > > +bool kvm_range_has_memory_attributes(struct kvm *kvm, gfn_t start, gfn_t end, > > + unsigned long attrs) > > +{ > > + XA_STATE(xas, &kvm->mem_attr_array, start); > > + unsigned long index; > > + bool has_attrs; > > + void *entry; > > + > > + rcu_read_lock(); > > + > > + if (!attrs) { > > + has_attrs = !xas_find(&xas, end); > IIUIC, xas_find() is inclusive for "end", so here should be "end - 1" ? Yes, that does appear to be the case. Inclusive vs. exclusive on gfn ranges has is the bane of my existence. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6259741AB9 for ; Wed, 20 Sep 2023 21:03:51 +0000 (UTC) Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-1c4375c1406so1910575ad.1 for ; Wed, 20 Sep 2023 14:03:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695243831; x=1695848631; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QFTXI1M20f8gmG6BvRAdcxEpoXePrbyr+CokqbvWBWc=; b=hdOxi9vpDQQNpQN1GvkSkDJmgddrXY3jHZW6oYl2MErNPecSsTdxIG9mWSJyU1X5Y/ EgzcNtcKPV2AxVzZMb+uHzp9eRX5DCUDjp/TkB3nNT9JkFS3UXUtxUsijI+cl1s84SWe aM09glxzEaEo/LY4ZGRwnE+ll85rbSxwFGCNAEPoawGKHQLSSuMXmmsvWXTkxZPzSE63 ntzpmkwyF7Wyl/PR/ualFk/qQ7+YKZjVok5t5ytTJjdzwxkYrRQzE7o3ss8gCdw3mMBA fgVrf1cHpXLqnQ5uxG1dKelZfQKpcS5akxxhPh7eiDbmQLSm8GwlTRSAydj4mWkPCeBD AnNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695243831; x=1695848631; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QFTXI1M20f8gmG6BvRAdcxEpoXePrbyr+CokqbvWBWc=; b=hNhu92EKtvFq5AqXnGawUSW4kCWWyRbS98nXXo7OykQOztbsQLzz0U6ftfhJnYmyhN jSeEtnKsM4jeEaJtDDBwWX6A6L8L8FXtqO8psegoj1nSc+bhllmaRELRfN7B5iLjesdd BYutXZhncS3R1rnJL3HJqebAKXNTs8VkD14UU5Ze0l4z77a/5112c6GxGyed2LmyjrTK 7K1oVC8dKkmmCZ2qOR3WtoSdpuez8i3OVNKQJKEEGH7dd6tDrQDplPI8Wvy9Ey/lqiAY a7MCFVtpIps8gNYQzfBjDpMOTN/QV5oSsukPHccYNLt9SoArV002eKUAZa0CJO9rU3Jb kZzg== X-Gm-Message-State: AOJu0YzBqIVcXNXgEO6V5Fj8Lja+bknqMOZ57ZIIxUe9kmA1Hm98YCZC x7OuZpHZoF4Vx32eELjgbQ/bUhSUQMk= X-Google-Smtp-Source: AGHT+IH5QBEwnaGAG6ouJVZQG2FiwG4z7ywKiDhgLSOOF+0VMXfLus6G3HR8pg7XpQjZrIgu3wnPZ1Tf/l8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:c407:b0:1c3:411c:9b7c with SMTP id k7-20020a170902c40700b001c3411c9b7cmr51568plk.13.1695243830643; Wed, 20 Sep 2023 14:03:50 -0700 (PDT) Date: Wed, 20 Sep 2023 14:03:49 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-12-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v12 11/33] KVM: Introduce per-page memory attributes From: Sean Christopherson To: Binbin Wu Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , Xu Yilun , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" On Mon, Sep 18, 2023, Binbin Wu wrote: > > > On 9/14/2023 9:55 AM, Sean Christopherson wrote: > > From: Chao Peng > [...] > > +#ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES > > +/* > > + * Returns true if _all_ gfns in the range [@start, @end) have attributes > > + * matching @attrs. > > + */ > > +bool kvm_range_has_memory_attributes(struct kvm *kvm, gfn_t start, gfn_t end, > > + unsigned long attrs) > > +{ > > + XA_STATE(xas, &kvm->mem_attr_array, start); > > + unsigned long index; > > + bool has_attrs; > > + void *entry; > > + > > + rcu_read_lock(); > > + > > + if (!attrs) { > > + has_attrs = !xas_find(&xas, end); > IIUIC, xas_find() is inclusive for "end", so here should be "end - 1" ? Yes, that does appear to be the case. Inclusive vs. exclusive on gfn ranges has is the bane of my existence. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49D48C27C7B for ; Wed, 20 Sep 2023 21:04:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=PBPZm6J/Z/jpvFYI/XXDwJe0heKQXG8Qu/TpM/H+f1w=; b=V9hqSR17EwUguZ4g30uky69RRj 5AfRk/InqIsCjqKrt11HIbfQnwtnuvox0y38KNXT2UB3hHwalOI2u6ogSmGzFb5EE6IszD8vRoeHR B+pVytI3McooTJ/8IpxXjS/NGOHQD3frZ3pCTl6d46CR4bScoEq6xISt4qRKwgciABYb9gHW+WYfh SRMADC/tatSTESiTHhAlVU0pyS0HVNsvmU9rRhlrc8IcGC9cNAI3AyIKrR4ofyYzAw+AABydMDBqC XWXWh3ze4RS5VrqMphY07hPHNepB+V/tWwX/W8m9vhMKpnTw0/KE43t4Jtv9M88VDnR7vmxHAvudP fzlDwk7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qj4MX-004DNH-1o; Wed, 20 Sep 2023 21:03:57 +0000 Received: from mail-pl1-x649.google.com ([2607:f8b0:4864:20::649]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qj4MT-004DJW-07 for linux-riscv@lists.infradead.org; Wed, 20 Sep 2023 21:03:55 +0000 Received: by mail-pl1-x649.google.com with SMTP id d9443c01a7336-1c577fea3dcso1840575ad.2 for ; Wed, 20 Sep 2023 14:03:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695243831; x=1695848631; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QFTXI1M20f8gmG6BvRAdcxEpoXePrbyr+CokqbvWBWc=; b=Eac45T6a64OuRp9mWBK8Mj1pihqW3BUD6aunWputlsg65DvVwSo6q7Fp4zUdHjgRvX Ty5tJo7WIPCXKNb+uBGjTeYSpj3lVbPVROtqrL61eyJh1d7j5/bM0YoqSWLUu+GfIBqz +ynp1xNk4PbS1+61noK0JRC2L+wnMqcs1DgVlsN9XpE1Vrk8SsWhW8kdo54I9xLGZpeW iiOCTR59U8Lxp6sYmzPjTLcfYTOPYZdGctQQ+OZKHVU3e7yaAX8DTnLlmtlVcitfPW13 fXvA6DBOMLQ74SaUsnPJSZrFHlA87ICWhHP0U46Sn82qn5xHPzEOTwvJLYsB0EaQPb41 FvEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695243831; x=1695848631; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QFTXI1M20f8gmG6BvRAdcxEpoXePrbyr+CokqbvWBWc=; b=c3KLNzbSkEQOs+nB4fESv+cHZ/NbMbGgZ4589Qqrf8KGWXaJgvVWLn+B90EuOGZLoW Y36YY58U8W5AHaQcwV4qxtKkybGkXNDGFlJLXXyZd+Rm18VAN8Q+0413r0pWUkbJQyDw Ws7mu0b1OoTRbL0K9qp9cd8Y3cRQlvJVH10Vs/VkpJAbpbfALmGu11SXfkpbqyLH03VC E/rnJNBiLlxmTpiLGUVi7zZjxul6mWWcupz/dwQHlXxV7dNU1mEgscOlWUSjVFmWRHos 9T1p1iFZJpDMKC5QLYdsn8PCRVDBgxhf5KE7KF9DdfEOP5j4Cw8tlmGLYf2E7o76HAyY yVPQ== X-Gm-Message-State: AOJu0Yztpy+yyeDD+fcb3Dq3iruS2UdkdKypKN7Y7+KHT/7vgLe+dHMU zNtlVEB118yMJOCjwCkYUztDKOSwIYo= X-Google-Smtp-Source: AGHT+IH5QBEwnaGAG6ouJVZQG2FiwG4z7ywKiDhgLSOOF+0VMXfLus6G3HR8pg7XpQjZrIgu3wnPZ1Tf/l8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:c407:b0:1c3:411c:9b7c with SMTP id k7-20020a170902c40700b001c3411c9b7cmr51568plk.13.1695243830643; Wed, 20 Sep 2023 14:03:50 -0700 (PDT) Date: Wed, 20 Sep 2023 14:03:49 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-12-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v12 11/33] KVM: Introduce per-page memory attributes From: Sean Christopherson To: Binbin Wu Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , Xu Yilun , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230920_140353_076667_541F3336 X-CRM114-Status: GOOD ( 12.06 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Sep 18, 2023, Binbin Wu wrote: > > > On 9/14/2023 9:55 AM, Sean Christopherson wrote: > > From: Chao Peng > [...] > > +#ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES > > +/* > > + * Returns true if _all_ gfns in the range [@start, @end) have attributes > > + * matching @attrs. > > + */ > > +bool kvm_range_has_memory_attributes(struct kvm *kvm, gfn_t start, gfn_t end, > > + unsigned long attrs) > > +{ > > + XA_STATE(xas, &kvm->mem_attr_array, start); > > + unsigned long index; > > + bool has_attrs; > > + void *entry; > > + > > + rcu_read_lock(); > > + > > + if (!attrs) { > > + has_attrs = !xas_find(&xas, end); > IIUIC, xas_find() is inclusive for "end", so here should be "end - 1" ? Yes, that does appear to be the case. Inclusive vs. exclusive on gfn ranges has is the bane of my existence. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13B19C05025 for ; Wed, 20 Sep 2023 21:04:45 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=ig6HgbWP; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RrWHv5Cp8z3cRg for ; Thu, 21 Sep 2023 07:04:43 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=ig6HgbWP; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::649; helo=mail-pl1-x649.google.com; envelope-from=3nl4lzqykde89vr40tx55x2v.t532z4be66t-uvc2z9a9.5g2rs9.58x@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RrWGx3WzPz307h for ; Thu, 21 Sep 2023 07:03:53 +1000 (AEST) Received: by mail-pl1-x649.google.com with SMTP id d9443c01a7336-1c4375c1406so1910555ad.1 for ; Wed, 20 Sep 2023 14:03:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695243830; x=1695848630; darn=lists.ozlabs.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QFTXI1M20f8gmG6BvRAdcxEpoXePrbyr+CokqbvWBWc=; b=ig6HgbWPR5QsMZ3/GFuqUggEcB8oHt9PM/X5y3ybtNQkGkosRu0R+ToUoPhaoIEQk1 q59E+4h+RqhGjwoXebuWWjG5IuMt4tA2Y3U3wr9Z+jimNTOOjglWRI5CQZMeWmiviPnp UKiS0ZghzAdQHfzVpPPRuYNc0Gm4kYckd2I6vMqagGbHaX0menmD+OySTQn1M8c9fdPn iVmx0i9MA2LWbJ5XZ2dPYw1hnN0JOidS5JD3dkp0jreY7KtCiO1MHr0/THtebChynUcx sMBRU9IvuWjK9GCnwL4yrwkWQFjDzFbLXqv2zsrCEiN4eH5FkLy7dZr/47sYDAiirJ19 YzZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695243830; x=1695848630; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QFTXI1M20f8gmG6BvRAdcxEpoXePrbyr+CokqbvWBWc=; b=pd+Posh2mYB3SLbuvq9fVoUAy49DADdFkTQKXrHR7jsjQ80jnXjCB4zVanCDWDlzvD k8cGiIJB2mf/JylP+Ysymt1dlznZlglTS+D4dCJQI29CAbqJnkA0R8qHovahQtQIJgCY Qn60C32eqMobjvOR+7oDzRV4X5xWBC+G32gc+eez16IXFQJ4Q2wxkspFC9jb3KYGwiDB HImKLxIFejqdBn/+ME/kHaRGYCyWXWoO0t3Z8PMWTMAHYpG/mwLwiPYjWRg8XohzDRpL II4FTfkDl9q3uRwrhsjAi51/TTxlhKUbWOBNzxMJkRJNCJSWQVCh03JUKlLhBHHMjH6y JKqg== X-Gm-Message-State: AOJu0YzQO612/TOb5nxmI/WIfmlbkL6ojX+cdygloLAHYuddkwbNKwfC nKRHC/oKNRAmWy0qqmXaiPZ/d8TZLvA= X-Google-Smtp-Source: AGHT+IH5QBEwnaGAG6ouJVZQG2FiwG4z7ywKiDhgLSOOF+0VMXfLus6G3HR8pg7XpQjZrIgu3wnPZ1Tf/l8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:c407:b0:1c3:411c:9b7c with SMTP id k7-20020a170902c40700b001c3411c9b7cmr51568plk.13.1695243830643; Wed, 20 Sep 2023 14:03:50 -0700 (PDT) Date: Wed, 20 Sep 2023 14:03:49 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-12-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v12 11/33] KVM: Introduce per-page memory attributes From: Sean Christopherson To: Binbin Wu Content-Type: text/plain; charset="us-ascii" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, David Hildenbrand , Yu Zhang , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chao Peng , linux-riscv@lists.infradead.org, Isaku Yamahata , Paul Moore , Marc Zyngier , Huacai Chen , James Morris , "Matthew Wilcox \(Oracle\)" , Wang , Fuad Tabba , Jarkko Sakkinen , "Serge E. Hallyn" , Maciej Szmigiero , Albert Ou , Vlastimil Babka , Michael Roth , Ackerley Tng , Paul Walmsley , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Isaku Yamahata , Quentin Perret , Liam Merwick , linux-mips@vger.kernel.org, Oliver Upton , linux-security-module@vger.kernel.org, Palmer Dabbelt , "Kirill A . Shutemov" , kvm-riscv@lists.infradead.org, Anup Patel , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Andrew Morton , Vishal Annapurve , linuxppc-dev@lists.ozlabs.org, Xu Yilun , Anish Moorthy Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Sep 18, 2023, Binbin Wu wrote: > > > On 9/14/2023 9:55 AM, Sean Christopherson wrote: > > From: Chao Peng > [...] > > +#ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES > > +/* > > + * Returns true if _all_ gfns in the range [@start, @end) have attributes > > + * matching @attrs. > > + */ > > +bool kvm_range_has_memory_attributes(struct kvm *kvm, gfn_t start, gfn_t end, > > + unsigned long attrs) > > +{ > > + XA_STATE(xas, &kvm->mem_attr_array, start); > > + unsigned long index; > > + bool has_attrs; > > + void *entry; > > + > > + rcu_read_lock(); > > + > > + if (!attrs) { > > + has_attrs = !xas_find(&xas, end); > IIUIC, xas_find() is inclusive for "end", so here should be "end - 1" ? Yes, that does appear to be the case. Inclusive vs. exclusive on gfn ranges has is the bane of my existence. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56B7FC05025 for ; Wed, 20 Sep 2023 21:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=O6Luv2Zt/TCI2U7QO6acytKEPYvHcNsCL/FuLERcrps=; b=0OrFvJCd9KITDBFxP2zhq44q3H M5Co2wnlKc3rtJ/ROqurAD77aZvlNG4e49o2nyOvQwSeIEmfrRfh5MZ3nW14PAZjEAe2AmoBO0/m3 ud4hEFsVF/Lq7HXxmOeaQKRvfvG4+Oo3asBTfmrIamBRAXeTL6n/p+qFvJecIRLBrEUY3RwACB9AT AGANNVbWfh6HBwG2O3/p0rfnhanB5ZDGsdQGMX84r0aVJ8+NfWtWhnI0mdG7cSBaF3brcCmaziJWA J5mqa9JkDyxBcI/q3EeZwBZi3DKbkftr7rqmhliYJ9XxCVaCUu2aR1cpqzKDL3vm4q2+49IiEvRUk 15T6WQFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qj4MX-004DN8-03; Wed, 20 Sep 2023 21:03:57 +0000 Received: from mail-pl1-x649.google.com ([2607:f8b0:4864:20::649]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qj4MT-004DJR-07 for linux-arm-kernel@lists.infradead.org; Wed, 20 Sep 2023 21:03:55 +0000 Received: by mail-pl1-x649.google.com with SMTP id d9443c01a7336-1c448ba292dso1833905ad.3 for ; Wed, 20 Sep 2023 14:03:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695243830; x=1695848630; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QFTXI1M20f8gmG6BvRAdcxEpoXePrbyr+CokqbvWBWc=; b=I5qTKbcYogYoCX5R4GsrkIKSmblmgYmC2WbbNnsi5ajueBGrk6fStU2BRMv/EkNyHh euavse/28IhfKNyBKgW0bQ6TJHbJmjbxARNFhuKsY4XSWUeQ3ZWP8fqdkr2IJgzOZ7la Y6XY7ApbFwkEKf6W0nMePuX6i51mZgIdUGHX3uwiE0BxjbvVoNuyTrQpKkgdWthjKjmx 3zXuoqpsqUlOe/j5lSHtqBGy8wwOSWqAy7pELB86fA3LoEPDadYIxvrhJlIAKTNxrHFB Qy2dyQMkm9d5SpxkMaCb04bW1JWytVvsStUjzUjhXqdmEIVeGZZE6cPgFcGn+XVthPhk oS7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695243830; x=1695848630; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QFTXI1M20f8gmG6BvRAdcxEpoXePrbyr+CokqbvWBWc=; b=Mg9b0n9Qn1EbHAwGBdCC14FpA1eBlUWuA5Z4D54PuFdmoWZSXtecSzVzV2yLl/9Vv2 8Bqx8ZBUM7QtvXDTUX2lXPEy/MfzkcxmZdUu+Fy4nRQ2Xsk95AFOsMvG1dITAoUIOpDf rMkGbKGwHObKiYqkd3m0aG2cYdvofd4lgbchX5vI9bD1dAWq/hYrNk+gfnxwkSlnVKGV hb5+DIduIvdRloVNBz5Un0iYm9BIU/d0vM/y+846jY1nqKppWjejQQEZ34BH3y/POLhE Kvc+3Zva540mxwEiuA7EDWUAAJiHAPrhyBhAyVK7JRYxMRZ0tOzMxTmrCOhF/UwZAjsB nRiA== X-Gm-Message-State: AOJu0YxlNsVsEieeTlhzxU+ecRzQRUZDnkQWnl3e16yuVH50RGYeJztE bOkF5yCldCNIp504s2Hb78Yz9bkG4Zg= X-Google-Smtp-Source: AGHT+IH5QBEwnaGAG6ouJVZQG2FiwG4z7ywKiDhgLSOOF+0VMXfLus6G3HR8pg7XpQjZrIgu3wnPZ1Tf/l8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:c407:b0:1c3:411c:9b7c with SMTP id k7-20020a170902c40700b001c3411c9b7cmr51568plk.13.1695243830643; Wed, 20 Sep 2023 14:03:50 -0700 (PDT) Date: Wed, 20 Sep 2023 14:03:49 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-12-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v12 11/33] KVM: Introduce per-page memory attributes From: Sean Christopherson To: Binbin Wu Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , Xu Yilun , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230920_140353_076301_E865CF52 X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 18, 2023, Binbin Wu wrote: > > > On 9/14/2023 9:55 AM, Sean Christopherson wrote: > > From: Chao Peng > [...] > > +#ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES > > +/* > > + * Returns true if _all_ gfns in the range [@start, @end) have attributes > > + * matching @attrs. > > + */ > > +bool kvm_range_has_memory_attributes(struct kvm *kvm, gfn_t start, gfn_t end, > > + unsigned long attrs) > > +{ > > + XA_STATE(xas, &kvm->mem_attr_array, start); > > + unsigned long index; > > + bool has_attrs; > > + void *entry; > > + > > + rcu_read_lock(); > > + > > + if (!attrs) { > > + has_attrs = !xas_find(&xas, end); > IIUIC, xas_find() is inclusive for "end", so here should be "end - 1" ? Yes, that does appear to be the case. Inclusive vs. exclusive on gfn ranges has is the bane of my existence. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel