From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04A20E706F2 for ; Thu, 21 Sep 2023 08:37:38 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.606203.943954 (Exim 4.92) (envelope-from ) id 1qjFBV-00070r-N3; Thu, 21 Sep 2023 08:37:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 606203.943954; Thu, 21 Sep 2023 08:37:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qjFBV-00070k-Jx; Thu, 21 Sep 2023 08:37:17 +0000 Received: by outflank-mailman (input) for mailman id 606203; Thu, 21 Sep 2023 08:37:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qjFBU-00070e-Ia for xen-devel@lists.xenproject.org; Thu, 21 Sep 2023 08:37:16 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 10d0a6c9-585a-11ee-878a-cb3800f73035; Thu, 21 Sep 2023 10:37:15 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-678-OdemBF2yPLKauHOI-1M1KA-1; Thu, 21 Sep 2023 04:37:11 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 530DE3C0F66F; Thu, 21 Sep 2023 08:37:10 +0000 (UTC) Received: from redhat.com (dhcp-192-199.str.redhat.com [10.33.192.199]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2CE6551E3; Thu, 21 Sep 2023 08:37:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10d0a6c9-585a-11ee-878a-cb3800f73035 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695285434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EA0RJ+IxzSvsZ2thl58X6wMjKC0Rx0Zni7KaXfz8A7U=; b=gyRCkA6GuKWfPp32jPQwOlGJNhjaUn4kxzyvQRjbnV1lQudqtP5Xt6SGyZLCARgzPneNKT ymujrvAs6JRiIeBKjwDLGiAMJw0mFHbezH8B1O+gQyry3zOldzvTqKR+YughFzZ7pTJ2lp +9JK1PRbj10qFAB39N849JNtzjGJOr4= X-MC-Unique: OdemBF2yPLKauHOI-1M1KA-1 Date: Thu, 21 Sep 2023 10:37:06 +0200 From: Kevin Wolf To: Markus Armbruster Cc: qemu-devel@nongnu.org, hreitz@redhat.com, eblake@redhat.com, vsementsov@yandex-team.ru, jsnow@redhat.com, idryomov@gmail.com, pl@kamp.de, sw@weilnetz.de, sstabellini@kernel.org, anthony.perard@citrix.com, paul@xen.org, pbonzini@redhat.com, marcandre.lureau@redhat.com, berrange@redhat.com, thuth@redhat.com, philmd@linaro.org, stefanha@redhat.com, fam@euphon.net, quintela@redhat.com, peterx@redhat.com, leobras@redhat.com, kraxel@redhat.com, qemu-block@nongnu.org, xen-devel@lists.xenproject.org, alex.bennee@linaro.org, peter.maydell@linaro.org Subject: Re: [PATCH v2 4/7] block/dirty-bitmap: Clean up local variable shadowing Message-ID: References: <20230920183149.1105333-1-armbru@redhat.com> <20230920183149.1105333-5-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230920183149.1105333-5-armbru@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Am 20.09.2023 um 20:31 hat Markus Armbruster geschrieben: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Tracked down with -Wshadow=local. > Clean up: rename both the pair of parameters and the pair of local > variables. While there, move the local variables to function scope. > > Suggested-by: Kevin Wolf > Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf