From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH v2 3/4] fixup! drm/xe: Introduce a new DRM driver for Intel GPUs
Date: Thu, 21 Sep 2023 12:28:16 -0400 [thread overview]
Message-ID: <ZQxvIFn0M7GhOaQO@intel.com> (raw)
In-Reply-To: <20230921111434.3051325-4-jouni.hogander@intel.com>
On Thu, Sep 21, 2023 at 02:14:33PM +0300, Jouni Högander wrote:
> Introducing xe_runtime_pm doesn't really belong into drm driver
> introduction patch. Let's remove it from here and add back in display
> implementation patch where it's needed.
>
> v2: Remove xe_runtime_pm completely from DRM driver patch
>
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
I'm trusting that you have tested the compilation after the fixup
and that it works, so:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/xe/xe_device_types.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> index a82f28c6a3a0..c0d5ca62df7b 100644
> --- a/drivers/gpu/drm/xe/xe_device_types.h
> +++ b/drivers/gpu/drm/xe/xe_device_types.h
> @@ -401,9 +401,6 @@ struct xe_device {
> */
> u32 edram_size_mb;
>
> - /* To shut up runtime pm macros.. */
> - struct xe_runtime_pm {} runtime_pm;
> -
> /* For pcode */
> struct mutex sb_lock;
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-09-21 16:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 11:14 [Intel-xe] [PATCH v2 0/4] Xe runtime pm refactoring Jouni Högander
2023-09-21 11:14 ` [Intel-xe] [PATCH v2 1/4] Revert "FIXME: drm/i915: runtime pm changes" Jouni Högander
2023-09-21 11:14 ` [Intel-xe] [PATCH v2 2/4] drm/i915: Remove runtime suspended boolean from intel_runtime_pm struct Jouni Högander
2023-09-21 11:14 ` [Intel-xe] [PATCH v2 3/4] fixup! drm/xe: Introduce a new DRM driver for Intel GPUs Jouni Högander
2023-09-21 16:28 ` Rodrigo Vivi [this message]
2023-09-21 11:14 ` [Intel-xe] [PATCH v2 4/4] fixup! drm/xe/display: Implement display support Jouni Högander
2023-09-21 11:17 ` [Intel-xe] ✓ CI.Patch_applied: success for Xe runtime pm refactoring (rev2) Patchwork
2023-09-21 11:17 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-21 11:18 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-21 11:25 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-21 11:26 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-21 11:27 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-21 12:02 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
2023-09-21 16:28 ` [Intel-xe] [PATCH v2 0/4] Xe runtime pm refactoring Rodrigo Vivi
2023-09-25 5:38 ` Hogander, Jouni
2023-09-22 5:50 ` [Intel-xe] ✓ CI.Patch_applied: success for Xe runtime pm refactoring (rev3) Patchwork
2023-09-22 5:51 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-22 5:52 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-22 5:59 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-22 5:59 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-22 6:01 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-22 6:35 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-08-14 22:37 [Intel-xe] [PATCH v2 0/4] Port CPU-GPU timestamp correlation to XE KMD Umesh Nerlige Ramappa
2023-08-14 22:37 ` [Intel-xe] [PATCH v2 3/4] fixup! drm/xe: Introduce a new DRM driver for Intel GPUs Umesh Nerlige Ramappa
2023-08-14 22:51 ` Umesh Nerlige Ramappa
2023-08-15 14:03 ` Souza, Jose
2023-08-15 16:42 ` Niranjana Vishwanathapura
2023-08-15 18:40 ` Umesh Nerlige Ramappa
2023-08-16 22:16 ` Vivi, Rodrigo
2023-09-14 19:32 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQxvIFn0M7GhOaQO@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.