From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8B2CE81DED for ; Fri, 6 Oct 2023 12:19:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lLisEMrwSw55L7II0CHG9iP51qUAlleMPZ/FDr/qaAQ=; b=GMI+WHMOPaotXhswn+ENK1dEU8 0YB2g+0hhA1ClzSUM2nwp/iAHXuKXhf9iAFhASV0blZYqh7fu44HPoNDSZwxdS0XxqU6K7d7BHc55 CzsqC2t4CM+A9o4bhjVdPY3ImozPdaJlbkhiTd57xidkzEGMYKzIf/9O4llXrFQQT7jHGncOFpZWS gjMMLsvEyfa+TMDGWjfWLEdKvQ+Qux6MZHN57vdVhC+JG4Wt3+Vmdu5CrxsdVOWJ06Ngx5HA1GwIm Rm6paThlR5/pDV0cqG1WmXwV0NTuHT9xet6eBGOzxaVVSgMMB5CE+f6VjYYPnGuNpRkbfrqFIQqSI Y9B1PgEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qojnt-005lRd-1R; Fri, 06 Oct 2023 12:19:37 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qojnp-005lQG-31; Fri, 06 Oct 2023 12:19:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1994ECE27A7; Fri, 6 Oct 2023 12:19:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D5F4C433C9; Fri, 6 Oct 2023 12:19:27 +0000 (UTC) Date: Fri, 6 Oct 2023 13:19:25 +0100 From: Catalin Marinas To: Doug Anderson Cc: Mark Rutland , Will Deacon , Marc Zyngier , Stephen Boyd , Valentin Schneider , Chen-Yu Tsai , AngeloGioacchino Del Regno , D Scott Phillips , Josh Poimboeuf , Matthias Brugger , Misono Tomohiro , Peter Zijlstra , Sumit Garg , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 1/2] arm64: smp: Fix pseudo NMI issues w/ broken Mediatek FW Message-ID: References: <86jzs2ofqs.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231006_051934_140721_FDA8A21C X-CRM114-Status: GOOD ( 22.59 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Oct 05, 2023 at 08:34:56AM -0700, Doug Anderson wrote: > On Thu, Oct 5, 2023 at 3:27 AM Mark Rutland wrote: > > On Wed, Oct 04, 2023 at 07:04:12AM -0700, Doug Anderson wrote: > > > On Wed, Oct 4, 2023 at 3:15 AM Marc Zyngier wrote: > > > > On Wed, 04 Oct 2023 10:59:50 +0100, > > > > Mark Rutland wrote: > > > > > Given you haven't seen any issues, I suspect those are getting reset to fixed > > > > > values that happens to work out for us, but it is a bit worrisome more > > > > > generally (e.g. the LPI case above). > > > > > > > > It is likely that these SoCs don't even have an ITS. > > > > > > Right. That was what we decided [1] when Marc pointed this out earlier. > > > > > > Overall: we know that this firmware behavior is not good but we're > > > stuck with it. :( At the very least, any new devices coming out will > > > have this fixed. Presumably if old devices are working OK enough today > > > (as long as you don't enable pseudo-NMI) then they can be made to keep > > > working? > > > > > > So circling back: what patch should we actually land? > > > > For now I'd prefer we took the patch I sent in: > > > > https://lore.kernel.org/linux-arm-kernel/ZRr8r7XMoyDKaitd@FVFF77S0Q05N.cambridge.arm.com/ > > > > ... as that leaves us no worse than before this series, and it's pretty simple. > > Sounds good to me! > > Catalin / Will: Please yell if there's anything you need me to do. > Otherwise I'll assume you'll pick up Mark's patch instead of my patch > #1 and then you'll pick up my patch #2. I applied both to the arm64 for-next/backtrace-ipi branch. Thanks. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A15F3E81DE9 for ; Fri, 6 Oct 2023 12:20:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WqlR9ckX9OgGS8NAf2v2XhJaVf1aKH5u3+mF0OsrTwg=; b=AZdyiCH2xcoI8B 8i0ENy/voqN/4tL2MrcYUZOZtlZ9CTLbwY9281TrMnQUnOcK1wq4Xrqbd+iTS1rXDaYJXLsFNd76Q abpMYnp++Jzz830YJ9vpmLtwdSa/FPBhINvx8oEMdQTNX2yfmXB9eWwJ69/ZG/lEfq9D3rYZQOCvI mZ3OtA8VhQ4NODsoewtOrPzuXFp0cYpTBpHh5oDzQITIekGF+XcwfGY3XbXaAuY6SX4QAb+jxdi88 ZnA4UfcI4VWW7yKLR7VzV3yEo0AnrwiH+tVdkcV7De7lWw8n2Vjl+IGGpAY7gwM4sPCqYhxmZEex9 mUTMXAGIhRxfzjKMVZjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qojns-005lRK-37; Fri, 06 Oct 2023 12:19:36 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qojnp-005lQG-31; Fri, 06 Oct 2023 12:19:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1994ECE27A7; Fri, 6 Oct 2023 12:19:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D5F4C433C9; Fri, 6 Oct 2023 12:19:27 +0000 (UTC) Date: Fri, 6 Oct 2023 13:19:25 +0100 From: Catalin Marinas To: Doug Anderson Cc: Mark Rutland , Will Deacon , Marc Zyngier , Stephen Boyd , Valentin Schneider , Chen-Yu Tsai , AngeloGioacchino Del Regno , D Scott Phillips , Josh Poimboeuf , Matthias Brugger , Misono Tomohiro , Peter Zijlstra , Sumit Garg , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 1/2] arm64: smp: Fix pseudo NMI issues w/ broken Mediatek FW Message-ID: References: <86jzs2ofqs.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231006_051934_140721_FDA8A21C X-CRM114-Status: GOOD ( 22.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBPY3QgMDUsIDIwMjMgYXQgMDg6MzQ6NTZBTSAtMDcwMCwgRG91ZyBBbmRlcnNvbiB3 cm90ZToKPiBPbiBUaHUsIE9jdCA1LCAyMDIzIGF0IDM6MjfigK9BTSBNYXJrIFJ1dGxhbmQgPG1h cmsucnV0bGFuZEBhcm0uY29tPiB3cm90ZToKPiA+IE9uIFdlZCwgT2N0IDA0LCAyMDIzIGF0IDA3 OjA0OjEyQU0gLTA3MDAsIERvdWcgQW5kZXJzb24gd3JvdGU6Cj4gPiA+IE9uIFdlZCwgT2N0IDQs IDIwMjMgYXQgMzoxNeKAr0FNIE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+IHdyb3RlOgo+ ID4gPiA+IE9uIFdlZCwgMDQgT2N0IDIwMjMgMTA6NTk6NTAgKzAxMDAsCj4gPiA+ID4gTWFyayBS dXRsYW5kIDxtYXJrLnJ1dGxhbmRAYXJtLmNvbT4gd3JvdGU6Cj4gPiA+ID4gPiBHaXZlbiB5b3Ug aGF2ZW4ndCBzZWVuIGFueSBpc3N1ZXMsIEkgc3VzcGVjdCB0aG9zZSBhcmUgZ2V0dGluZyByZXNl dCB0byBmaXhlZAo+ID4gPiA+ID4gdmFsdWVzIHRoYXQgaGFwcGVucyB0byB3b3JrIG91dCBmb3Ig dXMsIGJ1dCBpdCBpcyBhIGJpdCB3b3JyaXNvbWUgbW9yZQo+ID4gPiA+ID4gZ2VuZXJhbGx5IChl LmcuIHRoZSBMUEkgY2FzZSBhYm92ZSkuCj4gPiA+ID4KPiA+ID4gPiBJdCBpcyBsaWtlbHkgdGhh dCB0aGVzZSBTb0NzIGRvbid0IGV2ZW4gaGF2ZSBhbiBJVFMuCj4gPiA+Cj4gPiA+IFJpZ2h0LiBU aGF0IHdhcyB3aGF0IHdlIGRlY2lkZWQgWzFdIHdoZW4gTWFyYyBwb2ludGVkIHRoaXMgb3V0IGVh cmxpZXIuCj4gPiA+Cj4gPiA+IE92ZXJhbGw6IHdlIGtub3cgdGhhdCB0aGlzIGZpcm13YXJlIGJl aGF2aW9yIGlzIG5vdCBnb29kIGJ1dCB3ZSdyZQo+ID4gPiBzdHVjayB3aXRoIGl0LiA6KCBBdCB0 aGUgdmVyeSBsZWFzdCwgYW55IG5ldyBkZXZpY2VzIGNvbWluZyBvdXQgd2lsbAo+ID4gPiBoYXZl IHRoaXMgZml4ZWQuIFByZXN1bWFibHkgaWYgb2xkIGRldmljZXMgYXJlIHdvcmtpbmcgT0sgZW5v dWdoIHRvZGF5Cj4gPiA+IChhcyBsb25nIGFzIHlvdSBkb24ndCBlbmFibGUgcHNldWRvLU5NSSkg dGhlbiB0aGV5IGNhbiBiZSBtYWRlIHRvIGtlZXAKPiA+ID4gd29ya2luZz8KPiA+ID4KPiA+ID4g U28gY2lyY2xpbmcgYmFjazogd2hhdCBwYXRjaCBzaG91bGQgd2UgYWN0dWFsbHkgbGFuZD8KPiA+ Cj4gPiBGb3Igbm93IEknZCBwcmVmZXIgd2UgdG9vayB0aGUgcGF0Y2ggSSBzZW50IGluOgo+ID4K PiA+ICAgaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtYXJtLWtlcm5lbC9aUnI4cjdYTW95 REthaXRkQEZWRkY3N1MwUTA1Ti5jYW1icmlkZ2UuYXJtLmNvbS8KPiA+Cj4gPiAuLi4gYXMgdGhh dCBsZWF2ZXMgdXMgbm8gd29yc2UgdGhhbiBiZWZvcmUgdGhpcyBzZXJpZXMsIGFuZCBpdCdzIHBy ZXR0eSBzaW1wbGUuCj4gCj4gU291bmRzIGdvb2QgdG8gbWUhCj4gCj4gQ2F0YWxpbiAvIFdpbGw6 IFBsZWFzZSB5ZWxsIGlmIHRoZXJlJ3MgYW55dGhpbmcgeW91IG5lZWQgbWUgdG8gZG8uCj4gT3Ro ZXJ3aXNlIEknbGwgYXNzdW1lIHlvdSdsbCBwaWNrIHVwIE1hcmsncyBwYXRjaCBpbnN0ZWFkIG9m IG15IHBhdGNoCj4gIzEgYW5kIHRoZW4geW91J2xsIHBpY2sgdXAgbXkgcGF0Y2ggIzIuCgpJIGFw cGxpZWQgYm90aCB0byB0aGUgYXJtNjQgZm9yLW5leHQvYmFja3RyYWNlLWlwaSBicmFuY2guIFRo YW5rcy4KCi0tIApDYXRhbGluCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==