Re: [Intel-xe] [PATCH v3 2/2] drm/xe/xe_hwmon.c: Add static to xe_hwmon_process_reg_read64

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Oct 03, 2023 at 06:21:45PM -0400, David Kershner wrote:
> Add static to xe_hwmon_process_reg_read64 to avoid compile warning:
> 
>     ../drivers/gpu/drm/xe/xe_hwmon.c:126:5: error: no previous prototype
>          for ‘xe_hwmon_process_reg_read64’ [-Werror=missing-prototypes]

yeap, non-exported functions should always be static.
and exported functions like xe_hwmon_register() should have documentation.

> 
> Signed-off-by: David Kershner <david.kershner@intel.com>

Cc: Badal Nilawar <badal.nilawar@intel.com>
Cc: Riana Tauro <riana.tauro@intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_hwmon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index 1deb5007e1e2..172bb85edcf1 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -123,7 +123,7 @@ static int xe_hwmon_process_reg(struct xe_hwmon *hwmon, enum xe_hwmon_reg hwmon_
>  	}
>  }
>  
> -int xe_hwmon_process_reg_read64(struct xe_hwmon *hwmon, enum xe_hwmon_reg hwmon_reg, u64 *value)
> +static int xe_hwmon_process_reg_read64(struct xe_hwmon *hwmon, enum xe_hwmon_reg hwmon_reg, u64 *value)
>  {
>  	struct xe_reg reg;
>  
> -- 
> 2.35.1
>