Re: [Intel-xe] [PATCH] fixup! drm/xe/hwmon: Expose power attributes

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Oct 04, 2023 at 09:09:32AM -0700, Lucas De Marchi wrote:
> Add missing static to fixup build with W=1

https://lore.kernel.org/all/20231003222145.4090918-3-david.kershner@intel.com/

> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> 
> Also I see in the changelog a change adding xe_ prefix to the static
> funtions... that is not the convention most of the driver follow and I
> don't think it should had been done. Anyway, just fixing the more
> immediate issue here.
> 
>  drivers/gpu/drm/xe/xe_hwmon.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index 1deb5007e1e2..734fcca9f71f 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -123,7 +123,8 @@ static int xe_hwmon_process_reg(struct xe_hwmon *hwmon, enum xe_hwmon_reg hwmon_
>  	}
>  }
>  
> -int xe_hwmon_process_reg_read64(struct xe_hwmon *hwmon, enum xe_hwmon_reg hwmon_reg, u64 *value)
> +static int xe_hwmon_process_reg_read64(struct xe_hwmon *hwmon,
> +				       enum xe_hwmon_reg hwmon_reg, u64 *value)
>  {
>  	struct xe_reg reg;
>  
> -- 
> 2.40.1
>