From: Bagas Sanjaya <bagasdotme@gmail.com>
To: "KaiLong Wang" <wangkailong@jari.cn>, arnd@arndb.de
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vmlinux.lds.h: Clean up errors in vmlinux.lds.h
Date: Thu, 5 Oct 2023 07:13:18 +0700 [thread overview]
Message-ID: <ZR3_nt646ijkV3UJ@debian.me> (raw)
In-Reply-To: <72e80688.8a8.18ad9bba905.Coremail.wangkailong@jari.cn>
[-- Attachment #1: Type: text/plain, Size: 3626 bytes --]
On Thu, Sep 28, 2023 at 11:01:08AM +0800, KaiLong Wang wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: spaces required around that ':' (ctx:WxV)
> ERROR: space required after that ',' (ctx:VxO)
> ERROR: need consistent spacing around '*' (ctx:VxW)
>
> Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
> ---
> include/asm-generic/vmlinux.lds.h | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index 9c59409104f6..9e19234bbf97 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -63,8 +63,8 @@
> * up in the PT_NOTE Program Header.
> */
> #ifdef EMITS_PT_NOTE
> -#define NOTES_HEADERS :text :note
> -#define NOTES_HEADERS_RESTORE __restore_ph : { *(.__restore_ph) } :text
> +#define NOTES_HEADERS : text : note
> +#define NOTES_HEADERS_RESTORE __restore_ph : { *(.__restore_ph) } : text
Personally I prefer macro arguments to be aligned.
> #else
> #define NOTES_HEADERS
> #define NOTES_HEADERS_RESTORE
> @@ -98,10 +98,10 @@
> */
> #if defined(CONFIG_LD_DEAD_CODE_DATA_ELIMINATION) || defined(CONFIG_LTO_CLANG)
> #define TEXT_MAIN .text .text.[0-9a-zA-Z_]*
> -#define DATA_MAIN .data .data.[0-9a-zA-Z_]* .data..L* .data..compoundliteral* .data.$__unnamed_* .data.$L*
> +#define DATA_MAIN .data .data.[0-9a-zA-Z_] * .data..L * .data..compoundliteral * .data.$__unnamed_ * .data.$L*
> #define SDATA_MAIN .sdata .sdata.[0-9a-zA-Z_]*
> -#define RODATA_MAIN .rodata .rodata.[0-9a-zA-Z_]* .rodata..L*
> -#define BSS_MAIN .bss .bss.[0-9a-zA-Z_]* .bss..compoundliteral*
> +#define RODATA_MAIN .rodata .rodata.[0-9a-zA-Z_] * .rodata..L*
> +#define BSS_MAIN .bss .bss.[0-9a-zA-Z_] * .bss..compoundliteral*
> #define SBSS_MAIN .sbss .sbss.[0-9a-zA-Z_]*
Is it taking a pointer or changing to multiplication?
> #else
> #define TEXT_MAIN .text
> @@ -462,7 +462,7 @@
> . = ALIGN((align)); \
> .rodata : AT(ADDR(.rodata) - LOAD_OFFSET) { \
> __start_rodata = .; \
> - *(.rodata) *(.rodata.*) \
> + *(.rodata) * (.rodata.*) \
> SCHED_DATA \
> RO_AFTER_INIT_DATA /* Read only after init */ \
> . = ALIGN(8); \
> @@ -494,28 +494,28 @@
> /* Kernel symbol table: Normal symbols */ \
> __ksymtab : AT(ADDR(__ksymtab) - LOAD_OFFSET) { \
> __start___ksymtab = .; \
> - KEEP(*(SORT(___ksymtab+*))) \
> + KEEP(*(SORT(___ksymtab+ *))) \
> __stop___ksymtab = .; \
> } \
> \
> /* Kernel symbol table: GPL-only symbols */ \
> __ksymtab_gpl : AT(ADDR(__ksymtab_gpl) - LOAD_OFFSET) { \
> __start___ksymtab_gpl = .; \
> - KEEP(*(SORT(___ksymtab_gpl+*))) \
> + KEEP(*(SORT(___ksymtab_gpl+ *))) \
> __stop___ksymtab_gpl = .; \
> } \
> \
> /* Kernel symbol table: Normal symbols */ \
> __kcrctab : AT(ADDR(__kcrctab) - LOAD_OFFSET) { \
> __start___kcrctab = .; \
> - KEEP(*(SORT(___kcrctab+*))) \
> + KEEP(*(SORT(___kcrctab+ *))) \
> __stop___kcrctab = .; \
> } \
> \
> /* Kernel symbol table: GPL-only symbols */ \
> __kcrctab_gpl : AT(ADDR(__kcrctab_gpl) - LOAD_OFFSET) { \
> __start___kcrctab_gpl = .; \
> - KEEP(*(SORT(___kcrctab_gpl+*))) \
> + KEEP(*(SORT(___kcrctab_gpl+ *))) \
> __stop___kcrctab_gpl = .; \
> } \
Same here.
Confused...
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-10-05 0:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 3:01 [PATCH] vmlinux.lds.h: Clean up errors in vmlinux.lds.h KaiLong Wang
2023-09-30 2:00 ` kernel test robot
2023-09-30 2:00 ` kernel test robot
2023-10-05 0:13 ` Bagas Sanjaya [this message]
2023-10-05 8:45 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZR3_nt646ijkV3UJ@debian.me \
--to=bagasdotme@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangkailong@jari.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.