From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3DD1EA9 for ; Thu, 5 Oct 2023 01:26:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="IbjZFcXw" Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2777d237229so380107a91.2 for ; Wed, 04 Oct 2023 18:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696469169; x=1697073969; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=/TYfhcgTqo5ZRyy5fcNvbHFZ7+EudMa0DogQVaLExeg=; b=IbjZFcXwIIoap4ldZlnLb3BLo7ieRQLj7OZmrH8TSn0WJvsEk/q8VDbLF/hTWB5gQn CsPo5IGzCAxrYlcC/oa/vsWWXrBOJyxX0XTH0X9YgBqNggTcj+5oP6Wm3Y/psQ2yc+qw ZwT+xz8fh0FFZYue6Iul3xCwTQe8wYhv/bY1PFAOyuXUusUv8o4ZJlE72LMI3rRwcNiZ Yrl2fp3ywywsU6ukLz5chK96IdaSHcJh5tH9d47C67qjMHxn+B9w7k93D3zyb9VMBJR/ dCFTvSf73ngfJsqCQILEKplx2FToz/WnLDxwghE75FyzsqScI9pVHQK0uig8qYsMJgXV EBGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696469169; x=1697073969; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/TYfhcgTqo5ZRyy5fcNvbHFZ7+EudMa0DogQVaLExeg=; b=l7OV50knVq9MABI1v9yuU558MwEi4C/rR8NlBBa65PVOM8g1L3cM0RkHaH2ZGCIyBW VSAOaq504hAj+b0GyH8OPL6U1iL052dHxGnLK4RKAjAqTtiJjK65gs+qIYOPTx9dMz5e OMWJi6tY0rKICjTdd8sDdbB4x6+wUA6C4/CBGfuED9uRAME9Erv69son2vlIkIl9k2ZJ USU7kFA+6I3Dl+uA0MNwiMVDu/x8zawo6u79x358t6e0CMVZOu2ONx/CMDLoPsKUcT9o J65aUnYfqYfaZjwLVkcZLyMNyjp6wWhrcRNEfZcyBzQ/UtJqEet5LBt7V41Zf1o0naJn m8zg== X-Gm-Message-State: AOJu0YypD+EaOAvW8PkSGlSNTo+nZQuXsiy5NFCamp2fGynoa4kBjjrB f0J+QsrPAB2qFETTVXTvSroc54dbk4I= X-Google-Smtp-Source: AGHT+IEfh6PZmAexjHN3igsJGvIKhGoBOSIMHSS/3bzuKrRlDIj+2RI1Fh55kTfxzztFM3zd3m2gy0y4R7A= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90a:b790:b0:269:4850:5411 with SMTP id m16-20020a17090ab79000b0026948505411mr61401pjr.4.1696469169119; Wed, 04 Oct 2023 18:26:09 -0700 (PDT) Date: Wed, 4 Oct 2023 18:26:07 -0700 In-Reply-To: <20230908222905.1321305-7-amoorthy@google.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20230908222905.1321305-1-amoorthy@google.com> <20230908222905.1321305-7-amoorthy@google.com> Message-ID: Subject: Re: [PATCH v5 06/17] KVM: x86: Annotate -EFAULTs from kvm_handle_error_pfn() From: Sean Christopherson To: Anish Moorthy Cc: oliver.upton@linux.dev, kvm@vger.kernel.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, maz@kernel.org, robert.hoo.linux@gmail.com, jthoughton@google.com, ricarkol@google.com, axelrasmussen@google.com, peterx@redhat.com, nadav.amit@gmail.com, isaku.yamahata@gmail.com, kconsul@linux.vnet.ibm.com Content-Type: text/plain; charset="us-ascii" On Fri, Sep 08, 2023, Anish Moorthy wrote: > Implement KVM_CAP_MEMORY_FAULT_INFO for efaults generated by > kvm_handle_error_pfn(). Rewrite with --verbose please. And avoid function names if possible. Sometimes it's better/useful/necessary to reference a function by name, but in this case, just saying kvm_handle_error_pfn() isn't helpful because it doesn't provide any insight into the actual impact of the change, i.e. requires the reader to already know exactly how and when kvm_handle_error_pfn() is used.