All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Tamas K Lengyel <tamas@tklengyel.com>
Cc: xen-devel@lists.xenproject.org, henry.wang@arm.com,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
	Julien Grall <julien@xen.org>
Subject: Re: [PATCH v5 01/10] mem_sharing/fork: do not attempt to populate vcpu_info page
Date: Thu, 5 Oct 2023 14:42:00 +0200	[thread overview]
Message-ID: <ZR6vGAhC41Uixchq@MacBookPdeRoger> (raw)
In-Reply-To: <CABfawhmyP_y38002v=v1G2p66ZamhGKrj=0Jm1H_-c_j9VQG8Q@mail.gmail.com>

On Tue, Oct 03, 2023 at 09:46:13AM -0400, Tamas K Lengyel wrote:
> On Mon, Oct 2, 2023 at 11:12 AM Roger Pau Monne <roger.pau@citrix.com> wrote:
> >
> > Instead let map_vcpu_info() and it's call to get_page_from_gfn()
> > populate the page in the child as needed.  Also remove the bogus
> > copy_domain_page(): should be placed before the call to map_vcpu_info(),
> > as the later can update the contents of the vcpu_info page.
> >
> > Note that this eliminates a bug in copy_vcpu_settings(): The function did
> > allocate a new page regardless of the GFN already having a mapping, thus in
> > particular breaking the case of two vCPU-s having their info areas on the same
> > page.
> >
> > Fixes: 41548c5472a3 ('mem_sharing: VM forking')
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Acked-by: Tamas K Lengyel <tamas@tklengyel.com>

Thanks, Roger.


  parent reply	other threads:[~2023-10-05 12:42 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-02 15:11 [PATCH v5 00/10] runstate/time area registration by (guest) physical address Roger Pau Monne
2023-10-02 15:11 ` [PATCH v5 01/10] mem_sharing/fork: do not attempt to populate vcpu_info page Roger Pau Monne
     [not found]   ` <CABfawhm2XMmfyx7vZvGdLZcot3=Mrrx3T5nS3vUR+Ur9j5mkWg@mail.gmail.com>
2023-10-03  7:15     ` Roger Pau Monné
2023-10-05 12:10   ` Julien Grall
2023-10-05 12:42     ` George Dunlap
2023-10-05 12:47       ` Julien Grall
     [not found]   ` <CABfawhmyP_y38002v=v1G2p66ZamhGKrj=0Jm1H_-c_j9VQG8Q@mail.gmail.com>
2023-10-05 12:42     ` Roger Pau Monné [this message]
2023-10-05 13:15   ` Tamas K Lengyel
2023-10-02 15:11 ` [PATCH v5 02/10] x86/shim: zap runstate and time area handles during shutdown Roger Pau Monne
2023-10-02 15:11 ` [PATCH v5 03/10] domain: GADDR based shared guest area registration alternative - teardown Roger Pau Monne
2023-10-02 15:11 ` [PATCH v5 04/10] domain: update GADDR based runstate guest area Roger Pau Monne
2023-10-02 15:11 ` [PATCH v5 05/10] x86: update GADDR based secondary time area Roger Pau Monne
2023-10-02 15:11 ` [PATCH v5 06/10] x86/mem-sharing: copy GADDR based shared guest areas Roger Pau Monne
     [not found]   ` <CABfawhnHg3KrGP-hp4_Q8GvSf2nVSVSyK24HKqAGuWp_AtD8-A@mail.gmail.com>
2023-10-03 14:29     ` Roger Pau Monné
2023-10-03 15:07       ` Julien Grall
2023-10-03 20:25         ` Tamas K Lengyel
2023-10-04  8:20           ` Roger Pau Monné
2023-10-04 11:01             ` Julien Grall
2023-10-04 13:00               ` Roger Pau Monné
2023-10-04 13:06                 ` Julien Grall
2023-10-04 13:53                   ` [PATCH v6 " Roger Pau Monne
2023-10-04 21:36                     ` Tamas K Lengyel
2023-10-16  9:55                     ` Jan Beulich
2023-10-16 10:59                       ` Roger Pau Monné
2023-10-02 15:11 ` [PATCH v5 07/10] domain: map/unmap " Roger Pau Monne
2023-10-02 16:40   ` Julien Grall
2023-10-02 15:11 ` [PATCH v5 08/10] domain: introduce GADDR based runstate area registration alternative Roger Pau Monne
2023-10-02 16:43   ` Julien Grall
2023-10-02 15:11 ` [PATCH v5 09/10] x86: introduce GADDR based secondary time " Roger Pau Monne
2023-10-02 16:44   ` Julien Grall
2023-10-02 15:11 ` [PATCH v5 10/10] common: convert vCPU info area registration Roger Pau Monne
2023-10-04 17:15   ` Julien Grall
2023-10-05  1:27 ` [PATCH v5 00/10] runstate/time area registration by (guest) physical address Henry Wang
2023-10-05 13:12   ` Julien Grall
2023-10-05 18:58 ` [CRITICAL for 4.18] " Andrew Cooper
2023-10-05 22:40   ` Julien Grall
2023-10-05 22:43     ` Julien Grall
2023-10-06  8:00   ` Roger Pau Monné
2023-10-06  8:22     ` Roger Pau Monné
2023-10-06 10:21     ` Andrew Cooper
2023-10-16 10:04   ` Jan Beulich
2023-10-16 10:07 ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZR6vGAhC41Uixchq@MacBookPdeRoger \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=henry.wang@arm.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=tamas@tklengyel.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.