From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH v2 0/6] some "commit-graph verify" fixes for chains
Date: Thu, 5 Oct 2023 13:38:22 -0400 [thread overview]
Message-ID: <ZR70jsa4TTl3k940@nand.local> (raw)
In-Reply-To: <20230928043746.GB57926@coredump.intra.peff.net>
On Thu, Sep 28, 2023 at 12:37:46AM -0400, Jeff King wrote:
> On Tue, Sep 26, 2023 at 01:54:52AM -0400, Jeff King wrote:
>
> > [1/6]: commit-graph: factor out chain opening function
> > [2/6]: commit-graph: check mixed generation validation when loading chain file
> > [3/6]: t5324: harmonize sha1/sha256 graph chain corruption
> > [4/6]: commit-graph: detect read errors when verifying graph chain
> > [5/6]: commit-graph: tighten chain size check
> > [6/6]: commit-graph: report incomplete chains during verification
>
> Here's a re-roll that fixes a missed case in patch 6 (I sent more
> details elsewhere in the thread).
Thanks, and apologies for taking a little longer than I would have liked
to review both of these rounds. This round looks great to me (and it's
already in 'next').
Thanks,
Taylor
prev parent reply other threads:[~2023-10-05 17:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 5:54 [PATCH 0/6] some "commit-graph verify" fixes for chains Jeff King
2023-09-26 5:56 ` [PATCH 1/6] commit-graph: factor out chain opening function Jeff King
2023-09-26 5:57 ` [PATCH 2/6] commit-graph: check mixed generation validation when loading chain file Jeff King
2023-09-26 5:58 ` [PATCH 3/6] t5324: harmonize sha1/sha256 graph chain corruption Jeff King
2023-09-26 6:00 ` [PATCH 4/6] commit-graph: detect read errors when verifying graph chain Jeff King
2023-09-26 6:03 ` [PATCH 5/6] commit-graph: tighten chain size check Jeff King
2023-09-26 6:04 ` [PATCH 6/6] commit-graph: report incomplete chains during verification Jeff King
2023-09-28 4:30 ` Jeff King
2023-09-28 4:37 ` [PATCH v2 0/6] some "commit-graph verify" fixes for chains Jeff King
2023-09-28 4:38 ` [PATCH v2 1/6] commit-graph: factor out chain opening function Jeff King
2023-09-28 4:38 ` [PATCH v2 2/6] commit-graph: check mixed generation validation when loading chain file Jeff King
2023-09-28 4:38 ` [PATCH v2 3/6] t5324: harmonize sha1/sha256 graph chain corruption Jeff King
2023-09-28 4:38 ` [PATCH v2 4/6] commit-graph: detect read errors when verifying graph chain Jeff King
2023-09-28 4:39 ` [PATCH v2 5/6] commit-graph: tighten chain size check Jeff King
2023-09-28 4:39 ` [PATCH v2 6/6] commit-graph: report incomplete chains during verification Jeff King
2023-10-05 17:38 ` Taylor Blau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZR70jsa4TTl3k940@nand.local \
--to=me@ttaylorr.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.