From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04F5FCE7A8A for ; Sun, 24 Sep 2023 21:57:02 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id EB04B3CE2A4 for ; Sun, 24 Sep 2023 23:57:00 +0200 (CEST) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 557A03CBDC6 for ; Sun, 24 Sep 2023 23:56:48 +0200 (CEST) Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 14F9F1000776 for ; Sun, 24 Sep 2023 23:56:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=t0dWRs0AcgJslUYwJm+3ICfi/SDNmg7iKfq/0Kh1WAc=; b=hj/JQqXGV4LZ1Z56d6uW9HOEmC h2nSL/RQeHQdmbLgcsXYyTTIhfVpUfzo0RSpfO8Qy/0NaJMG5mUjzTQXFsRcpa2iHCgFB2OxKpjrf mEnjzJQUAfWuhgE/E6fYv1IYmk5xyimJpfVJnJzRrj4la+FwJFrZSJqMqV3oLI29NO6Ed42pxpVxk RGtSU8OgA6Fdn0hlSTypKCnmQBXDzEnOZAXEzOuAopSjNtIVXQ4l+zFIHGWdPTxzwXIQ7RBLEm5GE YwZl9gqhnzKo36mTX6VfjbwharVBeq53EXWAJVI5OWxPQwVTk7qIf8XPDeed+smEANcyzcxih4nzL JlLG2VSQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qkX5Y-00FGVf-Mo; Sun, 24 Sep 2023 21:56:28 +0000 Date: Sun, 24 Sep 2023 22:56:28 +0100 From: Matthew Wilcox To: Amir Goldstein Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 1.0.1 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] vfs: fix readahead(2) on block devices X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mszeredi@redhat.com, brauner@kernel.org, Jan Kara , lkp@intel.com, oe-lkp@lists.linux.dev, kernel test robot , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, Reuben Hawkins , ltp@lists.linux.it Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" T24gU3VuLCBTZXAgMjQsIDIwMjMgYXQgMDY6MzI6MzBQTSArMDMwMCwgQW1pciBHb2xkc3RlaW4g d3JvdGU6Cj4gT24gU3VuLCBTZXAgMjQsIDIwMjMgYXQgNToyN+KAr1BNIE1hdHRoZXcgV2lsY294 IDx3aWxseUBpbmZyYWRlYWQub3JnPiB3cm90ZToKPiA+Cj4gPiBPbiBTdW4sIFNlcCAyNCwgMjAy MyBhdCAwMjo0Nzo0MlBNICswMzAwLCBBbWlyIEdvbGRzdGVpbiB3cm90ZToKPiA+ID4gU2luY2Ug eW91IGpvaW5lZCB0aGUgZGlzY3Vzc2lvbiwgeW91IGhhdmUgdGhlIG9wcG9ydHVuaXR5IHRvIGFn cmVlIG9yCj4gPiA+IGRpc2FncmVlIHdpdGggb3VyIGRlY2lzaW9uIHRvIGNoYW5nZSByZWFkYWhl YWQoKSB0byBFU1BJUEUuCj4gPiA+IEp1ZGdpbmcgIGJ5IHlvdXIgY2l0aW5nIG9mIGxzZWVrIGFu ZCBwb3NpeF9mYWR2aXNlIHN0YW5kYXJkLAo+ID4gPiBJIGFzc3VtZSB0aGF0IHlvdSB3aWxsIGJl IG9uIGJvYXJkPwo+ID4KPiA+IEknbSBmaW5lIHdpdGggcmV0dXJuaW5nIEVTUElQRSAoaXQncyBs aWtlIEVOT1RUWSBpbiBhIHNlbnNlKS4gIGJ1dAo+ID4gdGhhdCdzIG5vdCB3aGF0IGtidWlsZCBy ZXBvcnRlZDoKPiAKPiBrYnVpbGQgcmVwb3J0IGlzIGZyb20gdjEgcGF0Y2ggdGhhdCB3YXMgcG9z dGVkIHRvIHRoZSBsaXN0Cj4gdGhpcyBpcyBub3QgdGhlIHBhdGNoICh2MikgdGhhdCBpcyBhcHBs aWVkIHRvIHZmcy5taXNjCj4gYW5kIGhhcyBiZWVuIGluIGxpbnV4LW5leHQgZm9yIGEgZmV3IGRh eXMuCgpBaCEgIEkgd2FzIGNvbmZ1c2VkLgoKPiA+IEkgdGhpbmsgdGhhdCBzaG91bGQKPiA+IGFs c28gcmV0dXJuIEVTUElQRS4gIEkgdGhpbmsgcG9zaXhfZmFkdmlzZSgpIHNob3VsZCByZXR1cm4g RVNQSVBFIG9uIGEKPiA+IHNvY2tldCB0b28sIGJ1dCByZXBvcnRpbmcgYnVncyB0byB0aGUgQXVz dGluIEdyb3VwIHNlZW1zIHF1aXRlIHBhaW5mdWwuCj4gPiBQZXJoYXBzIHNvbWVib2R5IGhhcyBi ZWVuIHRocm91Z2ggdGhpcyBwcm9jZXNzIGFuZCBjYW4gZG8gdGhhdCBmb3IgdXM/Cj4gCj4gVGhp cyBpcyBSZXViZW4ncyBmaXJzdCBrZXJuZWwgcGF0Y2guCj4gTGV0J3MgYWdyZWUgdGhhdCBjaGFu Z2luZyB0aGUgc3RhbmRhcmQgb2YgcG9zaXhfZmFkdmlzZSgpIGZvciBzb2NrZXQgaXMKPiBiZXlv bmQgdGhlIHNjb3BlIG9mIGhpcyBjb250cmlidXRpb24gOikKClRoYW5rIHlvdSBmb3Igc2hlcGhl cmRpbmcgaGlzIGZpcnN0IGNvbnRyaWJ1dGlvbi4gIFVuZm9ydHVuYXRlbHksIHRoaXMKaXMgcmF0 aGVyIHRoZSB3YXkgb2YgaXQgd2hlbiB5b3Ugc3RhcnQgdG8gcGljayBhdCBzb21ldGhpbmcgLi4u IHlvdSBmaW5kCm1vcmUgdGhpbmdzIHRoYXQgYXJlIGJyb2tlbi4gIEl0J3MgcmF0aGVyIHVudXN1 YWwgdGhhdCB0aGlzIG9uZSB0dXJuZWQKb3V0IHRvIGJlICJUaGUgUE9TSVggc3BlYyBoYXMgYSBk ZWZlY3QiIDstKQoKQnV0IHllcywgSSdtIGNvbnRlbnQgd2l0aCB2MiBpZiB2MiBkb2VzIGluIGZh Y3QgcmV0dXJuIEVTUElQRSBmb3IKcmVhZGFoZWFkKCkgb24gYSBzb2NrZXQuICBMZXQncyB3YWl0 IHRvIGZpbmQgb3V0LiAgV2UgY2FuIGFkZHJlc3MgdGhlClBPU0lYIGRlZmVjdCBsYXRlci4KCi0t IApNYWlsaW5nIGxpc3QgaW5mbzogaHR0cHM6Ly9saXN0cy5saW51eC5pdC9saXN0aW5mby9sdHAK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11488DF64 for ; Sun, 24 Sep 2023 21:56:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=t0dWRs0AcgJslUYwJm+3ICfi/SDNmg7iKfq/0Kh1WAc=; b=hj/JQqXGV4LZ1Z56d6uW9HOEmC h2nSL/RQeHQdmbLgcsXYyTTIhfVpUfzo0RSpfO8Qy/0NaJMG5mUjzTQXFsRcpa2iHCgFB2OxKpjrf mEnjzJQUAfWuhgE/E6fYv1IYmk5xyimJpfVJnJzRrj4la+FwJFrZSJqMqV3oLI29NO6Ed42pxpVxk RGtSU8OgA6Fdn0hlSTypKCnmQBXDzEnOZAXEzOuAopSjNtIVXQ4l+zFIHGWdPTxzwXIQ7RBLEm5GE YwZl9gqhnzKo36mTX6VfjbwharVBeq53EXWAJVI5OWxPQwVTk7qIf8XPDeed+smEANcyzcxih4nzL JlLG2VSQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qkX5Y-00FGVf-Mo; Sun, 24 Sep 2023 21:56:28 +0000 Date: Sun, 24 Sep 2023 22:56:28 +0100 From: Matthew Wilcox To: Amir Goldstein Cc: kernel test robot , Reuben Hawkins , brauner@kernel.org, Cyril Hrubis , mszeredi@redhat.com, lkp@intel.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, oe-lkp@lists.linux.dev, ltp@lists.linux.it, Jan Kara Subject: Re: [LTP] [PATCH] vfs: fix readahead(2) on block devices Message-ID: References: Precedence: bulk X-Mailing-List: oe-lkp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Sep 24, 2023 at 06:32:30PM +0300, Amir Goldstein wrote: > On Sun, Sep 24, 2023 at 5:27 PM Matthew Wilcox wrote: > > > > On Sun, Sep 24, 2023 at 02:47:42PM +0300, Amir Goldstein wrote: > > > Since you joined the discussion, you have the opportunity to agree or > > > disagree with our decision to change readahead() to ESPIPE. > > > Judging by your citing of lseek and posix_fadvise standard, > > > I assume that you will be on board? > > > > I'm fine with returning ESPIPE (it's like ENOTTY in a sense). but > > that's not what kbuild reported: > > kbuild report is from v1 patch that was posted to the list > this is not the patch (v2) that is applied to vfs.misc > and has been in linux-next for a few days. Ah! I was confused. > > I think that should > > also return ESPIPE. I think posix_fadvise() should return ESPIPE on a > > socket too, but reporting bugs to the Austin Group seems quite painful. > > Perhaps somebody has been through this process and can do that for us? > > This is Reuben's first kernel patch. > Let's agree that changing the standard of posix_fadvise() for socket is > beyond the scope of his contribution :) Thank you for shepherding his first contribution. Unfortunately, this is rather the way of it when you start to pick at something ... you find more things that are broken. It's rather unusual that this one turned out to be "The POSIX spec has a defect" ;-) But yes, I'm content with v2 if v2 does in fact return ESPIPE for readahead() on a socket. Let's wait to find out. We can address the POSIX defect later.