From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15CC9134DC for ; Mon, 25 Sep 2023 09:49:02 +0000 (UTC) Received: from out-198.mta0.migadu.com (out-198.mta0.migadu.com [91.218.175.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D21CA3 for ; Mon, 25 Sep 2023 02:49:01 -0700 (PDT) Date: Mon, 25 Sep 2023 19:48:39 +1000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jookia.org; s=key1; t=1695635339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4dRdGkWCi+7rtuoY3VfupvdbW14yuz7oH4cStDJMMaw=; b=q529K7DaZTmoYJ4kW1UJ7DKPrrYj/pzpJQycIPKy9rQR72b+inomsCrccRrt1nwAj63o9W McJDn3CuN723tMvH3iwG/bU1QgJ4jm2VQJLj6AHxpuUcpBUH8395T+oKnFgCMKjx30Dv3H JBoxQ1mwnAkZktaYaGfyLvLqTjz6DTxJpUwYCo2AT7f1UsYMSlmlbpKlSeBistP1vdzfS/ 88KjTSZsKK+zlJjxmQvMmDMiVRvTaEf3v2OdoODU6ieCvclUqsJYF3XRO87U1FnoVcqkeN zdqtB6iLBCkgqYtIR/+q2N/c5uN4FxxECJVY+33XGm9y7h8Ypc0Jt4UZn0uPmA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: John Watts To: Paul Cercueil Cc: dri-devel@lists.freedesktop.org, Neil Armstrong , Jessica Zhang , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Heiko Stuebner , Chris Morgan , Jagan Teki , Christophe Branchereau , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v3 4/7] drm/panel: nv3052c: Add Fascontek FS035VG158 LCD display Message-ID: References: <20230925021059.451019-1-contact@jookia.org> <20230925021059.451019-5-contact@jookia.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, Sep 25, 2023 at 11:43:26AM +0200, Paul Cercueil wrote: > From what I can see, you have a panel with a NV3052C chip, so the > existing initialization sequence should already work. It has some differences that I don't know if are important. > The NV3052C datasheet does not give any settings for a 640x480 panel, I > only see suggested settings for a 720x1280 vertical panel. > > Unless you have a min/max range specified, the values you see in there > are only suggestions for a working setup, that doesn't mean they are > the only recommended ones. The panel datasheet has these values. > > Cheers, > -Paul John. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D65BEE7D242 for ; Tue, 26 Sep 2023 07:15:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1DE110E350; Tue, 26 Sep 2023 07:15:10 +0000 (UTC) Received: from out-206.mta0.migadu.com (out-206.mta0.migadu.com [IPv6:2001:41d0:1004:224b::ce]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2089610E225 for ; Mon, 25 Sep 2023 09:49:01 +0000 (UTC) Date: Mon, 25 Sep 2023 19:48:39 +1000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jookia.org; s=key1; t=1695635339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4dRdGkWCi+7rtuoY3VfupvdbW14yuz7oH4cStDJMMaw=; b=q529K7DaZTmoYJ4kW1UJ7DKPrrYj/pzpJQycIPKy9rQR72b+inomsCrccRrt1nwAj63o9W McJDn3CuN723tMvH3iwG/bU1QgJ4jm2VQJLj6AHxpuUcpBUH8395T+oKnFgCMKjx30Dv3H JBoxQ1mwnAkZktaYaGfyLvLqTjz6DTxJpUwYCo2AT7f1UsYMSlmlbpKlSeBistP1vdzfS/ 88KjTSZsKK+zlJjxmQvMmDMiVRvTaEf3v2OdoODU6ieCvclUqsJYF3XRO87U1FnoVcqkeN zdqtB6iLBCkgqYtIR/+q2N/c5uN4FxxECJVY+33XGm9y7h8Ypc0Jt4UZn0uPmA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: John Watts To: Paul Cercueil Subject: Re: [RFC PATCH v3 4/7] drm/panel: nv3052c: Add Fascontek FS035VG158 LCD display Message-ID: References: <20230925021059.451019-1-contact@jookia.org> <20230925021059.451019-5-contact@jookia.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Mailman-Approved-At: Tue, 26 Sep 2023 07:15:08 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Conor Dooley , Krzysztof Kozlowski , devicetree@vger.kernel.org, Sam Ravnborg , Chris Morgan , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jagan Teki , Rob Herring , Jessica Zhang , Shawn Guo , Christophe Branchereau Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Sep 25, 2023 at 11:43:26AM +0200, Paul Cercueil wrote: > From what I can see, you have a panel with a NV3052C chip, so the > existing initialization sequence should already work. It has some differences that I don't know if are important. > The NV3052C datasheet does not give any settings for a 640x480 panel, I > only see suggested settings for a 720x1280 vertical panel. > > Unless you have a min/max range specified, the values you see in there > are only suggestions for a working setup, that doesn't mean they are > the only recommended ones. The panel datasheet has these values. > > Cheers, > -Paul John.