From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDFA8CE7A9A for ; Mon, 25 Sep 2023 16:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pbM6HWAyLD1RACSUBeWPK+fDdUzVHMdPCVPB6o4vZzo=; b=bZToXIVEqAcIrt vNYEW8kDzIW1SOlQakStsEGAYoYhxl0r8ixhym2lXU2eHQUxKQJtFxsG4s0a9q1ew8yhx72OizGvY T9RacSBpg0bXdr4Cuvx5vL143S28Tac1wM2Vc+0NsvO9EWHWmIqmfHX76aqcyUm5PJCzuUkoceEXG 7029pDelpoX+LyzsafWVlXRzFehkjPqdjzeeNiEGsEr7fHGZzcPf6lO8Gl8EnKfWMRttDhQdmhXYe WRuYiwYFqP1GkvCRST3kqZvkg6nzQ1JY/ienyNQThnNRGeDc0xv07OU6zZb/gYlSdAmw/b1Kph7Vx 8bm93VidXGP6yAa1iFeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qko6c-00Ec2G-0G; Mon, 25 Sep 2023 16:06:42 +0000 Received: from mail-yw1-x112f.google.com ([2607:f8b0:4864:20::112f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qko6Z-00Ec1Y-0U for linux-arm-kernel@lists.infradead.org; Mon, 25 Sep 2023 16:06:40 +0000 Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-59f6441215dso37708697b3.2 for ; Mon, 25 Sep 2023 09:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695657996; x=1696262796; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=YXDWtOQmeuAoPzz9skUV+Rg0agfJNdRgLYNKTJX4bFE=; b=HaogEXgY3urfPcWc3O3gXramrEuGFzlR19TDEmmUrJWfgwJpxujD1EXPDVQ9augOks xtAfKjGrxtk0pFyI1Mr7HsPBY8oYgeqQjFLri8Ja/lIbgey/qhByXbAY3qBKVEJ0VBF6 nZQKRHZVc0BRRgAkozJ+PpchOH/9GVH3Z/p7OFlstwFySFbDDIKlL8OaRhrZKfIBubW+ mr1IoIUVyNjuKcJL85yLHyD9WaMPj25Py/dMdNtasE0aBUFQd3jHjPafPL23dgSNq3rR fM7jwNjN8RHtlTVTTUuWiaq1aCgSWSeL6VtUOVqmk/gpj3z7SPYBsxiKakxQN4DXnIHT qn4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695657996; x=1696262796; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YXDWtOQmeuAoPzz9skUV+Rg0agfJNdRgLYNKTJX4bFE=; b=s4GfqnK7aXEJY6ocxL3OXwLnXYTbsctNCg4R8IO4nfiJBBsdWdIZ2Eoe+na0fRW0pf lSGfXfrZe4jF9aD3GknUs4AoFbW/LVx7lBtqjj7KXSbhewo7mLIhMrGQ5kRb3UU7EwOv R9VlEMtrpVHumevXGYxUHAuNuPexyDwU6N0CQjZ70TsKmx/6UeyHCbHxOvKjP3vICWUC oMdx9nMJjyz6rsjUkzVeIKEj7LTcaZHr6DTVx3ijYRZXBEtLrFHzqHb5CcmIk4PBYZMP 1bs2NqJrusaIL/vZXTOhsXj2YWrd3/TKy4thwECr7+gwjIF3hXMHUBDllOHuFoYjlfVm 68oQ== X-Gm-Message-State: AOJu0YzxbaTxOMWDc+q/xzJ1yEER1vJurYTycc4PN0lKz7OEMutI7Joh P/5/lrFpgRayiVZXGVjPJfs= X-Google-Smtp-Source: AGHT+IFMcQAmfcNJw+f+wpOtJjOS55173Jrye276+Y6atM4/Yq6YsAerk37HlWIXHO75zkhdMVEEww== X-Received: by 2002:a81:4f92:0:b0:59b:ec11:7734 with SMTP id d140-20020a814f92000000b0059bec117734mr6926858ywb.39.1695657995751; Mon, 25 Sep 2023 09:06:35 -0700 (PDT) Received: from localhost ([2607:fb90:3eac:cd78:2863:6963:7d70:383c]) by smtp.gmail.com with ESMTPSA id c188-20020a0df3c5000000b0059293c8d70csm2473337ywf.132.2023.09.25.09.06.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 09:06:35 -0700 (PDT) Date: Mon, 25 Sep 2023 09:06:33 -0700 From: Yury Norov To: Alexander Potapenko Cc: Andy Shevchenko , catalin.marinas@arm.com, will@kernel.org, pcc@google.com, andreyknvl@gmail.com, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eugenis@google.com, syednwaris@gmail.com, william.gray@linaro.org Subject: Re: [PATCH v5 2/5] lib/test_bitmap: add tests for bitmap_{read,write}() Message-ID: References: <20230922080848.1261487-1-glider@google.com> <20230922080848.1261487-3-glider@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_090639_188239_8DCCC2A4 X-CRM114-Status: GOOD ( 28.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMjUsIDIwMjMgYXQgMDQ6NTQ6MDBQTSArMDIwMCwgQWxleGFuZGVyIFBvdGFw ZW5rbyB3cm90ZToKPiBPbiBNb24sIFNlcCAyNSwgMjAyMyBhdCAzOjA54oCvUE0gQWxleGFuZGVy IFBvdGFwZW5rbyA8Z2xpZGVyQGdvb2dsZS5jb20+IHdyb3RlOgo+ID4KPiA+IE9uIE1vbiwgU2Vw IDI1LCAyMDIzIGF0IDI6MjPigK9QTSBBbmR5IFNoZXZjaGVua28KPiA+IDxhbmRyaXkuc2hldmNo ZW5rb0BsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gPgo+ID4gPiBPbiBNb24sIFNlcCAyNSwg MjAyMyBhdCAwMjoxNjozN1BNICswMjAwLCBBbGV4YW5kZXIgUG90YXBlbmtvIHdyb3RlOgo+ID4g Pgo+ID4gPiAuLi4KPiA+ID4KPiA+ID4gPiA+ICsvKgo+ID4gPiA+ID4gKyAqIFRlc3QgYml0bWFw IHNob3VsZCBiZSBiaWcgZW5vdWdoIHRvIGluY2x1ZGUgdGhlIGNhc2VzIHdoZW4gc3RhcnQgaXMg bm90IGluCj4gPiA+ID4gPiArICogdGhlIGZpcnN0IHdvcmQsIGFuZCBzdGFydCtuYml0cyBsYW5k cyBpbiB0aGUgZm9sbG93aW5nIHdvcmQuCj4gPiA+ID4gPiArICovCj4gPiA+ID4gPiArI2RlZmlu ZSBURVNUX0JJVF9MRU4gKDEwMDApCj4gPiA+ID4KPiA+ID4gPiBEdW5ubyB3aHkgdGhpcyBkaWRu J3QgZmlyZSBwcmV2aW91c2x5LCBidXQgQ09ORklHX0NQVV9CSUdfRU5ESUFOPXkKPiA+ID4gPiBr ZXJuZWwgcmVwb3J0cyBtaXNtYXRjaGVzIGhlcmUsIHByZXN1bWFibHkgYmVjYXVzZSB0aGUgbGFz dCBxdWFkIHdvcmQKPiA+ID4gPiBlbmRzIHVwIHBhcnRpYWxseSBpbml0aWFsaXplZC4KPiA+ID4K PiA+ID4gSG1tLi4uIEJ1dCBpZiBkZXNpZ25lZCBhbmQgdXNlZCBjb3JyZWN0bHkgaXQgc2hvdWxk bid0IGJlIHRoZSBpc3N1ZSwKPiA+ID4gYW5kIDEwMDAsIEkgYmVsaWV2ZSwgaXMgY2FyZWZ1bGx5 IGNob3NlbiB0byBiZSBzcGVjaWZpY2FsbHkgbm90IGRpdmlkYWJsZQo+ID4gPiBieSBwb3ctb2Yt MiB2YWx1ZS4KPiA+ID4KPiA+Cj4gPiBUaGUgcHJvYmxlbSBtYW5pZmVzdHMgYWxyZWFkeSByaWdo dCBhZnRlciBpbml0aWFsaXphdGlvbjoKPiA+Cj4gPiBzdGF0aWMgdm9pZCBfX2luaXQgdGVzdF9i aXRfbGVuXzEwMDAodm9pZCkKPiA+IHsKPiA+ICAgICAgICAgREVDTEFSRV9CSVRNQVAoYml0bWFw LCBURVNUX0JJVF9MRU4pOwo+ID4gICAgICAgICBERUNMQVJFX0JJVE1BUChleHBfYml0bWFwLCBU RVNUX0JJVF9MRU4pOwo+ID4gICAgICAgICBtZW1zZXQoYml0bWFwLCAweDAwLCBURVNUX0JZVEVf TEVOKTsKPiA+ICAgICAgICAgbWVtc2V0KGV4cF9iaXRtYXAsIDB4MDAsIFRFU1RfQllURV9MRU4p Owo+ID4gICAgICAgICBleHBlY3RfZXFfYml0bWFwKGV4cF9iaXRtYXAsIGJpdG1hcCwgVEVTVF9C SVRfTEVOKTsKPiA+IH0KPiAKPiBUaGUgcHJvYmxlbSBpcyB0aGF0IHRoZXJlJ3Mgbm8gZGlyZWN0 IGFuYWxvZyBvZiBtZW1zZXQoKSB0aGF0IGNhbiBiZQo+IHVzZWQgdG8gaW5pdGlhbGl6ZSBiaXRt YXBzIG9uIGJvdGggQkUgYW5kIExFIHN5c3RlbXMuCgptZW1zZXQgZmlsbHMgYW4gYXJyYXkgb2Yg Y2hhcnMgd2l0aCB0aGUgc2FtZSB2YWx1ZS4gSW4gYml0bWFwIHdvcmxkIHdlIG9wZXJhdGUKb24g YXJyYXkgb2YgYml0cywgYW5kIHRoZXJlIGFyZSBvbmx5IDIgcG9zc2libGUgdmFsdWVzOiAnMCcg YW5kICcxJy4gRm9yIHRob3NlCndlJ3ZlIGdvdCBiaXRtYXBfemVybygpIGFuZCBiaXRtYXBfZmls bCgpLgoKPiBiaXRtYXBfemVybygpIGFuZCBiaXRtYXBfc2V0KCkgd29yayBieSByb3VuZGluZyB1 cCB0aGUgYml0bWFwIHNpemUgdG8KPiBCSVRTX1RPX0xPTkdTKG5iaXRzKSwgYnV0IHRoZXJlJ3Mg bm8gYml0bWFwX21lbXNldCgpIHRoYXQgd291bGQgZG8gdGhlCj4gc2FtZSBmb3IgYW4gYXJiaXRy YXJ5IGJ5dGUgcGF0dGVybi4KPiBXZSBjb3VsZCBjYWxsIG1lbXNldCguLi4sIC4uLiwgQklUU19U T19MT05HUyhURVNUX0JJVF9MRU4pKSwgYnV0IHRoYXQKPiB3b3VsZCBiZSBzaW1pbGFyIHRvIGRl Y2xhcmluZyBhIGJpZ2dlciBiaXRtYXAgYW5kIG5vdCB0ZXN0aW5nIHRoZSBsYXN0Cj4gMjQgYml0 cy4KCk5vLCB5b3UgY291bGRuJ3QuIE9uIHRoZSB0ZXN0IGxldmVsLCBiaXRtYXAgc2hvdWxkIGJl IGNvbnNpZGVyZWQgYXMgYQpibGFjayBib3guIG1lbXNldCgpJ2luZyBpdCBtYXkgKGFuZCBkaWQp IGRhbWFnZSBpbnRlcm5hbCBzdHJ1Y3R1cmUuCgpJZiB5b3UgaGF2ZSBzb21lIHBhdHRlcm4gaW4g bWluZCwgeW91IGNhbiB1c2UgYml0bWFwX3BhcnNlbGlzdCgpLiBGb3IgZXhhbXBsZSwKeW91IGNh biBzZXQgZXZlcnkgMm5kIGJpdCBpbiB5b3VyIGJpdG1hcCBsaWtlIHRoaXM6CgogICAgICAgIGJp dG1hcF9wYXJzZWxpc3QoImFsbDoxLzIiLCBiaXRtYXAsIDEwMDApOwoKQ2hlY2sgZm9yIGFsbW9z dCAxMDAgZXhhbXBsZXMgb2YgYml0bWFwX3BhcnNlbGlzdCB1c2FnZSBpbiB0aGUgdGVzdCBmb3IK Yml0bWFwX3BhcnNlbGlzdCBpbiB0aGUgc2FtZSBmaWxlLgoKPiBPdmVyYWxsLCB1bmxlc3MgYWxs b2NhdGluZyBhbmQgaW5pdGlhbGl6aW5nIGJpdG1hcHMgd2l0aCBzaXplCj4gZGl2aXNpYmxlIGJ5 IHNpemVvZihsb25nKSwgbW9zdCBvZiBiaXRtYXAuYyBpcyB1bmRlZmluZWQgYmVoYXZpb3IsIHNv Cj4gSSBkb24ndCB0aGluayBpdCBtYWtlcyBtdWNoIHNlbnNlIHRvIHNwZWNpZmljYWxseSB0ZXN0 IHRoaXMgY2FzZSBoZXJlCj4gKGdpdmVuIHRoYXQgd2UgZG8gbm90IGV4dGVuZCBiaXRtYXBfZXF1 YWwoKSBpbiB0aGUgcGF0Y2ggc2V0KS4KClRoaXMgaXMgd3Jvbmcgc3RhdGVtZW50LiBQZW9wbGUg c3BlbnQgaHVnZSBhbW91bnQgb2YgdGltZSBtYWtpbmcgYml0bWFwCkFQSSB3b3JraW5nIHdlbGwg Zm9yIGFsbCBjb21iaW5hdGlvbnMgb2YgbGVuZ3RocyBhbmQgZW5kaWFubmVzc2VzLAppbmNsdWRp bmcgQW5keSBhbmQgbWUuCgpOQUsgZm9yIHRoaXMgYW5kIGZvciBpZ25vcmluZyBteSBvdGhlciBj b21tZW50IHRvIHY0LgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E261ACE7A9A for ; Mon, 25 Sep 2023 16:06:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233019AbjIYQGr (ORCPT ); Mon, 25 Sep 2023 12:06:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232086AbjIYQGp (ORCPT ); Mon, 25 Sep 2023 12:06:45 -0400 Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD9E492 for ; Mon, 25 Sep 2023 09:06:36 -0700 (PDT) Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-59c0442a359so80564097b3.0 for ; Mon, 25 Sep 2023 09:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695657996; x=1696262796; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=YXDWtOQmeuAoPzz9skUV+Rg0agfJNdRgLYNKTJX4bFE=; b=HUZhslc+N5u/EQtjEyWqcZdENo1tM7avnZ1IgzAJaC9NgPejdaR7SQRJ4lvktB6tJu Qd86jWcrOXK38mjI27XtXA8gYpENW69FhFURSvikG5xk2pxa+3bSahkncXw4vpvXiIMy bP0esKCznCY961/71esxJl9LkZQCykLmsfU5BYH5HBPpEFUUEXEgyoMgPYANKETppbmE XNeLkJsD5eYcfv+XHbVzj84h2tYh2iRdV3wJDA/TKD7CW3PbQ6/Bd5fPUQRLPavdplrg Z1cDGL3tlYRnrkFMq5+QlcVwJqkJKnCZEC9sZ+CHVfnMqieIrKnqRpASF4qTdTEW5YKU M3/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695657996; x=1696262796; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YXDWtOQmeuAoPzz9skUV+Rg0agfJNdRgLYNKTJX4bFE=; b=Vv3UyIeu19K8zxIn7gKVojd3532q6IEczYpUzSO1eeH8QUss16Wdtfi1kRzeobGosB rzscdW0jhDKVI1xVNZYNZaVppFl+cN/gbyJgFuUVJZLP3gKtVbIoGWHbDUOGTDjao8Cc a2h3gZYr4+evvLlrUG9k8dyP9lZNop3wRFKaANDS+WRz+6dgED+C2oXfyU+0kGFyn2T5 klZ/OR+OrXrralKETWgTZ0OLD8kFBG8Iy/nFUiDyET2Qm3BwHRzXf9e7B0zMEvcEQkBZ vlTqI7MH5hiXf02Wc9jih3bGDCFlrhvtiY/HWdv5mIrvohQ94AGY8L3+uO1g9fYGqZAh E1pg== X-Gm-Message-State: AOJu0YwbeL9krdTk/6z2GrX636sBbFI5Oqk9bcFXVqkFaksCA2UR95P9 znoQlnwLCqRvc7Q69z7/9a4= X-Google-Smtp-Source: AGHT+IFMcQAmfcNJw+f+wpOtJjOS55173Jrye276+Y6atM4/Yq6YsAerk37HlWIXHO75zkhdMVEEww== X-Received: by 2002:a81:4f92:0:b0:59b:ec11:7734 with SMTP id d140-20020a814f92000000b0059bec117734mr6926858ywb.39.1695657995751; Mon, 25 Sep 2023 09:06:35 -0700 (PDT) Received: from localhost ([2607:fb90:3eac:cd78:2863:6963:7d70:383c]) by smtp.gmail.com with ESMTPSA id c188-20020a0df3c5000000b0059293c8d70csm2473337ywf.132.2023.09.25.09.06.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 09:06:35 -0700 (PDT) Date: Mon, 25 Sep 2023 09:06:33 -0700 From: Yury Norov To: Alexander Potapenko Cc: Andy Shevchenko , catalin.marinas@arm.com, will@kernel.org, pcc@google.com, andreyknvl@gmail.com, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eugenis@google.com, syednwaris@gmail.com, william.gray@linaro.org Subject: Re: [PATCH v5 2/5] lib/test_bitmap: add tests for bitmap_{read,write}() Message-ID: References: <20230922080848.1261487-1-glider@google.com> <20230922080848.1261487-3-glider@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 25, 2023 at 04:54:00PM +0200, Alexander Potapenko wrote: > On Mon, Sep 25, 2023 at 3:09 PM Alexander Potapenko wrote: > > > > On Mon, Sep 25, 2023 at 2:23 PM Andy Shevchenko > > wrote: > > > > > > On Mon, Sep 25, 2023 at 02:16:37PM +0200, Alexander Potapenko wrote: > > > > > > ... > > > > > > > > +/* > > > > > + * Test bitmap should be big enough to include the cases when start is not in > > > > > + * the first word, and start+nbits lands in the following word. > > > > > + */ > > > > > +#define TEST_BIT_LEN (1000) > > > > > > > > Dunno why this didn't fire previously, but CONFIG_CPU_BIG_ENDIAN=y > > > > kernel reports mismatches here, presumably because the last quad word > > > > ends up partially initialized. > > > > > > Hmm... But if designed and used correctly it shouldn't be the issue, > > > and 1000, I believe, is carefully chosen to be specifically not dividable > > > by pow-of-2 value. > > > > > > > The problem manifests already right after initialization: > > > > static void __init test_bit_len_1000(void) > > { > > DECLARE_BITMAP(bitmap, TEST_BIT_LEN); > > DECLARE_BITMAP(exp_bitmap, TEST_BIT_LEN); > > memset(bitmap, 0x00, TEST_BYTE_LEN); > > memset(exp_bitmap, 0x00, TEST_BYTE_LEN); > > expect_eq_bitmap(exp_bitmap, bitmap, TEST_BIT_LEN); > > } > > The problem is that there's no direct analog of memset() that can be > used to initialize bitmaps on both BE and LE systems. memset fills an array of chars with the same value. In bitmap world we operate on array of bits, and there are only 2 possible values: '0' and '1'. For those we've got bitmap_zero() and bitmap_fill(). > bitmap_zero() and bitmap_set() work by rounding up the bitmap size to > BITS_TO_LONGS(nbits), but there's no bitmap_memset() that would do the > same for an arbitrary byte pattern. > We could call memset(..., ..., BITS_TO_LONGS(TEST_BIT_LEN)), but that > would be similar to declaring a bigger bitmap and not testing the last > 24 bits. No, you couldn't. On the test level, bitmap should be considered as a black box. memset()'ing it may (and did) damage internal structure. If you have some pattern in mind, you can use bitmap_parselist(). For example, you can set every 2nd bit in your bitmap like this: bitmap_parselist("all:1/2", bitmap, 1000); Check for almost 100 examples of bitmap_parselist usage in the test for bitmap_parselist in the same file. > Overall, unless allocating and initializing bitmaps with size > divisible by sizeof(long), most of bitmap.c is undefined behavior, so > I don't think it makes much sense to specifically test this case here > (given that we do not extend bitmap_equal() in the patch set). This is wrong statement. People spent huge amount of time making bitmap API working well for all combinations of lengths and endiannesses, including Andy and me. NAK for this and for ignoring my other comment to v4.