Re: [PATCH] clk: renesas: rcar-gen3: Extend SDn divider table

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]


> > An alternative would be to let cpg_sdh_clk_register() sanitize the
> > pre-existing contents of the SD-IFn Clock Frequency Control Register,
> > so there would be no need to extend cpg_sdh_div_table[].  An advantage
> > of that approach would be that it can handle all invalid combinations,
> > not just the few that have been seen in the wild.
> > (following the old networking mantra: "be strict when sinding, be
> > liberal when receiving').
> 
> That sounds very reasonable to me.

Thinking further: Sanitizing a pre-existing value of SDH means also
sanitizing the value of SD because only specific combinations of these
are recommended (or even "allowed" as I read it). This is getting a bit
complicated. What about just applying a default value to SDH and SD
which is from the recommended set of parameters? That will also help
when probing the clocks. Once SDHI probes, it will modify clocks anyhow.

Opinions?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]