From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 020D8E7D27B for ; Tue, 26 Sep 2023 10:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229845AbjIZKf4 (ORCPT ); Tue, 26 Sep 2023 06:35:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbjIZKfz (ORCPT ); Tue, 26 Sep 2023 06:35:55 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50CB8BF; Tue, 26 Sep 2023 03:35:49 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-6907e44665bso7434152b3a.1; Tue, 26 Sep 2023 03:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695724549; x=1696329349; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JI22u4oFcSIyGcZiwVeeO4sm05tqY+QDbtPIh5RQo1w=; b=Ta95eXlBEe8uw1ZXLKbttCxboZ7Z64pposu2U2lP7kZAUWePPV9rF+HLpezhVEVAwH sddxCpWLi5XO8Jua08takSmakpQhqXTuXZBXi/yTyRFrgsMaIedi2uc38C1DY+i2Qeuz 0QxU+L5YHIPDLZ0WGfAxBjQDSDUU96toM6hUKjUk73p/SHUod+5CN3q0ckzKS3W9kzKz 4dwTeiPLtMX+Lpyr/uZ54CXeUcRtxy+wEswVFKPq/JaZqP5LieD4SGaxeBdH28M6L1En ntDYeBNu75IdsloukPn84TZJzvMfrfaBaTV34gfVwWHl99L1gvxGwh1E7BpczT5XyzaG NPaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695724549; x=1696329349; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JI22u4oFcSIyGcZiwVeeO4sm05tqY+QDbtPIh5RQo1w=; b=wXDjvDn74zOx7EfOULiZH1RqV/VDtSdp5UMTQBS5f8rPEY//TpS5CfgZ5z+J3aqWKI 6LMJcw/yzStSd9ufjUs3DsPhjvZcwjhirtG7HLNGn3BUyqYJNPLBRXPQDAdq0AXlLWWW e7WHCNuyu4reksBuI6Rr6hYODDCSSzrSQ/IPwB4MVTLcPAKArnGOVbY1j+NyOkKPPTJM bvNnUe500EMjjgLqwXal3L+NhdmcxRfoByLoMuLn5xQewgv4OBZnUXvDK+qO5wDDZ5K8 IZZetE3TX8lFJH+kReczo4GcF0h30RuCtVexNphb03KmYMWXLGGylHRsi/GEqmE5y6Ef zAvQ== X-Gm-Message-State: AOJu0Yx54JI7AtVIeW/w41girBqT9QmEz1Sh6g/Un7/QNULfS8sk3qyu LrTcnD59eDiSgjBcv4lOJKw= X-Google-Smtp-Source: AGHT+IHPgxQLC3Tuaq5fkXY5EnNUthvz5JnG4AAGGsD5gZCBIyiEtOP5iIEm+MeIHUqJYXsXLl7SMg== X-Received: by 2002:a05:6a00:a22:b0:691:21:d9b7 with SMTP id p34-20020a056a000a2200b006910021d9b7mr10322863pfh.27.1695724548760; Tue, 26 Sep 2023 03:35:48 -0700 (PDT) Received: from sol (14-201-140-18.tpgi.com.au. [14.201.140.18]) by smtp.gmail.com with ESMTPSA id q18-20020a638c52000000b0058264a3c942sm3792389pgn.69.2023.09.26.03.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 03:35:48 -0700 (PDT) Date: Tue, 26 Sep 2023 18:35:40 +0800 From: Kent Gibson To: Andy Shevchenko Cc: Linus Walleij , Bartosz Golaszewski , Yury Norov , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Bartosz Golaszewski , Andy Shevchenko , Rasmus Villemoes , Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH v1 1/5] lib/test_bitmap: Excape space symbols when printing input string Message-ID: References: <20230926052007.3917389-1-andriy.shevchenko@linux.intel.com> <20230926052007.3917389-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230926052007.3917389-2-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Sep 26, 2023 at 08:20:03AM +0300, Andy Shevchenko wrote: > test_bitmap_printlist() prints the input string which contains > a new line character. Instead of stripping it, escape that kind > of characters, so developer will see the actual input string Grammar nit: "that kind of characters" -> "those kinds of characters" or "that kind of character" or "such characters" or ... > that has been used. Without this change the new line splits > the string to two, and the first one is not guaranteed to be > followed by the first part immediatelly. immediately And the second "first" should be "second"?? "the second part is not guaranteed to immediately follow the first" is clearer (and hopefully what you mean), IMHO. Cheers, Kent. > > Signed-off-by: Andy Shevchenko > --- > lib/test_bitmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c > index f2ea9f30c7c5..1f2dc7fef17f 100644 > --- a/lib/test_bitmap.c > +++ b/lib/test_bitmap.c > @@ -523,7 +523,7 @@ static void __init test_bitmap_printlist(void) > goto out; > } > > - pr_err("bitmap_print_to_pagebuf: input is '%s', Time: %llu\n", buf, time); > + pr_err("bitmap_print_to_pagebuf: input is '%*pEs', Time: %llu\n", ret, buf, time); > out: > kfree(buf); > kfree(bmap); > -- > 2.40.0.1.gaa8946217a0b > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B1D6E7D27B for ; Tue, 26 Sep 2023 10:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gsuXlH2te0In/b7iVpVkE+CW5+6zEjQo9c2NJsdcWiE=; b=A22n2B/Rh0/x9a TgbsYWNgn13oeFk1GPokr3Van84BNYyeuxKCveoW3qcihBNjmnlMoTD+M/CAuvvBr/6dC4b+giVNC O2oWEQrljaWvhNfXcGKoUR2UCoX2Ucu0/wQ2BCzrau82JvipPmkjOgEfgWS+xfSyxiH8Qvwwjl7Sc l+CyUZLfPJl21FCTzf+pqMQoNB/GSNLT//Qb4aZTg1xgIDpcaDoQHHa6QvNkdB5ARCnIMqSqqvLqE onFiG/tn4gMw4lXUMZv5GgfbZdPTSbc4y9MBCZ6uciJCsKenkHDhdN02KfBant31NocaWk6N/AnFx /XaWlk/7njSzdZJYUY+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ql5Q2-00G6iL-2X; Tue, 26 Sep 2023 10:35:54 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ql5Pz-00G6eS-0i for linux-arm-kernel@lists.infradead.org; Tue, 26 Sep 2023 10:35:52 +0000 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-690fa0eea3cso7462277b3a.0 for ; Tue, 26 Sep 2023 03:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695724549; x=1696329349; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JI22u4oFcSIyGcZiwVeeO4sm05tqY+QDbtPIh5RQo1w=; b=XWlLJq2Cs4O+eBuri5DgXVma6eFXnoPaR96yoHzsRHdbJ2IwfboOM6WyCZQgA/+850 /6EudctVHcSlLTNtlEXqMKXD596wlrvjspi+M627wF4VnvMZ7X226VslsJRIc4Hr/bLK IL3ibmgfv66aI9BCQjreWRNArsc3WGwkFg57CKMIrXrZHzC/mfQndH3wATWiKSMSNu2N QOouHshJGzz1w967i2dW0IsbbphMEkcu2GPk8N3h0ak1Xoq/mG2iX2qUeQ1V2zCf80/A asiBkSccBj+KeOU6NaRxbNJeMcXUNT7lvNvjVan5iZPsWTgiYrBtBpfW1qZ4ELrMC7yk 9s5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695724549; x=1696329349; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JI22u4oFcSIyGcZiwVeeO4sm05tqY+QDbtPIh5RQo1w=; b=joKUZxFhnSCEFPWYmzfZqEf7n8Btlb+PRo0zyiKefMcA3Gzaj2FcFBshgYVKiww7HX n2Ro1zx0g+a93MVODRLEti5B7vlK7CbRsdRG24ytCUVIypRqKx90nT33+538NPWRGjJo TXs3RtCJ56OLZzo+nZtMDoPWiHhORoC/yJO2TpciQn+T8UZyApDX9ADUtKBJNPPdX6M1 afpUtL38ZaxqB3Ljkmw8wI0z2Vkv1LNldmaTg2AuyBt52vdjW5/wvgMdT0TS7MGYwc5Z nrXJh1mO7+LjuZ8RIG+Nsy6JddkCgSVRoGmZ1v/IBNM96vkviEwd3m1cTmKhHUYOtQ7m kpkA== X-Gm-Message-State: AOJu0YzFDKPADQeHk+Wd9WsaYqZjZ+9RC8sE/i75SIqs14YV8KyfVSt7 bS1A1oVZC9YAtosuL388K8U= X-Google-Smtp-Source: AGHT+IHPgxQLC3Tuaq5fkXY5EnNUthvz5JnG4AAGGsD5gZCBIyiEtOP5iIEm+MeIHUqJYXsXLl7SMg== X-Received: by 2002:a05:6a00:a22:b0:691:21:d9b7 with SMTP id p34-20020a056a000a2200b006910021d9b7mr10322863pfh.27.1695724548760; Tue, 26 Sep 2023 03:35:48 -0700 (PDT) Received: from sol (14-201-140-18.tpgi.com.au. [14.201.140.18]) by smtp.gmail.com with ESMTPSA id q18-20020a638c52000000b0058264a3c942sm3792389pgn.69.2023.09.26.03.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 03:35:48 -0700 (PDT) Date: Tue, 26 Sep 2023 18:35:40 +0800 From: Kent Gibson To: Andy Shevchenko Cc: Linus Walleij , Bartosz Golaszewski , Yury Norov , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Bartosz Golaszewski , Andy Shevchenko , Rasmus Villemoes , Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH v1 1/5] lib/test_bitmap: Excape space symbols when printing input string Message-ID: References: <20230926052007.3917389-1-andriy.shevchenko@linux.intel.com> <20230926052007.3917389-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230926052007.3917389-2-andriy.shevchenko@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230926_033551_261122_CF9C27FB X-CRM114-Status: GOOD ( 20.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 26, 2023 at 08:20:03AM +0300, Andy Shevchenko wrote: > test_bitmap_printlist() prints the input string which contains > a new line character. Instead of stripping it, escape that kind > of characters, so developer will see the actual input string Grammar nit: "that kind of characters" -> "those kinds of characters" or "that kind of character" or "such characters" or ... > that has been used. Without this change the new line splits > the string to two, and the first one is not guaranteed to be > followed by the first part immediatelly. immediately And the second "first" should be "second"?? "the second part is not guaranteed to immediately follow the first" is clearer (and hopefully what you mean), IMHO. Cheers, Kent. > > Signed-off-by: Andy Shevchenko > --- > lib/test_bitmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c > index f2ea9f30c7c5..1f2dc7fef17f 100644 > --- a/lib/test_bitmap.c > +++ b/lib/test_bitmap.c > @@ -523,7 +523,7 @@ static void __init test_bitmap_printlist(void) > goto out; > } > > - pr_err("bitmap_print_to_pagebuf: input is '%s', Time: %llu\n", buf, time); > + pr_err("bitmap_print_to_pagebuf: input is '%*pEs', Time: %llu\n", ret, buf, time); > out: > kfree(buf); > kfree(bmap); > -- > 2.40.0.1.gaa8946217a0b > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel