From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58DEBE7E657 for ; Tue, 26 Sep 2023 17:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9dpEDx7mSracOPS/q+Zn6GSqLmumKCPg+O+O531LdqE=; b=s34UoOMk0VD6ah us7RPnHFHOvb0uhTpOR19DmtAlDy21nYY44Fs9P389XkZHrLKPS4ZfKqASrxMaAQL6WYzd/qzbT2Y nd1jTdxuOs43Xwa9cBc3BYZgT9eUXJnjcCp96sNXojzGZs2TliJDCoCCtFGJp+IXS7lfrpGV6PFCx nZvTrAkHXk8IB818RbUa9xzDGcFZ8+2RMUi3SOzOckNN9muDNySe4u1UvHRkFGfg98x3Hfr5nBvhc FbZv6JCmutyzLOmTahRILsVUpq4voW8hj+vKTb3GpSG8VrOr4724HmqHb8MVq3RynuksnW6qYdmZV t/saRyVpiVgNfC+RuuZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qlBtX-00GmtZ-1Z; Tue, 26 Sep 2023 17:30:47 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qlBtT-00GmgI-1x for linux-arm-kernel@lists.infradead.org; Tue, 26 Sep 2023 17:30:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rG/CnIilUKIx4ZX6uO8pwj0iKoMPMtAHHOSA84Y3klc=; b=oL6KmepzwMN9ufGtDVxIlPLOip Bk9seHkrZWGWXfzn+vKMHLBSAw85EFiILd4DQw0SqVrMxBA2na3iCTVMJnbhGa+ykUY2jbeKuZ4wI w0nDkRSDQVU+NF8Bc1j+VIyUsGv5/xo4ZOK9KRejACxssMau/JA0LIyt2zAYCsEEjIgTZxC/pggej zVMfDP+GNNgMHBjojyriUnMWYI+dtctGLwat71ADQNTHUAyCw0V18eJFV9GQbvuGJ+RA7CVHwo0MT H/sPvlLIrZOWvRCrIu/8LBHZto57abnEpwSDzHEQqNecEpBD6rwPu/eLZJoEhY4RQcGoEZqf7rjey 4QFknl2w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55628) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qlBrN-0002jh-1F; Tue, 26 Sep 2023 18:28:33 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qlBrM-0000aU-Nt; Tue, 26 Sep 2023 18:28:32 +0100 Date: Tue, 26 Sep 2023 18:28:32 +0100 From: "Russell King (Oracle)" To: Masahiro Yamada Cc: patches@armlinux.org.uk, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: make self-contained for ARM Message-ID: References: <20230926172253.73204-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230926172253.73204-1-masahiroy@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230926_103043_642637_882EFE4D X-CRM114-Status: GOOD ( 10.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 27, 2023 at 02:22:53AM +0900, Masahiro Yamada wrote: > When I compiled the following code for ARM, I encountered numerous > errors. > > [Test Code] > > #include > #include > > int foo(int *x, int __user *ptr) > { > return get_user(*x, ptr); > } > > To fix them, make some asm headers self-contained: > > 1. In arch/arm/include/asm/traps.h, include for __init, > and for asmlinkage. Please drop the __init marking instead of adding linux/init.h, it's not necessary. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E4F8E7E657 for ; Tue, 26 Sep 2023 17:28:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233424AbjIZR2u (ORCPT ); Tue, 26 Sep 2023 13:28:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232053AbjIZR2s (ORCPT ); Tue, 26 Sep 2023 13:28:48 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 451EEDC for ; Tue, 26 Sep 2023 10:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rG/CnIilUKIx4ZX6uO8pwj0iKoMPMtAHHOSA84Y3klc=; b=oL6KmepzwMN9ufGtDVxIlPLOip Bk9seHkrZWGWXfzn+vKMHLBSAw85EFiILd4DQw0SqVrMxBA2na3iCTVMJnbhGa+ykUY2jbeKuZ4wI w0nDkRSDQVU+NF8Bc1j+VIyUsGv5/xo4ZOK9KRejACxssMau/JA0LIyt2zAYCsEEjIgTZxC/pggej zVMfDP+GNNgMHBjojyriUnMWYI+dtctGLwat71ADQNTHUAyCw0V18eJFV9GQbvuGJ+RA7CVHwo0MT H/sPvlLIrZOWvRCrIu/8LBHZto57abnEpwSDzHEQqNecEpBD6rwPu/eLZJoEhY4RQcGoEZqf7rjey 4QFknl2w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55628) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qlBrN-0002jh-1F; Tue, 26 Sep 2023 18:28:33 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qlBrM-0000aU-Nt; Tue, 26 Sep 2023 18:28:32 +0100 Date: Tue, 26 Sep 2023 18:28:32 +0100 From: "Russell King (Oracle)" To: Masahiro Yamada Cc: patches@armlinux.org.uk, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: make self-contained for ARM Message-ID: References: <20230926172253.73204-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230926172253.73204-1-masahiroy@kernel.org> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 27, 2023 at 02:22:53AM +0900, Masahiro Yamada wrote: > When I compiled the following code for ARM, I encountered numerous > errors. > > [Test Code] > > #include > #include > > int foo(int *x, int __user *ptr) > { > return get_user(*x, ptr); > } > > To fix them, make some asm headers self-contained: > > 1. In arch/arm/include/asm/traps.h, include for __init, > and for asmlinkage. Please drop the __init marking instead of adding linux/init.h, it's not necessary. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!