All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: arm_scmi: Do not use !! on boolean when setting msg->flags
Date: Wed, 27 Sep 2023 12:00:23 +0100	[thread overview]
Message-ID: <ZRQLNwGiRsTQESs4@pluto> (raw)
In-Reply-To: <20230921085257.3125744-1-sudeep.holla@arm.com>

On Thu, Sep 21, 2023 at 09:52:57AM +0100, Sudeep Holla wrote:
> Both pc->async_powercap_cap_set and ignore_dresp are already boolean.
> Use of !! on them is obviously dubious.
> 
> Sparse reports:
> drivers/firmware/arm_scmi/powercap.c:363:17: warning: dubious: x & !y
> drivers/firmware/arm_scmi/powercap.c:363:17: warning: dubious: x & !y
> 

Hi,

LGTM, indeed I was seeing that report too since a while, just I did not
realize why.

Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>

Thanks,
Cristian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-09-27 11:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21  8:52 [PATCH] firmware: arm_scmi: Do not use !! on boolean when setting msg->flags Sudeep Holla
2023-09-27 11:00 ` Cristian Marussi [this message]
2023-09-27 13:12 ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZRQLNwGiRsTQESs4@pluto \
    --to=cristian.marussi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.