From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/dsb: DSB code refactoring
Date: Wed, 27 Sep 2023 16:50:33 +0300 [thread overview]
Message-ID: <ZRQzKU1ePbiqDtUJ@intel.com> (raw)
In-Reply-To: <87v8bxl1lg.fsf@intel.com>
On Tue, Sep 26, 2023 at 12:34:35PM +0300, Jani Nikula wrote:
> On Tue, 26 Sep 2023, "Manna, Animesh" <animesh.manna@intel.com> wrote:
> >> -----Original Message-----
> >> From: Jani Nikula <jani.nikula@linux.intel.com>
> >> Sent: Monday, September 25, 2023 6:00 PM
> >> To: Manna, Animesh <animesh.manna@intel.com>; intel-
> >> gfx@lists.freedesktop.org
> >> Subject: Re: [Intel-gfx] [PATCH] drm/i915/dsb: DSB code refactoring
> >>
> >> On Sat, 23 Sep 2023, Animesh Manna <animesh.manna@intel.com> wrote:
> >> > Refactor DSB implementation to be compatible with Xe driver.
> >>
> >> Sad trombone.
> >>
> >> struct intel_dsb should remain an opaque type. I put effort into hiding its
> >> definition, so its guts wouldn't be accessed nilly-willy all over the place. If it's
> >> not hidden, it just will get accessed.
> >
> > Hi Jani,
> >
> > Xe driver need access to intel_dsb structure, so I can create a new header file intel_dsb_ops.h and keep intel_dsb structure in it. Is it ok?
>
> I just think you need to find a different abstraction level that doesn't
> involve exposing struct intel_dsb.
I hate the fact that we seem to be adding these ad-hoc wrappers all
over the place. Someone should just fix xe to give us the same API as
i915, or a single wrapper should do whatever conversion is needed.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2023-09-27 13:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 19:35 [Intel-gfx] [PATCH] drm/i915/dsb: DSB code refactoring Animesh Manna
2023-09-23 3:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-09-23 3:51 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-23 4:08 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-09-25 12:30 ` [Intel-gfx] [PATCH] " Jani Nikula
2023-09-26 7:13 ` Manna, Animesh
2023-09-26 9:34 ` Jani Nikula
2023-09-27 13:50 ` Ville Syrjälä [this message]
2023-09-27 14:50 ` Jani Nikula
2023-09-27 15:07 ` Ville Syrjälä
2023-09-27 16:04 ` Jani Nikula
2023-09-27 16:17 ` Ville Syrjälä
-- strict thread matches above, loose matches on Subject: below --
2023-09-27 9:11 Animesh Manna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRQzKU1ePbiqDtUJ@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.