From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA7D8E82CA6 for ; Wed, 27 Sep 2023 15:48:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232930AbjI0PsN (ORCPT ); Wed, 27 Sep 2023 11:48:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232820AbjI0PsC (ORCPT ); Wed, 27 Sep 2023 11:48:02 -0400 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81CED29177 for ; Wed, 27 Sep 2023 08:47:29 -0700 (PDT) Received: from [78.30.34.192] (port=52856 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qlWl3-00DG3k-1H; Wed, 27 Sep 2023 17:47:27 +0200 Date: Wed, 27 Sep 2023 17:47:24 +0200 From: Pablo Neira Ayuso To: Phil Sutter , netfilter-devel@vger.kernel.org Subject: Re: [PATCH nft] tests: shell: fix spurious errors in sets/0036add_set_element_expiration_0 Message-ID: References: <20230927144803.138869-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Sep 27, 2023 at 05:32:31PM +0200, Pablo Neira Ayuso wrote: > On Wed, Sep 27, 2023 at 05:02:04PM +0200, Phil Sutter wrote: > > On Wed, Sep 27, 2023 at 04:48:03PM +0200, Pablo Neira Ayuso wrote: > > > Add seconds as expiration, otherwise 14m59 reports 14m in minute > > > granularity, this ensures suficient time in a very slow environment with > > > debugging instrumentation. > > > > > > Fixes: adf38fd84257 ("tests: shell: use minutes granularity in sets/0036add_set_element_expiration_0") > > > Signed-off-by: Pablo Neira Ayuso > > > --- > > > I still see this failing occasionally due to timing issues, fix it. > > > > > > tests/shell/testcases/sets/0036add_set_element_expiration_0 | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/tests/shell/testcases/sets/0036add_set_element_expiration_0 b/tests/shell/testcases/sets/0036add_set_element_expiration_0 > > > index 12f10074409f..a50ac91d43a6 100755 > > > --- a/tests/shell/testcases/sets/0036add_set_element_expiration_0 > > > +++ b/tests/shell/testcases/sets/0036add_set_element_expiration_0 > > > @@ -8,7 +8,7 @@ drop_seconds() { > > > > > > RULESET="add table ip x > > > add set ip x y { type ipv4_addr; flags dynamic,timeout; } > > > -add element ip x y { 1.1.1.1 timeout 30m expires 15m }" > > > +add element ip x y { 1.1.1.1 timeout 30m expires 15m59s }" > > > > > > test_output=$($NFT -e -f - <<< "$RULESET" 2>&1 | grep -v '# new generation' | drop_seconds) > > > > The next line in that file is: > > > > | if [ "$test_output" != "$RULESET" ] ; then > > > > You add "59s" to $RULESET and drop it from $test_output. I guess, to > > make it work, you also need to pipe $RULESET through drop_seconds before > > the comparison. > > Indeed, apologies: See latest patch. > > https://patchwork.ozlabs.org/project/netfilter-devel/patch/20230927152514.473765-1-pablo@netfilter.org/ Ouch, still fails. Damn, I don't get a proper fix for this script.