From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, balaton@eik.bme.hu
Subject: Re: [PATCH 01/13] ui/vnc: Require audiodev= to enable audio
Date: Thu, 28 Sep 2023 09:15:06 +0100 [thread overview]
Message-ID: <ZRU2Cp9GiAAezGOE@redhat.com> (raw)
In-Reply-To: <20230928073705.871327-2-pbonzini@redhat.com>
On Thu, Sep 28, 2023 at 09:36:45AM +0200, Paolo Bonzini wrote:
> If there is no audiodev do not send the audio ack in response to
> VNC_ENCODING_AUDIO, so that clients aren't told audio exists, and
> immediately drop the client if they try to send any audio control messages
> when audio is not advertised.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> docs/about/deprecated.rst | 8 +++-----
> docs/about/removed-features.rst | 6 ++++++
> ui/vnc.c | 11 ++++++++++-
> ui/vnc.h | 2 ++
> 4 files changed, 21 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-09-28 8:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 7:36 [PATCH v2 00/13] Cleanup deprecated audio features, take 2 Paolo Bonzini
2023-09-28 7:36 ` [PATCH 01/13] ui/vnc: Require audiodev= to enable audio Paolo Bonzini
2023-09-28 8:15 ` Daniel P. Berrangé [this message]
2023-09-28 7:36 ` [PATCH 02/13] audio: Require AudioState in AUD_add_capture Paolo Bonzini
2023-09-28 7:36 ` [PATCH 03/13] audio: allow returning an error from the driver init Paolo Bonzini
2023-09-28 8:16 ` Daniel P. Berrangé
2023-09-28 7:36 ` [PATCH 04/13] audio: return Error ** from audio_state_by_name Paolo Bonzini
2023-09-28 7:36 ` [PATCH 05/13] audio: commonize voice initialization Paolo Bonzini
2023-09-28 7:36 ` [PATCH 06/13] audio: simplify flow in audio_init Paolo Bonzini
2023-09-28 7:36 ` [PATCH 07/13] audio: remove QEMU_AUDIO_* and -audio-help support Paolo Bonzini
2023-09-28 7:36 ` [PATCH 08/13] Introduce machine property "audiodev" Paolo Bonzini
2023-09-28 11:46 ` BALATON Zoltan
2023-09-28 7:36 ` [PATCH 09/13] hw/arm: Support machine-default audiodev with fallback Paolo Bonzini
2023-09-28 7:36 ` [PATCH 10/13] hw/ppc: " Paolo Bonzini
2023-09-28 7:36 ` [PATCH 11/13] vt82c686: " Paolo Bonzini
2023-09-28 7:36 ` [PATCH 12/13] audio: forbid mixing default audiodev backend and -audiodev Paolo Bonzini
2023-09-28 7:36 ` [PATCH 13/13] audio: forbid default audiodev backend with -nodefaults Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2023-10-02 14:57 [PATCH v4 00/13] Cleanup deprecated audio features, take 2 Paolo Bonzini
2023-10-02 14:57 ` [PATCH 01/13] ui/vnc: Require audiodev= to enable audio Paolo Bonzini
2023-09-23 8:54 [PATCH 00/13] Cleanup deprecated audio features, take 2 Paolo Bonzini
2023-09-23 8:54 ` [PATCH 01/13] ui/vnc: Require audiodev= to enable audio Paolo Bonzini
2023-09-25 9:05 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRU2Cp9GiAAezGOE@redhat.com \
--to=berrange@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.