From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 155CACE7AF8 for ; Thu, 28 Sep 2023 05:17:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qljOW-00040o-Oy; Thu, 28 Sep 2023 01:17:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qljOR-00040O-Sn for grub-devel@gnu.org; Thu, 28 Sep 2023 01:16:56 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qljOO-0006bF-5d for grub-devel@gnu.org; Thu, 28 Sep 2023 01:16:54 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-317c3ac7339so11990118f8f.0 for ; Wed, 27 Sep 2023 22:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695878209; x=1696483009; darn=gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=MGtjuEzElPwlz2+yW1WnqMITnalRVYGcoGaYQXBnIGU=; b=NX7RLO72/9I8JU7jcHsrhvVEOsp1cMmIoMUTchxxHOoyZ11wmdj3s3P5IWSJwCC+Ds VGP7+Tf39LN7HNCtlGHqfCszAaF1mqLoBE1gILjDLPMGjm7HIqgYc9Oa8aZlkfsOXoRd o7yuWlZaeTNwXn8lQf2Z+Dlt1AOfSEt3L4bAZHGfN1UqjBo1kV2/HQeoEyXIg2VH4zl7 S7fC2Z6Q9XDgqgbm1TdC9Kd5aLPzK7uAPBTUZYy8NoEMq/aF4IVWtF3JTLy7oOybVMaY Y6s8mVqDcYxOH4AJ3+Q20rTJSds0Y8+UsRJ4/wFC3ikhIfNG7PjMHKs5n3XGYGPn/gGz CM7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695878209; x=1696483009; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MGtjuEzElPwlz2+yW1WnqMITnalRVYGcoGaYQXBnIGU=; b=TyMcTICGuYsuqFVyD5Kr6yw7oUF1Y9sBQvsPizomp/dOeTLtoU3Yw8/rIx0Hrj44f3 14oGH2C0GxkTyvmuhU2sGJ+dUReACqrUfuSEyt2h98JNFzz/2sYgtGZrQvKrlc0kW9Jr 4PBHKep6+bh9UGE/K1rXFVnqSEQjHC0iTzglIFrK5JZeazAjalc7pjO5SARCkjp3hHfS NcLHgHj4L9+J6oMHh0AI6xVDfR0FUUUMBpad9PiZ1iKwIHhDl+itAukCYblhjNf+eOHz 5Bkin/o0CtyPEKKVafEbKa5V5xlWHqkyyv09ZvQeZoILGyj85wZgKO3CHxMkIrBBgj+p MW8A== X-Gm-Message-State: AOJu0YwBTjwD69vmG4jvGOdF0hWgWE0tg6vxXQazfhP8nW/y6pyXGl5D 3f9UbEfQQ4hLLrX9i4uWegbDX4XYsnA= X-Google-Smtp-Source: AGHT+IHf6AD69wJ/W3RbPmFO4X4IDwqns1cBsWS9YvTLwdkClffF6Qyb2yNq7/hQW9ddvdGWDGPXJg== X-Received: by 2002:a5d:668a:0:b0:321:5969:d465 with SMTP id l10-20020a5d668a000000b003215969d465mr189337wru.65.1695878209032; Wed, 27 Sep 2023 22:16:49 -0700 (PDT) Received: from dj3ntoo (161.sub-97-139-114.myvzw.com. [97.139.114.161]) by smtp.gmail.com with ESMTPSA id f2-20020a7bc8c2000000b003fefaf299b6sm7647129wml.38.2023.09.27.22.16.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 22:16:48 -0700 (PDT) Date: Thu, 28 Sep 2023 00:16:43 -0500 From: Oskari Pirhonen To: darkpenguin Cc: grub-devel@gnu.org Subject: Re: [PATCH] Allow specifying the boot device by its label instead of UUID Message-ID: Mail-Followup-To: darkpenguin , grub-devel@gnu.org References: <2dc8c8a0-c52a-4a1d-8112-a3a628df1df6@gmx.de> <20230927162523.664433-1-darkpenguin@posteo.de> MIME-Version: 1.0 In-Reply-To: <20230927162523.664433-1-darkpenguin@posteo.de> Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=xxc3ncoredxx@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The development of GNU GRUB Content-Type: multipart/mixed; boundary="===============5689888908501030146==" Errors-To: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org Sender: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org --===============5689888908501030146== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s+k1YtyW2R+dkk9T" Content-Disposition: inline --s+k1YtyW2R+dkk9T Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I know you're just learning, so here's some more tips: Updated patches are generally sent as a "vN" where N is the revision of the series. `git format-patch` can do this nicely with the `-v` arg. This would make the subject line look like "[PATCH vN] Allow specifying the boot device by its label instead of UUID". Updated patches are also typically sent as a new thread instead of as a reply to the old one. Makes for easier review. On Wed, Sep 27, 2023 at 16:25:23 +0000, darkpenguin wrote: > Here it is, as a single patch, and in reply to the corresponding thread t= his time! >=20 The way git handles patches, applying this would make the above sentence the commit message. Which is probably not what you were after. > --- > util/grub-mkconfig.in | 1 + > util/grub-mkconfig_lib.in | 14 +++++++++++--- > util/grub.d/10_linux.in | 3 +++ > 3 files changed, 15 insertions(+), 3 deletions(-) >=20 > diff --git a/util/grub-mkconfig.in b/util/grub-mkconfig.in > index 32c480dae..fb5000d3f 100644 > --- a/util/grub-mkconfig.in > +++ b/util/grub-mkconfig.in > @@ -244,6 +244,7 @@ export GRUB_DEFAULT \ > GRUB_DISABLE_UUID \ > GRUB_DISABLE_LINUX_UUID \ > GRUB_DISABLE_LINUX_PARTUUID \ > + GRUB_ENABLE_LINUX_LABEL \ I still think this should be GRUB_DISABLE_LINUX_LABEL to match the other vars. > GRUB_DISABLE_RECOVERY \ > GRUB_VIDEO_BACKEND \ > GRUB_GFXMODE \ - Oskari --s+k1YtyW2R+dkk9T Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQfOU+JeXjo4uxN6vCp8he9GGIfEQUCZRUMNgAKCRCp8he9GGIf Ebt3AQDUKRGPEzdWGLe1HOj5cn9+PuGTn8IuurWMX740HIUFKwD/ahAeOEN7R8a2 IGNaN5jZhJ9cuxrP8pL4kYshBJ4lcQM= =0kRz -----END PGP SIGNATURE----- --s+k1YtyW2R+dkk9T-- --===============5689888908501030146== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KR3J1Yi1kZXZl bCBtYWlsaW5nIGxpc3QKR3J1Yi1kZXZlbEBnbnUub3JnCmh0dHBzOi8vbGlzdHMuZ251Lm9yZy9t YWlsbWFuL2xpc3RpbmZvL2dydWItZGV2ZWwK --===============5689888908501030146==--