From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F4F1CE7B11 for ; Thu, 28 Sep 2023 09:27:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD2856B0196; Thu, 28 Sep 2023 05:27:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C82826B0197; Thu, 28 Sep 2023 05:27:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B70F76B0198; Thu, 28 Sep 2023 05:27:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A50156B0196 for ; Thu, 28 Sep 2023 05:27:21 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 715FB140AE2 for ; Thu, 28 Sep 2023 09:27:21 +0000 (UTC) X-FDA: 81285477882.06.B1D5667 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id C93868000D for ; Thu, 28 Sep 2023 09:27:19 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf02.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695893239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kfMlnU0WELdTxGavg/y+kvHdiPjsTKlnm3NEmu1KNZY=; b=lYeZm+WjhXkOUROhv9FyMo6fxSUiWcCoEsxyalb4bdra0phH2K0aoGcfSl+hSkyTS/m1Xg drnAJ1q05K5+TqubTdj/OK6C9OfcEb5mGEYWciklI1RrO1KGzTMCS55/mrq2Frq4kpXo5z qbW4/IAjfKd2W/tAobj5s8s6v/f9IVA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf02.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695893239; a=rsa-sha256; cv=none; b=qz3trA7Wxp0Xv0XWerYTRqFh1WxTP1NOVF8vgiGJ85/I+daRg141xnQPn5S0bAotI0p0MY fypXuiatgTqKkjIzsyuvqrc5fAd8b08wp7F9YdCGsT7vj32l3/vM13ECxcsyjTqf98Ogah ROVk8ILiCYsz0ezyXN09nI7oV0YBy2w= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D3121601BC; Thu, 28 Sep 2023 09:27:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4432DC433C8; Thu, 28 Sep 2023 09:27:17 +0000 (UTC) Date: Thu, 28 Sep 2023 10:27:14 +0100 From: Catalin Marinas To: Liu Shixin Cc: Patrick Wang , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm/kmemleak: fix print format of pointer in pr_debug() Message-ID: References: <20230927035923.1425340-1-liushixin2@huawei.com> <20230927035923.1425340-4-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230927035923.1425340-4-liushixin2@huawei.com> X-Rspamd-Queue-Id: C93868000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: h9rdd1kbuoagiibn93tjcriwbwm9j7ko X-HE-Tag: 1695893239-270374 X-HE-Meta: U2FsdGVkX19amoX4P8r5bAwNfS6MeOyK+xOGMoW8LztBmOkrZCn7U7s4+JuG8g2MZXKxvpqzVarJZC1Xu8YRj8aL8CBWX1zEQvgWngqN8UGUL8MbHlp7kdqShpPI8XygW/0Q8zsfytN+vGTJuCiffInL5NIBdcuZ0QkuR+Ko0tE818Oywh6tUtEZ57sI2HJuPkfjyQXoU3coZp3alTP7jknH1Y0ga/6u8Yd0iQJUR5XsPX2K6qqKgJS9d0rwCl4s6+QzPj0LW23RqUSK56f4xFN5S74nNd+XaDq6d1/rOgPNw93YrndSIjs7yUScJESD/LYpLkrlgFHbkvwR/P21hkBs7+Zx0gU9uT0qGcNieXZBezpokXxvFLx2Ifc0W2hGZJERbZT5s/aTcGEwIOMontYaBEXOb+VnZeTplUQslbMxdH+acoLS5aTpQZTYWAR2ctYCfIsuXBcMHOxflQ949kJUtgdmtRI5xNnmOm3qa99QDUJr0eFkiD3cwOGzp/i79TbqGCJNuxX+SSfnqGDNmt8+K74wSi+ATlTRYQePkyeUiWVmxnEcSj40FwVdU6TRn+2RQQ9hHSBI6tGNhHvtaGYAKDLd1jfn18/l0cKFMx4ECZR3nwVWtbBr9np/ODkVZpvGj1iNW79gk6EmA/vtjf0dLi2jw5zZ0W64E6uTSFxy1JHburupxlSyOHdUJe3qEcudq/Xri0E1hjVCL+I34Rx9Y9fraPsyo9fa0o+a1fv6AEyNOdgaf04sVws4oY73RRRx2oJ/GOWLjRHMG6TYTWvGd4dQnRT5ONP+uUQxvV1zDl8A36MqOBDg3nRd+oIeCfL9dnqoUVO7yMpn2XzAZKOgIbDJzPSEwVaI/sk6sohSvBxD64RMFCsMeCGoC6BE7ms0i3rflU3IpJtxb0lxYwXj8mQm6toPqae7kPRGCpUs7QVdRbJFAb+YWhzZWOinp5dtnFBEB7raEKvldZK MbLEW6m6 Pgx4BzBcYUt5LvltK94a9mBKuXyM6KTVWJkJWQ9E2O9m86a5y8S03pjNhO9ot1ZU1IS2CgzvMSqiWqUzDOuzD8RGFpENPbz6ti5FlDH1BS8jyM3j1JXsR5b/OlfvihJgxEvocnjVoGT4VRAbP3hqVNlDds99E8BmxkwISyqFrZAKWe5wkP0OJGHZAIBcJiRtqhGUoty5lzAK8+jbHrAQdpXrHYFr7OIi57suPw2F0UMGxiIvNRElQt8KQGOi8m1itdve010tUF1RWdPnlDPaNC2IblDl4+pWFzT/U6eUOjij4p+dgWjUqrByxyGtr/O8Jy8LTKlUOdCuXPPWXxecTRbmiAuC2MDJRh5EvOGuUwszlA+0z7+Ttl6uHjvvU7NFLgk3VdavzV6p3lOwFkHpevg0ACZqV2iVz15aR5mbdErRV1zyx9YemZFgnMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 27, 2023 at 11:59:23AM +0800, Liu Shixin wrote: > With 0x%p, the pointer will be hashed and print (____ptrval____) instead. > And with 0x%pa, the pointer can be successfully printed but with duplicate > prefixes, which looks like: > > kmemleak: kmemleak_free(0x(____ptrval____)) > kmemleak: kmemleak_free_part_phys(0x0x0000000a1af86000) > > Use %pa instead of 0x%p or 0x%pa to print the pointer, and use 0x%px for > __percpu pointer to prevent crash. Then the print will be like: Why not %px in all cases? -- Catalin