From: Sean Christopherson <seanjc@google.com>
To: Michal Luczaj <mhal@rbox.co>
Cc: pbonzini@redhat.com, corbet@lwn.net, kvm@vger.kernel.org
Subject: Re: [PATCH 3/3] KVM: Correct kvm_vcpu_event(s) typo in KVM API documentation
Date: Thu, 28 Sep 2023 07:37:17 -0700 [thread overview]
Message-ID: <ZRWPbAW29aGePPNA@google.com> (raw)
In-Reply-To: <e2a0d2cb-bc93-4d36-bf42-6963095b207f@rbox.co>
On Thu, Sep 28, 2023, Michal Luczaj wrote:
> On 9/27/23 22:10, Sean Christopherson wrote:
> > On Tue, Aug 15, 2023, Michal Luczaj wrote:
> >> On 8/15/23 00:08, Michal Luczaj wrote:
> >>> I understand that typo fixes are not always welcomed, but this
> >>> kvm_vcpu_event(s) did actually bit me, causing minor irritation.
> >> ^^^
> >
> > FWIW, my bar for fixing typos is if the typo causes any amount of confusion or
> > wasted time. If it causes one person pain, odds are good it'll cause others pain
> > in the future.
>
> OK, do you want me to resend just the kvm_vcpu_event(s) fix?
> (and, empathetically, introduce a typo in the changelog proper :P)
Oh, no, sorry. I'll take this as-is. Opportunistically fixing misspellings like
you did it totally fine, especially since this is documentation.
What I was trying to say is that if a patch fixes a real issue for someone, I'll
definitely take the time to get it applied. I didn't mean to say I wouldn't take
other typo fixes (though I am inclined to leave code/comments alone if a typo is
benign, in order to reduce the churn in git history).
next prev parent reply other threads:[~2023-09-28 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 22:08 [PATCH 0/3] KVM: x86: Cleanups Michal Luczaj
2023-08-14 22:08 ` [PATCH 1/3] KVM: x86: Remove redundant vcpu->arch.cr0 assignments Michal Luczaj
2023-08-14 22:08 ` [PATCH 2/3] KVM: x86: Force TLB flush on changes to special registers Michal Luczaj
2023-08-14 22:08 ` [PATCH 3/3] KVM: Correct kvm_vcpu_event(s) typo in KVM API documentation Michal Luczaj
2023-08-14 22:28 ` Michal Luczaj
2023-09-27 20:10 ` Sean Christopherson
2023-09-28 11:58 ` Michal Luczaj
2023-09-28 14:37 ` Sean Christopherson [this message]
2023-09-28 16:41 ` [PATCH 0/3] KVM: x86: Cleanups Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRWPbAW29aGePPNA@google.com \
--to=seanjc@google.com \
--cc=corbet@lwn.net \
--cc=kvm@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.