From: Frederic Weisbecker <frederic@kernel.org>
To: Neeraj upadhyay <neeraj.iitr10@gmail.com>
Cc: Joel Fernandes <joel@joelfernandes.org>,
zhuangel570 <zhuangel570@gmail.com>,
paulmck@kernel.org, rcu@vger.kernel.org, josh@joshtriplett.org,
rostedt@goodmis.org, mathieu.desnoyers@efficios.com,
jiangshanlai@gmail.com, like.xu.linux@gmail.com,
linussli@tencent.com, foxywang@tencent.com
Subject: Re: SRCU: kworker hung in synchronize_srcu
Date: Sat, 30 Sep 2023 09:30:32 +0200 [thread overview]
Message-ID: <ZRfOmBO1DxoU65RA@lothringen> (raw)
In-Reply-To: <CAFwiDX9V1tmRo+qv=3=dmPMsDvoRU3vBai3NBP6KBzr6RXGVtA@mail.gmail.com>
On Sat, Sep 30, 2023 at 08:15:06AM +0530, Neeraj upadhyay wrote:
> On Sat, Sep 30, 2023 at 4:15 AM Frederic Weisbecker <frederic@kernel.org> wrote:
> >
> > Le Thu, Sep 28, 2023 at 05:39:17PM -0400, Joel Fernandes a écrit :
> > > If srcu_invoke_callbacks() was really called for the rdp, I would have
> > > expected rcu_segcblist_advance() to advance all those pending
> > > callbacks to 304.
> > >
> > > I posit that probably srcu_invoke_callbacks() is not even being called
> > > in the first place, otherwise why is the DONE segment count still 0?
> > > DONE should not be 0, otherwise callbacks will not run. The segcblist
> > > of the rdp seems out of date perhaps due to rcu_invoke_callbacks() not
> > > being called due to some other bug (or a workqueue/timer issue causing
> > > the srcu_invoke_callbacks() to not run?).
> >
> > Speaking of, I'm looking at srcu_gp_end() and the comment after releasing
> > srcu_gp_mutex says:
> >
> > "/* A new grace period can start at this point. But only one. */"
> >
> > But what ensures that?
> >
>
> I think ->srcu_cb_mutex ensures that.
>
> /* Prevent more than one additional grace period. */
> mutex_lock(&sup->srcu_cb_mutex);
Yes but right ater it's relaxed (before callbacks are schedule for execution)?
next prev parent reply other threads:[~2023-09-30 7:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 7:59 SRCU: kworker hung in synchronize_srcu zhuangel570
2023-09-28 21:39 ` Joel Fernandes
2023-09-28 21:40 ` Joel Fernandes
2023-09-29 1:50 ` Zhouyi Zhou
2023-09-29 22:44 ` Frederic Weisbecker
2023-09-30 2:45 ` Neeraj upadhyay
2023-09-30 7:30 ` Frederic Weisbecker [this message]
2023-09-30 9:10 ` Frederic Weisbecker
2023-09-30 9:48 ` Neeraj upadhyay
2023-09-30 10:01 ` Neeraj upadhyay
2023-10-01 0:19 ` Joel Fernandes
2023-10-01 2:27 ` Neeraj upadhyay
2023-10-01 22:32 ` Frederic Weisbecker
2023-10-01 22:39 ` Frederic Weisbecker
2023-10-02 2:21 ` Neeraj upadhyay
2023-10-02 11:05 ` Frederic Weisbecker
2023-10-02 22:46 ` Frederic Weisbecker
2023-10-03 12:06 ` Neeraj upadhyay
2023-10-02 2:17 ` Neeraj upadhyay
2023-10-02 10:41 ` Frederic Weisbecker
2023-10-02 13:22 ` Neeraj upadhyay
2023-10-02 21:09 ` Frederic Weisbecker
2023-10-03 12:00 ` Neeraj upadhyay
2023-10-03 12:22 ` Frederic Weisbecker
2023-10-03 18:46 ` Neeraj upadhyay
2023-10-07 9:13 ` zhuangel570
2023-10-07 8:53 ` zhuangel570
2023-09-30 10:11 ` Neeraj upadhyay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRfOmBO1DxoU65RA@lothringen \
--to=frederic@kernel.org \
--cc=foxywang@tencent.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=like.xu.linux@gmail.com \
--cc=linussli@tencent.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=neeraj.iitr10@gmail.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=zhuangel570@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.